All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Jim Mattson <jmattson@google.com>,
	Xiong Zhang <xiong.y.zhang@intel.com>,
	Mingwei Zhang <mizhang@google.com>
Subject: Re: [kvm-unit-tests PATCH v7 00/18] x86/pmu: Fixes and improvements
Date: Wed, 19 Feb 2025 17:31:46 +0800	[thread overview]
Message-ID: <586414bd-0b9e-4750-8bbc-b617c59d4fbd@linux.intel.com> (raw)
In-Reply-To: <20250215013636.1214612-1-seanjc@google.com>

Test this patch series on Sapphire Rapids and Granite Rapids against
perf-based vPMU and  mediated vPMU. No failure is found. Thanks.


On 2/15/2025 9:36 AM, Sean Christopherson wrote:
> v7 of Dapeng's PMU fixes/cleanups series.  FWIW, I haven't gone through the
> changes all that carefully, I mostly focused on the high level "what" and the
> style.
>
> This blows up without the per-CPU fixes:
> https://lore.kernel.org/all/20250215012032.1206409-1-seanjc@google.com
>
> v7:
>  - Rewrite the changelog for the patch that shrinks the size of pmu_counter_t.
>  - Cosmetic changes.
>
> v6: https://lore.kernel.org/all/20240914101728.33148-1-dapeng1.mi@linux.intel.com
>
> Dapeng Mi (17):
>   x86: pmu: Remove blank line and redundant space
>   x86: pmu: Refine fixed_events[] names
>   x86: pmu: Align fields in pmu_counter_t to better pack the struct
>   x86: pmu: Enlarge cnt[] length to 48 in check_counters_many()
>   x86: pmu: Print measured event count if test fails
>   x86: pmu: Fix potential out of bound access for fixed events
>   x86: pmu: Fix cycles event validation failure
>   x86: pmu: Use macro to replace hard-coded branches event index
>   x86: pmu: Use macro to replace hard-coded ref-cycles event index
>   x86: pmu: Use macro to replace hard-coded instructions event index
>   x86: pmu: Enable and disable PMCs in loop() asm blob
>   x86: pmu: Improve instruction and branches events verification
>   x86: pmu: Improve LLC misses event verification
>   x86: pmu: Adjust lower boundary of llc-misses event to 0 for legacy
>     CPUs
>   x86: pmu: Add IBPB indirect jump asm blob
>   x86: pmu: Adjust lower boundary of branch-misses event
>   x86: pmu: Optimize emulated instruction validation
>
> Xiong Zhang (1):
>   x86: pmu: Remove duplicate code in pmu_init()
>
>  lib/x86/pmu.c |   5 -
>  x86/pmu.c     | 423 ++++++++++++++++++++++++++++++++++++++++----------
>  2 files changed, 342 insertions(+), 86 deletions(-)
>
>
> base-commit: f77fb696cfd0e4a5562cdca189be557946bf522f

  parent reply	other threads:[~2025-02-19  9:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-15  1:36 [kvm-unit-tests PATCH v7 00/18] x86/pmu: Fixes and improvements Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 01/18] x86: pmu: Remove duplicate code in pmu_init() Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 02/18] x86: pmu: Remove blank line and redundant space Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 03/18] x86: pmu: Refine fixed_events[] names Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 04/18] x86: pmu: Align fields in pmu_counter_t to better pack the struct Sean Christopherson
2025-02-19  1:34   ` Mi, Dapeng
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 05/18] x86: pmu: Enlarge cnt[] length to 48 in check_counters_many() Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 06/18] x86: pmu: Print measured event count if test fails Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 07/18] x86: pmu: Fix potential out of bound access for fixed events Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 08/18] x86: pmu: Fix cycles event validation failure Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 09/18] x86: pmu: Use macro to replace hard-coded branches event index Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 10/18] x86: pmu: Use macro to replace hard-coded ref-cycles " Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 11/18] x86: pmu: Use macro to replace hard-coded instructions " Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 12/18] x86: pmu: Enable and disable PMCs in loop() asm blob Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 13/18] x86: pmu: Improve instruction and branches events verification Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 14/18] x86: pmu: Improve LLC misses event verification Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 15/18] x86: pmu: Adjust lower boundary of llc-misses event to 0 for legacy CPUs Sean Christopherson
2025-02-19  1:49   ` Mi, Dapeng
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 16/18] x86: pmu: Add IBPB indirect jump asm blob Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 17/18] x86: pmu: Adjust lower boundary of branch-misses event Sean Christopherson
2025-02-15  1:36 ` [kvm-unit-tests PATCH v7 18/18] x86: pmu: Optimize emulated instruction validation Sean Christopherson
2025-02-19  9:31 ` Mi, Dapeng [this message]
2025-02-24 17:24 ` [kvm-unit-tests PATCH v7 00/18] x86/pmu: Fixes and improvements Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=586414bd-0b9e-4750-8bbc-b617c59d4fbd@linux.intel.com \
    --to=dapeng1.mi@linux.intel.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=mizhang@google.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=xiong.y.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.