From: Yanjun Zhu <yanjun.zhu@oracle.com>
To: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] r8169: fix the typo
Date: Fri, 30 Dec 2016 10:19:12 +0800 [thread overview]
Message-ID: <5865C420.8030200@oracle.com> (raw)
In-Reply-To: <1482981062-6889-1-git-send-email-yanjun.zhu@oracle.com>
Hi,
Please comment on this patch.
Zhu Yanjun
On 2016/12/29 11:11, Zhu Yanjun wrote:
> >From the realtek data sheet, the PID0 should be bit 0.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
> ---
> drivers/net/ethernet/realtek/r8169.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 44389c9..8f1623b 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -696,7 +696,7 @@ enum rtl_tx_desc_bit_1 {
> enum rtl_rx_desc_bit {
> /* Rx private */
> PID1 = (1 << 18), /* Protocol ID bit 1/2 */
> - PID0 = (1 << 17), /* Protocol ID bit 2/2 */
> + PID0 = (1 << 17), /* Protocol ID bit 0/2 */
>
> #define RxProtoUDP (PID1)
> #define RxProtoTCP (PID0)
parent reply other threads:[~2016-12-30 2:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1482981062-6889-1-git-send-email-yanjun.zhu@oracle.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5865C420.8030200@oracle.com \
--to=yanjun.zhu@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.