From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board Date: Thu, 05 Jan 2017 16:52:51 +0900 Message-ID: <586DFB53.9050709@samsung.com> References: <1483517711-23849-1-git-send-email-hoegeun.kwon@samsung.com> <1483517711-23849-3-git-send-email-hoegeun.kwon@samsung.com> <20170104144439.bzjab3ovixyt3i5b@rob-hp-laptop> <412a0238-dd8e-6c74-46a7-876e112189f1@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <412a0238-dd8e-6c74-46a7-876e112189f1@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda , Rob Herring , Hoegeun Kwon Cc: devicetree@vger.kernel.org, krzk@kernel.org, cw00.choi@samsung.com, Donghwa Lee , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, jh80.chung@samsung.com, linux-samsung-soc@vger.kernel.org, kgene@kernel.org, Hyungwon Hwang List-Id: linux-samsung-soc@vger.kernel.org CgoyMDE364WEIDAx7JuUIDA17J28IDE1OjU17JeQIEFuZHJ6ZWogSGFqZGEg7J20KOqwgCkg7JO0 IOq4gDoKPiBPbiAwNC4wMS4yMDE3IDE1OjQ0LCBSb2IgSGVycmluZyB3cm90ZToKPj4gT24gV2Vk LCBKYW4gMDQsIDIwMTcgYXQgMDU6MTU6MTBQTSArMDkwMCwgSG9lZ2V1biBLd29uIHdyb3RlOgo+ Pj4gVGhpcyBwYXRjaCBhZGQgc3VwcG9ydCBmb3IgTUlQSS1EU0kgYmFzZWQgUzZFM0hBMiBBTU9M RUQgcGFuZWwKPj4+IGRyaXZlci4gVGhpcyBwYW5lbCBoYXMgMTQ0MHgyNTYwIHJlc29sdXRpb24g aW4gNS43LWluY2ggcGh5c2ljYWwKPj4+IHBhbmVsIGluIHRoZSBUTTIgZGV2aWNlLgo+Pj4KPj4+ IFNpZ25lZC1vZmYtYnk6IERvbmdod2EgTGVlIDxkaDA5LmxlZUBzYW1zdW5nLmNvbT4KPj4+IFNp Z25lZC1vZmYtYnk6IEh5dW5nd29uIEh3YW5nIDxodW1hbi5od2FuZ0BzYW1zdW5nLmNvbT4KPj4+ IFNpZ25lZC1vZmYtYnk6IEhvZWdldW4gS3dvbiA8aG9lZ2V1bi5rd29uQHNhbXN1bmcuY29tPgo+ Pj4gLS0tCj4+PiAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvc2Ftc3VuZyxzNmUzaGEyLnR4 dCAgICAgfCAgNDAgKysKPj4+ICBkcml2ZXJzL2dwdS9kcm0vcGFuZWwvS2NvbmZpZyAgICAgICAg ICAgICAgICAgICAgICB8ICAgNiArCj4+PiAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL01ha2VmaWxl ICAgICAgICAgICAgICAgICAgICAgfCAgIDEgKwo+Pj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9w YW5lbC1zYW1zdW5nLXM2ZTNoYTIuYyAgICAgIHwgNzQxICsrKysrKysrKysrKysrKysrKysrKwo+ Pj4gIDQgZmlsZXMgY2hhbmdlZCwgNzg4IGluc2VydGlvbnMoKykKPj4+ICBjcmVhdGUgbW9kZSAx MDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvc2Ft c3VuZyxzNmUzaGEyLnR4dAo+Pj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0v cGFuZWwvcGFuZWwtc2Ftc3VuZy1zNmUzaGEyLmMKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvc2Ftc3VuZyxzNmUzaGEy LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3Nh bXN1bmcsczZlM2hhMi50eHQKPj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+PiBpbmRleCAwMDAw MDAwLi42ODc5ZjUxCj4+PiAtLS0gL2Rldi9udWxsCj4+PiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9zYW1zdW5nLHM2ZTNoYTIudHh0Cj4+PiBA QCAtMCwwICsxLDQwIEBACj4+PiArU2Ftc3VuZyBTNkUzSEEyIDUuNyIgMTQ0MHgyNTYwIEFNT0xF RCBwYW5lbAo+Pj4gKwo+Pj4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4+PiArICAtIGNvbXBhdGli bGU6ICJzYW1zdW5nLHM2ZTNoYTIiCj4+PiArICAtIHJlZzogdGhlIHZpcnR1YWwgY2hhbm5lbCBu dW1iZXIgb2YgYSBEU0kgcGVyaXBoZXJhbAo+Pj4gKyAgLSB2ZGQzLXN1cHBseTogSS9PIHZvbHRh Z2Ugc3VwcGx5Cj4+PiArICAtIHZjaS1zdXBwbHk6IHZvbHRhZ2Ugc3VwcGx5IGZvciBhbmFsb2cg Y2lyY3VpdHMKPj4+ICsgIC0gcmVzZXQtZ3Bpb3M6IGEgR1BJTyBzcGVjIGZvciB0aGUgcmVzZXQg cGluIChhY3RpdmUgbG93KQo+Pj4gKyAgLSBlbmFibGUtZ3Bpb3M6IGEgR1BJTyBzcGVjIGZvciB0 aGUgcGFuZWwgZW5hYmxlIHBpbiAoYWN0aXZlIGhpZ2gpCj4+PiArICAtIHRlLWdwaW9zOiBhIEdQ SU8gc3BlYyBmb3IgdGhlIHRlYXJpbmcgZWZmZWN0IHN5bmNocm9uaXphdGlvbiBzaWduYWwKPj4+ ICsgICAgZ3BpbyBwaW4gKGFjdGl2ZSBoaWdoKQo+Pj4gKwo+Pj4gK1RoZSBkZXZpY2Ugbm9kZSBj YW4gY29udGFpbiBvbmUgJ3BvcnQnIGNoaWxkIG5vZGUgd2l0aCBvbmUgY2hpbGQKPj4+ICsnZW5k cG9pbnQnIG5vZGUsIGFjY29yZGluZyB0byB0aGUgYmluZGluZ3MgZGVmaW5lZCBpbiBbMV0uIFRo aXMKPj4+ICtub2RlIHNob3VsZCBkZXNjcmliZSBwYW5lbCdzIHZpZGVvIGJ1cy4KPj4+ICsKPj4+ ICtbMV06IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS92aWRlby1pbnRl cmZhY2VzLnR4dAo+Pj4gKwo+Pj4gK0V4YW1wbGU6Cj4+PiArCj4+PiArJmRzaSB7Cj4+PiArCS4u Lgo+Pj4gKwo+Pj4gKwlwYW5lbEAwIHsKPj4+ICsJCWNvbXBhdGlibGUgPSAic2Ftc3VuZyxzNmUz aGEyIjsKPj4+ICsJCXJlZyA9IDwwPjsKPj4+ICsJCXZkZDMtc3VwcGx5ID0gPCZsZG8yN19yZWc+ Owo+Pj4gKwkJdmNpLXN1cHBseSA9IDwmbGRvMjhfcmVnPjsKPj4+ICsJCXJlc2V0LWdwaW9zID0g PCZncGcwIDAgR1BJT19BQ1RJVkVfTE9XPjsKPj4+ICsJCWVuYWJsZS1ncGlvcyA9IDwmZ3BmMSA1 IEdQSU9fQUNUSVZFX0hJR0g+Owo+Pj4gKwkJdGUtZ3Bpb3MgPSA8JmdwZjEgMyBHUElPX0FDVElW RV9ISUdIPjsKPj4+ICsKPj4+ICsJCXBvcnQgewo+Pj4gKwkJCXBhbmVsX2luOiBlbmRwb2ludCB7 Cj4+PiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmZHNpX291dD47Cj4+IEFzIEkgc2FpZCBwcmV2 aW91c2x5LCBpdCBtYWtlcyBubyBzZW5zZSB0byBoYXZlIGEgZ3JhcGggdG8gZHNpX291dCBpdCBp cyAKPj4gc2ltcGx5IHRoZSBwYXJlbnQgbm9kZS4KPiAKPiBUaGUgcHJvYmxlbSBpcyB0aGF0IGV4 eW5vc19kc2kgcmVxdWlyZXMgcHJlc2VuY2Ugb2YgZW5kcG9pbnQgbm9kZSwgd2hlbgo+IGl0IHdh cyB3cml0dGVuIHRoZSBwb2xpY3kgd2FzIHRoYXQgZ3JhcGhzIG11c3QgYmUgYWx3YXlzIHByZXNl bnQuCj4gRFNJIHJlYWRzIGZyb20gdGhpcyBub2RlIHNhbXN1bmcsYnVyc3QtY2xvY2stZnJlcXVl bmN5IGFuZAo+IHNhbXN1bmcsZXNjLWNsb2NrLWZyZXF1ZW5jeS4gRm9yIGV4YW1wbGUgaW4gZXh5 bm9zNDQxMi10cmF0czIuZHRzOgo+IAo+PiAgICAgICAgIGRzaV8wOiBkc2lAMTFDODAwMDAgewo+ PiAgICAgICAgICAgICAgICAgLi4uCj4+ICAgICAgICAgICAgICAgICBwb3J0cyB7Cj4+ICAgICAg ICAgICAgICAgICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+PiAgICAgICAgICAgICAg ICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPj4gIAo+PiAgICAgICAgICAgICAgICAgICAg ICAgICBwb3J0QDEgewo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwx PjsKPj4KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkc2lfb3V0OiBlbmRwb2lu dCB7Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZW1vdGUtZW5k cG9pbnQgPSA8JmRzaV9pbj47Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzYW1zdW5nLGJ1cnN0LWNsb2NrLWZyZXF1ZW5jeQo+PiA9IDw1MDAwMDAwMDA+Owo+PiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2Ftc3VuZyxlc2MtY2xvY2st ZnJlcXVlbmN5ID0KPj4gPDIwMDAwMDAwPjsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB9Owo+PiAgICAgICAgICAgICAgICAgICAgICAgICB9Owo+PiAgICAgICAgICAgICAgICAg fTsKPj4gICAgICAgICAKPj4gICAgICAgICAgICAgICAgIHBhbmVsQDAgewo+PiAgICAgICAgICAg ICAgICAgICAgICAgICAuLi4KPj4gICAgICAgICAgICAgICAgICAgICAgICAgcG9ydCB7Cj4+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZHNpX2luOiBlbmRwb2ludCB7Cj4+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZW1vdGUtZW5kcG9pbnQgPSA8JmRz aV9vdXQ+Owo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07Cj4+ICAgICAgICAg ICAgICAgICAgICAgICAgIH07Cj4+ICAgICAgICAgICAgICAgICB9Owo+PiAgICAgICAgIH07Cj4g Cj4gSG93ZXZlciwgRFNJIGRyaXZlciBkb2VzIG5vdCB1c2UgcmVtb3RlLWVuZHBvaW50IHByb3Bl cnR5LCBpdCBpcyBoZXJlCj4gb25seSB0byBmdWxmaWxsIG9mX2dyYXBoIHBvbGljeS4KPiBTbyBp ZiBzb21ldGhpbmcgbGlrZSBiZWxvdyBpcyBhY2NlcHRhYmxlLCB3ZSBjYW4gZ2V0IHJpZCBvZiBw b3J0IG5vZGUgaW4KPiBwYW5lbDoKPiAKPj4gICAgICAgICBkc2lfMDogZHNpQDExQzgwMDAwIHsK Pj4gICAgICAgICAgICAgICAgIC4uLgo+PiAgICAgICAgICAgICAgICAgcG9ydHMgewo+PiAgICAg ICAgICAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsKPj4gICAgICAgICAgICAg ICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47Cj4+ICAKPj4gICAgICAgICAgICAgICAgICAg ICAgICAgcG9ydEAxIHsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8 MT47Cj4+Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZHNpX291dDogZW5kcG9p bnQgewo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2Ftc3VuZyxi dXJzdC1jbG9jay1mcmVxdWVuY3kKPj4gPSA8NTAwMDAwMDAwPjsKPj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHNhbXN1bmcsZXNjLWNsb2NrLWZyZXF1ZW5jeSA9Cj4+ IDwyMDAwMDAwMD47Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPj4gICAg ICAgICAgICAgICAgICAgICAgICAgfTsKPj4gICAgICAgICAgICAgICAgIH07Cj4+ICAgICAgICAg Cj4+ICAgICAgICAgICAgICAgICBwYW5lbEAwIHsKPj4gICAgICAgICAgICAgICAgICAgICAgICAg Li4uCj4+ICAgICAgICAgICAgICAgICB9Owo+PiAgICAgICAgIH07Cj4gCj4gV2hhdCBkbyB5b3Ug dGhpbms/Cj4gCj4gT3RoZXIgc29sdXRpb24gaXMgdG8gbW92ZSBwcm9ibGVtYXRpYyBwcm9wZXJ0 aWVzIHNvbWV3aGVyZSBlbHNlLCBidXQKPiB0aGlzIHJlcXVpcmUgY2hhbmdlIG9mIGJpbmRpbmdz Lgo+IEFueXdheSBJIHdvdWxkIGJlIGdsYWQgdG8gcmVtb3ZlIHBvcnQgbm9kZXMgaW4gb3RoZXIg c2Ftc3VuZyBwYW5lbHM6Cj4gczZlOGFhMCwgbGQ5MDQwLgoKSW4gYWRkaXRpb24sCgpOb3cgZHNp IGFuZCBtaWMgZGV2aWNlIG5vZGVzIG9mIGV4eW5vczU0MzMuZHRzaSBpbmNsdWRlIHJlbW90ZSBu b2RlcyB3aGljaCBkZWZpbmUgRGlzcGxheSBwaXBlbGluZS4gVGhpcyBpcyB3cm9uZy4KRGlzcGxh eSBwaXBlbGluZSBpcyBzcGVjaWZpYyB0byBib2FyZCwgbm90IFNvQyBzbyB0aGVzZSB0aGluZ3Mg c2hvdWxkIGJlIG1vdmVkIHRvIGV4eW5vczU0MzMtdG0yLmR0cyBmaWxlLgoKSG9lZ2V1biwgeW91 IGNhbiBkbyB0aGlzIHdpdGggb3RoZXIgcGF0Y2ggYWxzby4KClRoYW5rcy4KCj4gCj4gUmVnYXJk cwo+IEFuZHJ6ZWoKPiAKPiAtLQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5k IHRoZSBsaW5lICJ1bnN1YnNjcmliZSBkZXZpY2V0cmVlIiBpbgo+IHRoZSBib2R5IG9mIGEgbWVz c2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBh dCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCj4gCj4gCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938084AbdAEHyu (ORCPT ); Thu, 5 Jan 2017 02:54:50 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:43540 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754523AbdAEHxb (ORCPT ); Thu, 5 Jan 2017 02:53:31 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a3d-f79a36d000004dcf-1f-586dfb58ff92 Content-transfer-encoding: 8BIT Message-id: <586DFB53.9050709@samsung.com> Date: Thu, 05 Jan 2017 16:52:51 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andrzej Hajda , Rob Herring , Hoegeun Kwon Cc: thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com, Donghwa Lee , Hyungwon Hwang Subject: Re: [PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board In-reply-to: <412a0238-dd8e-6c74-46a7-876e112189f1@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIJsWRmVeSWpSXmKPExsWy7bCmrm7k79wIgxkBFrfWnWO16D13ksni +pfnrBbzjwC518/bWVz5+p7N4v3yLjaLpTP6WC1u/Gpjteh//JrZ4vz5DewWl3fNYbOYcX4f k8X/PTvYLX7umsfiwO+xc9Zddo9NqzrZPLZ/e8Dqcb/7OJNH35ZVjB6fN8kFsEWl2mSkJqak Fimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAXaykUJaYUwoUCkgs LlbSt7Mpyi8tSVXIyC8usVWKNjQ00jM0MNczMjLSMzGOtTIyBSpJSM3YP3MpW8EjnYpTPx6w NzCelO1i5OSQEDCRuLNzKQuELSZx4d56ti5GLg4hgR2MEk2rVjNDOO1MEhcWPmGG6bj37Bwj RGI5o8T5TYtZQRK8AoISPybfAxrFwcEsIC9x5FI2SJhZQFNi6+717BD19xglft7awgxSwyug JfHiVBWIySKgKnFwKyNIORuQOXHFfTYQW1QgQmLn/G/sICUiAoUSh6bEgExhFrjGJLHhwymw emGBKIkXsyeBPcApYC9x7lMH2GkSAm/ZJdoObGcEaZYQkJXYdADqfBeJ5T+OMUHYwhKvjm9h h7ClJVb9u8UE0dvNKHG9p4cNwulglPjb+R8aRMYS9x/cY4Z4jE/i3dceVogFvBIdbUIQJR4S PfM+QpU7Sny5cAkaVoeYJG4/3c0+gVF+FlJwzUIE1yyk4FrAyLyKUSy1oDg3PbXYsMBSrzgx t7g0L10vOT93EyM4uWrZ7mD8cs7nEKMAB6MSD++NHzkRQqyJZcWVuYcYJTiYlUR4WX/lRgjx piRWVqUW5ccXleakFh9iNAUG90RmKdHkfGDizyuJNzQxMzQxMjE0NDcyMFIS513WaB0hJJCe WJKanZpakFoE08fEwSnVwFhRPXXCx4UBJm+nBOyP/lVbVXrwu3VjXcit2XdSTn/3Kbsd92xR 8d0De9b8eOG0/GemdIu5elP5DA3T7HNN8yfNbygXnLfGXFOqUEz6TXLcWaYplye1sW2RXGB1 TEePY2qduXIJ/6fl78N3FHya3c7xcWbkc6ZlvLOd1ttZneidq96eLWxYf1mJpTgj0VCLuag4 EQC348vDxAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsVy+t9jAd2I37kRBv869SxurTvHatF77iST xfUvz1kt5h8Bcq+ft7O48vU9m8X75V1sFktn9LFa3PjVxmrR//g1s8X58xvYLS7vmsNmMeP8 PiaL/3t2sFv83DWPxYHfY+esu+wem1Z1snls//aA1eN+93Emj74tqxg9Pm+SC2CLcrPJSE1M SS1SSM1Lzk/JzEu3VQoNcdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvG /plL2Qoe6VSc+vGAvYHxpGwXIyeHhICJxL1n5xghbDGJC/fWs3UxcnEICSxllDh4+hEzSIJX QFDix+R7LF2MHBzMAvISRy5lg4SZBdQlJs1bxAxR/4BRYsfxw+wgNbwCWhIvTlWBmCwCqhIH t4KNZwMyJ664zwYSFhWIkOg+UQkSFhEolPi14h/YFGaBa0wST86+YAKpERaIkmhdwgQx/RCT xOr5q1hAGjgF7CXOfepgnMAoMAvJcbMQjpuF5LgFjMyrGCVSC5ILipPScw3zUsv1ihNzi0vz 0vWS83M3MYKj9pnUDsaDu9wPMQpwMCrx8HoI5EYIsSaWFVfmHmKU4GBWEuFl/QUU4k1JrKxK LcqPLyrNSS0+xGgK9N5EZinR5HxgQskriTc0MTcxNzawMLe0NDFSEudtnP0sXEggPbEkNTs1 tSC1CKaPiYNTqoExY1HU2t2C1y/LOXFYbFGYyGlpEacQEmznsfqcphpXc2GA9dsq7u1HhGbn Fa3+bn5yx8WH2+Jj3nKqyTVtyJ7tsD4qYkmJapx18LXm1gc+gg8nnLasu/HoxcPnc42/zoiW U37QurgvUsL69qyp64o+z9p2fYJX9vZ/mhc3BE1MrzQLOXd88dvLSizFGYmGWsxFxYkAGoCs N/ACAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170105075256epcas1p336e3f542101d6fdaa7a1d8f5639b109c X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1M1L1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170104081522epcas5p112698b2499e56dc9027ec1f57f8964ee X-RootMTR: 20170104081522epcas5p112698b2499e56dc9027ec1f57f8964ee References: <1483517711-23849-1-git-send-email-hoegeun.kwon@samsung.com> <1483517711-23849-3-git-send-email-hoegeun.kwon@samsung.com> <20170104144439.bzjab3ovixyt3i5b@rob-hp-laptop> <412a0238-dd8e-6c74-46a7-876e112189f1@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017년 01월 05일 15:55에 Andrzej Hajda 이(가) 쓴 글: > On 04.01.2017 15:44, Rob Herring wrote: >> On Wed, Jan 04, 2017 at 05:15:10PM +0900, Hoegeun Kwon wrote: >>> This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel >>> driver. This panel has 1440x2560 resolution in 5.7-inch physical >>> panel in the TM2 device. >>> >>> Signed-off-by: Donghwa Lee >>> Signed-off-by: Hyungwon Hwang >>> Signed-off-by: Hoegeun Kwon >>> --- >>> .../bindings/display/panel/samsung,s6e3ha2.txt | 40 ++ >>> drivers/gpu/drm/panel/Kconfig | 6 + >>> drivers/gpu/drm/panel/Makefile | 1 + >>> drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 741 +++++++++++++++++++++ >>> 4 files changed, 788 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >>> create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c >>> >>> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >>> new file mode 100644 >>> index 0000000..6879f51 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt >>> @@ -0,0 +1,40 @@ >>> +Samsung S6E3HA2 5.7" 1440x2560 AMOLED panel >>> + >>> +Required properties: >>> + - compatible: "samsung,s6e3ha2" >>> + - reg: the virtual channel number of a DSI peripheral >>> + - vdd3-supply: I/O voltage supply >>> + - vci-supply: voltage supply for analog circuits >>> + - reset-gpios: a GPIO spec for the reset pin (active low) >>> + - enable-gpios: a GPIO spec for the panel enable pin (active high) >>> + - te-gpios: a GPIO spec for the tearing effect synchronization signal >>> + gpio pin (active high) >>> + >>> +The device node can contain one 'port' child node with one child >>> +'endpoint' node, according to the bindings defined in [1]. This >>> +node should describe panel's video bus. >>> + >>> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt >>> + >>> +Example: >>> + >>> +&dsi { >>> + ... >>> + >>> + panel@0 { >>> + compatible = "samsung,s6e3ha2"; >>> + reg = <0>; >>> + vdd3-supply = <&ldo27_reg>; >>> + vci-supply = <&ldo28_reg>; >>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >>> + >>> + port { >>> + panel_in: endpoint { >>> + remote-endpoint = <&dsi_out>; >> As I said previously, it makes no sense to have a graph to dsi_out it is >> simply the parent node. > > The problem is that exynos_dsi requires presence of endpoint node, when > it was written the policy was that graphs must be always present. > DSI reads from this node samsung,burst-clock-frequency and > samsung,esc-clock-frequency. For example in exynos4412-trats2.dts: > >> dsi_0: dsi@11C80000 { >> ... >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> >> port@1 { >> reg = <1>; >> >> dsi_out: endpoint { >> remote-endpoint = <&dsi_in>; >> samsung,burst-clock-frequency >> = <500000000>; >> samsung,esc-clock-frequency = >> <20000000>; >> }; >> }; >> }; >> >> panel@0 { >> ... >> port { >> dsi_in: endpoint { >> remote-endpoint = <&dsi_out>; >> }; >> }; >> }; >> }; > > However, DSI driver does not use remote-endpoint property, it is here > only to fulfill of_graph policy. > So if something like below is acceptable, we can get rid of port node in > panel: > >> dsi_0: dsi@11C80000 { >> ... >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> >> port@1 { >> reg = <1>; >> >> dsi_out: endpoint { >> samsung,burst-clock-frequency >> = <500000000>; >> samsung,esc-clock-frequency = >> <20000000>; >> }; >> }; >> }; >> >> panel@0 { >> ... >> }; >> }; > > What do you think? > > Other solution is to move problematic properties somewhere else, but > this require change of bindings. > Anyway I would be glad to remove port nodes in other samsung panels: > s6e8aa0, ld9040. In addition, Now dsi and mic device nodes of exynos5433.dtsi include remote nodes which define Display pipeline. This is wrong. Display pipeline is specific to board, not SoC so these things should be moved to exynos5433-tm2.dts file. Hoegeun, you can do this with other patch also. Thanks. > > Regards > Andrzej > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >