From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v2 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other Date: Thu, 05 Jan 2017 18:45:46 +0900 Message-ID: <586E15CA.6060002@samsung.com> References: <1483604833-29746-1-git-send-email-jcsing.lee@samsung.com> <1483604833-29746-4-git-send-email-jcsing.lee@samsung.com> <586E0E56.6050608@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary_(ID_UCz0DblgX3o/EjTXYf95eA)" Return-path: In-reply-to: <586E0E56.6050608@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jaechul Lee , Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , beomho.seo@samsung.com, linux-input@vger.kernel.org, galaxyra@gmail.com, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org This is a multi-part message in MIME format. --Boundary_(ID_UCz0DblgX3o/EjTXYf95eA) Content-type: text/plain; charset=euc-kr Content-transfer-encoding: 8BIT Hi Andi, I correct the my previous comment about ldo23 and ldo25 because I check the final schematic document, I worked with wrong information of ldo23 and ldo25 on the patch[1]. [1] https://lkml.org/lkml/2016/11/3/61 I'll send the fix patch to you right now after that you better to work for these patches. On 2017년 01월 05일 18:13, Chanwoo Choi wrote: > Hi, > > I add the some comment as following: > - ldo23/25/31/38 have the different value between tm2 and tm2e. > - The patch[1] was alread posted. I think you better to rebase this patch on patch[1]. > [1] https://patchwork.kernel.org/patch/9491769/ > - ("ARM64: dts: TM2: comply to the samsung pinctrl naming convention") > > I add detailed comments on below. > > On 2017년 01월 05일 17:27, Jaechul Lee wrote: >> From: Andi Shyti >> >> Currently tm2e dts includes tm2 but there are some differences >> between the two boards and tm2 has some properties that tm2e >> doesn't have. >> >> That's why it's important to keep the two dts files independent >> and put all the commonalities in a tm2-common.dtsi file. >> >> Signed-off-by: Andi Shyti >> Signed-off-by: Jaechul Lee >> --- >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 1116 +++++++++++++++++++ >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1138 +------------------- >> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 2 +- >> 3 files changed, 1136 insertions(+), 1120 deletions(-) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> rewrite arch/arm64/boot/dts/exynos/exynos5433-tm2.dts (98%) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> new file mode 100644 >> index 0000000..7ad0019 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -0,0 +1,1116 @@ >> +/* >> + * SAMSUNG Exynos5433 TM2 board device tree source >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * >> + * Device tree source file for Samsung's TM2 board which is based on >> + * Samsung Exynos5433 SoC. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/dts-v1/; >> +#include "exynos5433.dtsi" >> +#include >> +#include >> +#include >> +#include >> + > > [snip] > >> +&hsi2c_0 { >> + status = "okay"; >> + clock-frequency = <2500000>; >> + >> + s2mps13-pmic@66 { >> + compatible = "samsung,s2mps13-pmic"; >> + interrupt-parent = <&gpa0>; >> + interrupts = <7 IRQ_TYPE_NONE>; >> + reg = <0x66>; >> + samsung,s2mps11-wrstbi-ground; >> + >> + s2mps13_osc: clocks { >> + compatible = "samsung,s2mps13-clk"; >> + #clock-cells = <1>; >> + clock-output-names = "s2mps13_ap", "s2mps13_cp", >> + "s2mps13_bt"; >> + }; >> + >> + regulators { >> + ldo1_reg: LDO1 { >> + regulator-name = "VDD_ALIVE_0.9V_AP"; >> + regulator-min-microvolt = <900000>; >> + regulator-max-microvolt = <900000>; >> + regulator-always-on; >> + }; >> + >> + ldo2_reg: LDO2 { >> + regulator-name = "VDDQ_MMC2_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo3_reg: LDO3 { >> + regulator-name = "VDD1_E_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + }; >> + >> + ldo4_reg: LDO4 { >> + regulator-name = "VDD10_MIF_PLL_1.0V_AP"; >> + regulator-min-microvolt = <1300000>; >> + regulator-max-microvolt = <1300000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo5_reg: LDO5 { >> + regulator-name = "VDD10_DPLL_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo6_reg: LDO6 { >> + regulator-name = "VDD10_MIPI2L_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo7_reg: LDO7 { >> + regulator-name = "VDD18_MIPI2L_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo8_reg: LDO8 { >> + regulator-name = "VDD18_LLI_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo9_reg: LDO9 { >> + regulator-name = "VDD18_ABB_ETC_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo10_reg: LDO10 { >> + regulator-name = "VDD33_USB30_3.0V_AP"; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo11_reg: LDO11 { >> + regulator-name = "VDD_INT_M_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo12_reg: LDO12 { >> + regulator-name = "VDD_KFC_M_1.1V_AP"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1350000>; >> + regulator-always-on; >> + }; >> + >> + ldo13_reg: LDO13 { >> + regulator-name = "VDD_G3D_M_0.95V_AP"; >> + regulator-min-microvolt = <950000>; >> + regulator-max-microvolt = <950000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo14_reg: LDO14 { >> + regulator-name = "VDDQ_M1_LDO_1.2V_AP"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo15_reg: LDO15 { >> + regulator-name = "VDDQ_M2_LDO_1.2V_AP"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo16_reg: LDO16 { >> + regulator-name = "VDDQ_EFUSE"; >> + regulator-min-microvolt = <1400000>; >> + regulator-max-microvolt = <3400000>; >> + regulator-always-on; >> + }; >> + >> + ldo17_reg: LDO17 { >> + regulator-name = "V_TFLASH_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + }; >> + >> + ldo18_reg: LDO18 { >> + regulator-name = "V_CODEC_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo19_reg: LDO19 { >> + regulator-name = "VDDA_1.8V_COMP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + }; >> + >> + ldo20_reg: LDO20 { >> + regulator-name = "VCC_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-always-on; >> + }; >> + >> + ldo21_reg: LDO21 { >> + regulator-name = "VT_CAM_1.8V"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo22_reg: LDO22 { >> + regulator-name = "CAM_IO_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo23_reg: LDO23 { >> + regulator-name = "CAM_SEN_CORE_1.2V_AP"; >> + regulator-min-microvolt = <1050000>; >> + regulator-max-microvolt = <1200000>; > > ldo23_reg has the different value between tm2 and tm2e. > - tm2 : name - CAM_SEN_CORE_1.2V_AP, max-microvolt :1200000 > - tm2e : name - CAM_SEN_CORE_1.025V_AP, max-microvolt :1050000 To check the final schematic document, ldo23 is used on both tm2 and tm2e without difference. But, name is CAM_SEN_CORE_1.05V_AP > >> + }; >> + >> + ldo24_reg: LDO24 { >> + regulator-name = "VT_CAM_1.2V"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + }; >> + >> + ldo25_reg: LDO25 { >> + regulator-name = "CAM_SEN_A2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + }; > > ldo25 is only used on TM2 and has the different name between tm2 and tm2e. > - tm2 : name - CAM_SEN_A2.8V_AP > - tm2e : name - UNUSED_LDO15 To check the final schematic document, ldo25 is not used on both tm2 and tm2e. [snip] -- Best Regards, Chanwoo Choi Samsung Electronics --Boundary_(ID_UCz0DblgX3o/EjTXYf95eA) Content-type: text/x-vcard; CHARSET=EUC-KR; name=cw00_choi.vcf Content-transfer-encoding: base64 Content-disposition: attachment; filename=cw00_choi.vcf bnVsbA0K --Boundary_(ID_UCz0DblgX3o/EjTXYf95eA) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --Boundary_(ID_UCz0DblgX3o/EjTXYf95eA)-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Thu, 05 Jan 2017 18:45:46 +0900 Subject: [PATCH v2 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other In-Reply-To: <586E0E56.6050608@samsung.com> References: <1483604833-29746-1-git-send-email-jcsing.lee@samsung.com> <1483604833-29746-4-git-send-email-jcsing.lee@samsung.com> <586E0E56.6050608@samsung.com> Message-ID: <586E15CA.6060002@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andi, I correct the my previous comment about ldo23 and ldo25 because I check the final schematic document, I worked with wrong information of ldo23 and ldo25 on the patch[1]. [1] https://lkml.org/lkml/2016/11/3/61 I'll send the fix patch to you right now after that you better to work for these patches. On 2017? 01? 05? 18:13, Chanwoo Choi wrote: > Hi, > > I add the some comment as following: > - ldo23/25/31/38 have the different value between tm2 and tm2e. > - The patch[1] was alread posted. I think you better to rebase this patch on patch[1]. > [1] https://patchwork.kernel.org/patch/9491769/ > - ("ARM64: dts: TM2: comply to the samsung pinctrl naming convention") > > I add detailed comments on below. > > On 2017? 01? 05? 17:27, Jaechul Lee wrote: >> From: Andi Shyti >> >> Currently tm2e dts includes tm2 but there are some differences >> between the two boards and tm2 has some properties that tm2e >> doesn't have. >> >> That's why it's important to keep the two dts files independent >> and put all the commonalities in a tm2-common.dtsi file. >> >> Signed-off-by: Andi Shyti >> Signed-off-by: Jaechul Lee >> --- >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 1116 +++++++++++++++++++ >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1138 +------------------- >> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 2 +- >> 3 files changed, 1136 insertions(+), 1120 deletions(-) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> rewrite arch/arm64/boot/dts/exynos/exynos5433-tm2.dts (98%) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> new file mode 100644 >> index 0000000..7ad0019 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -0,0 +1,1116 @@ >> +/* >> + * SAMSUNG Exynos5433 TM2 board device tree source >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * >> + * Device tree source file for Samsung's TM2 board which is based on >> + * Samsung Exynos5433 SoC. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/dts-v1/; >> +#include "exynos5433.dtsi" >> +#include >> +#include >> +#include >> +#include >> + > > [snip] > >> +&hsi2c_0 { >> + status = "okay"; >> + clock-frequency = <2500000>; >> + >> + s2mps13-pmic at 66 { >> + compatible = "samsung,s2mps13-pmic"; >> + interrupt-parent = <&gpa0>; >> + interrupts = <7 IRQ_TYPE_NONE>; >> + reg = <0x66>; >> + samsung,s2mps11-wrstbi-ground; >> + >> + s2mps13_osc: clocks { >> + compatible = "samsung,s2mps13-clk"; >> + #clock-cells = <1>; >> + clock-output-names = "s2mps13_ap", "s2mps13_cp", >> + "s2mps13_bt"; >> + }; >> + >> + regulators { >> + ldo1_reg: LDO1 { >> + regulator-name = "VDD_ALIVE_0.9V_AP"; >> + regulator-min-microvolt = <900000>; >> + regulator-max-microvolt = <900000>; >> + regulator-always-on; >> + }; >> + >> + ldo2_reg: LDO2 { >> + regulator-name = "VDDQ_MMC2_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo3_reg: LDO3 { >> + regulator-name = "VDD1_E_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + }; >> + >> + ldo4_reg: LDO4 { >> + regulator-name = "VDD10_MIF_PLL_1.0V_AP"; >> + regulator-min-microvolt = <1300000>; >> + regulator-max-microvolt = <1300000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo5_reg: LDO5 { >> + regulator-name = "VDD10_DPLL_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo6_reg: LDO6 { >> + regulator-name = "VDD10_MIPI2L_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo7_reg: LDO7 { >> + regulator-name = "VDD18_MIPI2L_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo8_reg: LDO8 { >> + regulator-name = "VDD18_LLI_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo9_reg: LDO9 { >> + regulator-name = "VDD18_ABB_ETC_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo10_reg: LDO10 { >> + regulator-name = "VDD33_USB30_3.0V_AP"; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo11_reg: LDO11 { >> + regulator-name = "VDD_INT_M_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo12_reg: LDO12 { >> + regulator-name = "VDD_KFC_M_1.1V_AP"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1350000>; >> + regulator-always-on; >> + }; >> + >> + ldo13_reg: LDO13 { >> + regulator-name = "VDD_G3D_M_0.95V_AP"; >> + regulator-min-microvolt = <950000>; >> + regulator-max-microvolt = <950000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo14_reg: LDO14 { >> + regulator-name = "VDDQ_M1_LDO_1.2V_AP"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo15_reg: LDO15 { >> + regulator-name = "VDDQ_M2_LDO_1.2V_AP"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo16_reg: LDO16 { >> + regulator-name = "VDDQ_EFUSE"; >> + regulator-min-microvolt = <1400000>; >> + regulator-max-microvolt = <3400000>; >> + regulator-always-on; >> + }; >> + >> + ldo17_reg: LDO17 { >> + regulator-name = "V_TFLASH_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + }; >> + >> + ldo18_reg: LDO18 { >> + regulator-name = "V_CODEC_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo19_reg: LDO19 { >> + regulator-name = "VDDA_1.8V_COMP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + }; >> + >> + ldo20_reg: LDO20 { >> + regulator-name = "VCC_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-always-on; >> + }; >> + >> + ldo21_reg: LDO21 { >> + regulator-name = "VT_CAM_1.8V"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo22_reg: LDO22 { >> + regulator-name = "CAM_IO_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo23_reg: LDO23 { >> + regulator-name = "CAM_SEN_CORE_1.2V_AP"; >> + regulator-min-microvolt = <1050000>; >> + regulator-max-microvolt = <1200000>; > > ldo23_reg has the different value between tm2 and tm2e. > - tm2 : name - CAM_SEN_CORE_1.2V_AP, max-microvolt :1200000 > - tm2e : name - CAM_SEN_CORE_1.025V_AP, max-microvolt :1050000 To check the final schematic document, ldo23 is used on both tm2 and tm2e without difference. But, name is CAM_SEN_CORE_1.05V_AP > >> + }; >> + >> + ldo24_reg: LDO24 { >> + regulator-name = "VT_CAM_1.2V"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + }; >> + >> + ldo25_reg: LDO25 { >> + regulator-name = "CAM_SEN_A2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + }; > > ldo25 is only used on TM2 and has the different name between tm2 and tm2e. > - tm2 : name - CAM_SEN_A2.8V_AP > - tm2e : name - UNUSED_LDO15 To check the final schematic document, ldo25 is not used on both tm2 and tm2e. [snip] -- Best Regards, Chanwoo Choi Samsung Electronics -------------- next part -------------- A non-text attachment was scrubbed... Name: cw00_choi.vcf Type: text/x-vcard Size: 6 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761442AbdAEJ46 (ORCPT ); Thu, 5 Jan 2017 04:56:58 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:57712 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbdAEJ4A (ORCPT ); Thu, 5 Jan 2017 04:56:00 -0500 MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_lHS/A8lXQycJHicjo1slng)" X-AuditID: b6c32a59-f79486d000002ff5-d1-586e15cc5c07 Message-id: <586E15CA.6060002@samsung.com> Date: Thu, 05 Jan 2017 18:45:46 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Jaechul Lee , Dmitry Torokhov , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas Cc: Andi Shyti , beomho.seo@samsung.com, galaxyra@gmail.com, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other In-reply-to: <586E0E56.6050608@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLJsWRmVeSWpSXmKPExsWy7bCmhu4Z0bwIgy9v+C22H3nGanH60zZ2 i/fLehgt5h85x2pxeNELRovjK2cxW7x5u4bJ4u3+bmaL/sevmS3On9/AbrHp8TVWi5ufvrFa XN41h81ixvl9TBZLr19ksmjde4Td4uXHEywOgh5r5q1h9Ng56y67x6ZVnWwem5fUe2zpB/L6 tqxi9Pi8SS6APSrVJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUn QNctMwfoAyWFssScUqBQQGJxsZK+nU1RfmlJqkJGfnGJrVK0oaGRnqGBuZ6RkZGeiXGslZEp UElCasbvbx8ZC774VSxuns7WwHjItouRg0NCwETiyM6ELkZOIFNM4sK99WxdjFwcQgJLGSUm rr3DCOG0M0msbmhjh6gykbiyZDcTRGIOo8S6x/fZQBK8AoISPybfYwGxmQUCJA5+nMUKUXQP aNSmz6wQRVoSy/q2sYKsZhFQldizJBgkzAYU3v/iBtgcfgFFias/HjOC2KICERI7539jB5kj IvCWSeLczbtgDrPAT0aJS60TwDqEBeIltj1dD9bBKaAt8b1lBQvEqSc4JJ5f4oP4U1Zi0wFm iLCLxJQft6FKhCVeHd8C9Zm0xN+lt8BelhCYzCjRtfYvM4TTwyjRuOYoG0SVscT9B/eYId7k k+j9/YQJYgGvREebEITpIXFqvxhEtaPEvh2rocH4g1Fi9sWdzBMY5WchBdgspACbBdTODAyM /iU1EKa8xJFL2RAVBhL9Fw8zQtiKEtMWNUDZlhJvt35gXcDIvopRLLWgODc9tdi0wFSvODG3 uDQvXS85P3cTIzi5a0XuYLwyM+gQowAHoxIPr0RNboQQa2JZcWXuIUYVoEGPNqy+wCjFkpef l6okwrteMC9CiDclsbIqtSg/vqg0J7X4EKMpMNYmMkuJJucDM1JeSbyhiZmhiZElEJobmiuJ 8y6osI4QEkhPLEnNTk0tSC2C6WPi4JRqYNQpTM9knioh9nDtCrMg3eC0peL2m/L9LuuLbljR ZHY6K1tjw64iI8fsKLXGCznOGY/klh2LMrzBMcu2yNDa/8nE0MueJ09bKW/JvrA4pPn34p3K qQ0TLl+wce/bWps0Y3ZEvsj5kNdKCyPl/hvZ/07N3qi6pv9+1YUOU5XdJmezVIU3v11Rq8RS nJFoqMVcVJwIAE9nGUMQBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsVy+t9jQd3TonkRBtc+sVlsP/KM1eL0p23s Fu+X9TBazD9yjtXi8KIXjBbHV85itnjzdg2Txdv93cwW/Y9fM1ucP7+B3WLT42usFjc/fWO1 uLxrDpvFjPP7mCyWXr/IZNG69wi7xcuPJ1gcBD3WzFvD6LFz1l12j02rOtk8Ni+p99jSD+T1 bVnF6PF5k1wAe5SbTUZqYkpqkUJqXnJ+SmZeuq1SaIibroWSQl5ibqqtUoSub0iQkkJZYk4p kGdkgAYcnAPcg5X07RLcMlZ8Pc1a8MKv4sSRFtYGxm22XYycHBICJhJXluxmgrDFJC7cW8/W xcjFISQwi1Hi2tU7bCAJXgFBiR+T77GA2MwCfhJ3b71hhSh6wChx8mwjE0SRlsSyvm1ACQ4O FgFViT1LgkHCbEDh/S9ugM3hF1CUuPrjMSNIiahAhET3iUqQMSICb5kkGm81MIE4zAI/GSVW bnrEDtIgLBAv0XaslQli2Q9Gic5Z65lBEpwC2hLfW1awTGAEuhPhwFlIDoSwNSTubj0AZHMA 2fISRy5lQ4T1JP4f+s4CEz54XhYibC7x7NYWlgWM7KsYJVILkguKk9JzjfJSy/WKE3OLS/PS 9ZLzczcxghPHM+kdjId3uR9iFOBgVOLh7fibEyHEmlhWXJl7iFEFaNSjDasvMEqx5OXnpSqJ 8K4XzIsQ4k1JrKxKLcqPLyrNSS0+xGgKDKeJzFKiyfnAZJdXEm9oYm5ibmxgYW5paWKkJM7b OPtZuJBAemJJanZqakFqEUwfEwenVAOjFM+Ga/cOM63Z96nkhzy3foTfpwtdn1lO9QjNm5Ry uzpJzO3ptFXhh/Z3bBdS2juDl+1S0AuWM7tO7TjnvM1o9kvV8nlnXJNmfzeWrf8UL/D8AXPT jJaDB44VrJreUeRlPOdp9WvV3KvifsoLKgo2/iko03l+KvBm2fJrhX1BcjvSbxw4Y/fnvRJL cUaioRZzUXEiAL/TPAM+AwAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170105094547epcas5p13299177b32b39787f0b2ac253d30c3fe X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170105082716epcas1p1f2a6eea40d842e2d8f7f7f54c029bc82 X-RootMTR: 20170105082716epcas1p1f2a6eea40d842e2d8f7f7f54c029bc82 References: <1483604833-29746-1-git-send-email-jcsing.lee@samsung.com> <1483604833-29746-4-git-send-email-jcsing.lee@samsung.com> <586E0E56.6050608@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --Boundary_(ID_lHS/A8lXQycJHicjo1slng) Content-type: text/plain; charset=euc-kr Content-transfer-encoding: 8BIT Hi Andi, I correct the my previous comment about ldo23 and ldo25 because I check the final schematic document, I worked with wrong information of ldo23 and ldo25 on the patch[1]. [1] https://lkml.org/lkml/2016/11/3/61 I'll send the fix patch to you right now after that you better to work for these patches. On 2017년 01월 05일 18:13, Chanwoo Choi wrote: > Hi, > > I add the some comment as following: > - ldo23/25/31/38 have the different value between tm2 and tm2e. > - The patch[1] was alread posted. I think you better to rebase this patch on patch[1]. > [1] https://patchwork.kernel.org/patch/9491769/ > - ("ARM64: dts: TM2: comply to the samsung pinctrl naming convention") > > I add detailed comments on below. > > On 2017년 01월 05일 17:27, Jaechul Lee wrote: >> From: Andi Shyti >> >> Currently tm2e dts includes tm2 but there are some differences >> between the two boards and tm2 has some properties that tm2e >> doesn't have. >> >> That's why it's important to keep the two dts files independent >> and put all the commonalities in a tm2-common.dtsi file. >> >> Signed-off-by: Andi Shyti >> Signed-off-by: Jaechul Lee >> --- >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 1116 +++++++++++++++++++ >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 1138 +------------------- >> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 2 +- >> 3 files changed, 1136 insertions(+), 1120 deletions(-) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> rewrite arch/arm64/boot/dts/exynos/exynos5433-tm2.dts (98%) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> new file mode 100644 >> index 0000000..7ad0019 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -0,0 +1,1116 @@ >> +/* >> + * SAMSUNG Exynos5433 TM2 board device tree source >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * >> + * Device tree source file for Samsung's TM2 board which is based on >> + * Samsung Exynos5433 SoC. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/dts-v1/; >> +#include "exynos5433.dtsi" >> +#include >> +#include >> +#include >> +#include >> + > > [snip] > >> +&hsi2c_0 { >> + status = "okay"; >> + clock-frequency = <2500000>; >> + >> + s2mps13-pmic@66 { >> + compatible = "samsung,s2mps13-pmic"; >> + interrupt-parent = <&gpa0>; >> + interrupts = <7 IRQ_TYPE_NONE>; >> + reg = <0x66>; >> + samsung,s2mps11-wrstbi-ground; >> + >> + s2mps13_osc: clocks { >> + compatible = "samsung,s2mps13-clk"; >> + #clock-cells = <1>; >> + clock-output-names = "s2mps13_ap", "s2mps13_cp", >> + "s2mps13_bt"; >> + }; >> + >> + regulators { >> + ldo1_reg: LDO1 { >> + regulator-name = "VDD_ALIVE_0.9V_AP"; >> + regulator-min-microvolt = <900000>; >> + regulator-max-microvolt = <900000>; >> + regulator-always-on; >> + }; >> + >> + ldo2_reg: LDO2 { >> + regulator-name = "VDDQ_MMC2_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo3_reg: LDO3 { >> + regulator-name = "VDD1_E_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + }; >> + >> + ldo4_reg: LDO4 { >> + regulator-name = "VDD10_MIF_PLL_1.0V_AP"; >> + regulator-min-microvolt = <1300000>; >> + regulator-max-microvolt = <1300000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo5_reg: LDO5 { >> + regulator-name = "VDD10_DPLL_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo6_reg: LDO6 { >> + regulator-name = "VDD10_MIPI2L_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo7_reg: LDO7 { >> + regulator-name = "VDD18_MIPI2L_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo8_reg: LDO8 { >> + regulator-name = "VDD18_LLI_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo9_reg: LDO9 { >> + regulator-name = "VDD18_ABB_ETC_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo10_reg: LDO10 { >> + regulator-name = "VDD33_USB30_3.0V_AP"; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo11_reg: LDO11 { >> + regulator-name = "VDD_INT_M_1.0V_AP"; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo12_reg: LDO12 { >> + regulator-name = "VDD_KFC_M_1.1V_AP"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1350000>; >> + regulator-always-on; >> + }; >> + >> + ldo13_reg: LDO13 { >> + regulator-name = "VDD_G3D_M_0.95V_AP"; >> + regulator-min-microvolt = <950000>; >> + regulator-max-microvolt = <950000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo14_reg: LDO14 { >> + regulator-name = "VDDQ_M1_LDO_1.2V_AP"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo15_reg: LDO15 { >> + regulator-name = "VDDQ_M2_LDO_1.2V_AP"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-always-on; >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + ldo16_reg: LDO16 { >> + regulator-name = "VDDQ_EFUSE"; >> + regulator-min-microvolt = <1400000>; >> + regulator-max-microvolt = <3400000>; >> + regulator-always-on; >> + }; >> + >> + ldo17_reg: LDO17 { >> + regulator-name = "V_TFLASH_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + }; >> + >> + ldo18_reg: LDO18 { >> + regulator-name = "V_CODEC_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo19_reg: LDO19 { >> + regulator-name = "VDDA_1.8V_COMP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + }; >> + >> + ldo20_reg: LDO20 { >> + regulator-name = "VCC_2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + regulator-always-on; >> + }; >> + >> + ldo21_reg: LDO21 { >> + regulator-name = "VT_CAM_1.8V"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo22_reg: LDO22 { >> + regulator-name = "CAM_IO_1.8V_AP"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + ldo23_reg: LDO23 { >> + regulator-name = "CAM_SEN_CORE_1.2V_AP"; >> + regulator-min-microvolt = <1050000>; >> + regulator-max-microvolt = <1200000>; > > ldo23_reg has the different value between tm2 and tm2e. > - tm2 : name - CAM_SEN_CORE_1.2V_AP, max-microvolt :1200000 > - tm2e : name - CAM_SEN_CORE_1.025V_AP, max-microvolt :1050000 To check the final schematic document, ldo23 is used on both tm2 and tm2e without difference. But, name is CAM_SEN_CORE_1.05V_AP > >> + }; >> + >> + ldo24_reg: LDO24 { >> + regulator-name = "VT_CAM_1.2V"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + }; >> + >> + ldo25_reg: LDO25 { >> + regulator-name = "CAM_SEN_A2.8V_AP"; >> + regulator-min-microvolt = <2800000>; >> + regulator-max-microvolt = <2800000>; >> + }; > > ldo25 is only used on TM2 and has the different name between tm2 and tm2e. > - tm2 : name - CAM_SEN_A2.8V_AP > - tm2e : name - UNUSED_LDO15 To check the final schematic document, ldo25 is not used on both tm2 and tm2e. [snip] -- Best Regards, Chanwoo Choi Samsung Electronics --Boundary_(ID_lHS/A8lXQycJHicjo1slng) Content-type: text/x-vcard; CHARSET=EUC-KR; name=cw00_choi.vcf Content-transfer-encoding: base64 Content-disposition: attachment; filename=cw00_choi.vcf bnVsbA0K --Boundary_(ID_lHS/A8lXQycJHicjo1slng)--