Re: [PATCH 2/3] ARM64: dts: exynos5433: add HDMI node

[Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]

Hi Andrzej,

On 2017년 01월 06일 00:25, Andrzej Hajda wrote:
> HDMI converts RGB/I80 signal from DECON_TV to HDMI/TMDS video stream.
> 
> Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index b47951b..cf45446 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -843,6 +843,36 @@
>  			iommu-names = "m0", "m1";
>  		};
>  
> +		hdmi: hdmi@13970000 {
> +			compatible = "samsung,exynos5433-hdmi";
> +			reg = <0x13970000 0x70000>;
> +			interrupts = <0 208 0>;

Need touse the interrupt definitions.

> +			clocks = <&cmu_disp CLK_PCLK_HDMI>,
> +				<&cmu_disp CLK_PCLK_HDMIPHY>,
> +				<&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO>,
> +				<&cmu_disp CLK_PHYCLK_HDMI_PIXEL>,
> +				<&cmu_disp CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY>,
> +				<&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_TMDS_CLKO_USER>,
> +				<&cmu_disp CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY>,
> +				<&cmu_disp CLK_MOUT_PHYCLK_HDMIPHY_PIXEL_CLKO_USER>,
> +				<&xxti>, <&cmu_disp CLK_SCLK_HDMI_SPDIF>;
> +			clock-names = "hdmi_pclk", "hdmi_i_pclk",
> +				"i_tmds_clk", "i_pixel_clk",
> +				"tmds_clko", "tmds_clko_user",
> +				"pixel_clko", "pixel_clko_user",
> +				"oscclk", "i_spdif_clk";
> +			phy = <&hdmiphy>;
> +			ddc = <&hsi2c_11>;
> +			samsung,syscon-phandle = <&pmu_system_controller>;
> +			samsung,sysreg-phandle = <&syscon_disp>;
> +			power-domains = <&pd_disp>;

The Exynos5433 has not yet supported the power domain.
You need to remove this property.

> +			status = "disabled";
> +		};
> +
> +		hdmiphy: hdmiphy@13af0000 {
> +			reg = <0x13af0000 0x80>;
> +		};
> +
>  		syscon_disp: syscon@13b80000 {
>  			compatible = "syscon";
>  			reg = <0x13b80000 0x1010>;
> 


-- 
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html