Re: [Qemu-devel] [PATCH RESEND 2/6] crypto: add AEAD algorithms framework

["Longpeng (Mike)" <longpeng2@huawei.com>]

Hi Daniel,

On 2017/1/6 19:28, Daniel P. Berrange wrote:

> On Thu, Jan 05, 2017 at 08:49:37AM +0800, Longpeng(Mike) wrote:
>> This patch introduce AEAD algorithms framework.
> 
> So AEAD is essentially just encryption with extra metadata on
> input and output stages. As such I don't think this should be
> implemented via new objects in QEMU.
> 
> Instead, we should add the extra APIs to the existing
> cipher.{c,h} file.
> 
> You've only implemented AES support here, so the code duplication
> is not obvious, but if we were to extend AEAD to other algorithms
> we'd see alot of duplication with the way you've done things.
> 
> So....
> 


All right, I will rework this recently. :)

>> ......

>> -  'data': ['ecb', 'cbc', 'xts', 'ctr']}
>> +  'data': ['ccm', 'gcm', 'ecb', 'cbc', 'xts', 'ctr']}
> 
> This is fine.
> 
> Regards,
> Daniel


-- 
Regards,
Longpeng(Mike)