From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933110AbdAGX2a (ORCPT ); Sat, 7 Jan 2017 18:28:30 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36452 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933032AbdAGX22 (ORCPT ); Sat, 7 Jan 2017 18:28:28 -0500 Message-ID: <58717993.3010906@gmail.com> Date: Sat, 07 Jan 2017 23:28:19 +0000 From: Sudip Mukherjee User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Alan Stern , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Subject: Re: [PATCH] usb: storage: ene_ub6250: remove unused variable References: <1482100471-2471-1-git-send-email-sudipm.mukherjee@gmail.com> <20170105183631.GA23141@kroah.com> In-Reply-To: <20170105183631.GA23141@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote: > On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote: >> The variable Newblk was only being assigned some value but was never >> used after that. >> >> Signed-off-by: Sudip Mukherjee >> --- >> drivers/usb/storage/ene_ub6250.c | 2 -- >> 1 file changed, 2 deletions(-) > > from and signed-off-by does not match :( > > Same with your other usb patch... > I can add the From: tag in the patch. But this is from the last time we had this same conversation. http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html Regards Sudip