From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH v7 1/4] drm/exynos: mic: Add mode_set callback function Date: Wed, 11 Jan 2017 14:33:12 +0900 Message-ID: <5875C398.6000906@samsung.com> References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-2-git-send-email-hoegeun.kwon@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-reply-to: <1483611609-23522-2-git-send-email-hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hoegeun Kwon , robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get videomode struct through > mode_set callback function. > > Signed-off-by: Hoegeun Kwon > Reviewed-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > index a0def0b..fed1a94 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > @@ -286,13 +286,6 @@ static int parse_dt(struct exynos_mic *mic) > } > nodes[j++] = remote_node; > > - ret = of_get_videomode(remote_node, > - &mic->vm, 0); > - if (ret) { > - DRM_ERROR("mic: failed to get videomode"); > - goto exit; > - } > - > break; > default: > DRM_ERROR("mic: Unknown endpoint from MIC"); > @@ -329,6 +322,17 @@ static void mic_post_disable(struct drm_bridge *bridge) > mutex_unlock(&mic_mutex); > } > > +static void mic_mode_set(struct drm_bridge *bridge, > + struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode) > +{ > + struct exynos_mic *mic = bridge->driver_private; > + > + mutex_lock(&mic_mutex); > + drm_display_mode_to_videomode(mode, &mic->vm); > + mutex_unlock(&mic_mutex); > +} > + > static void mic_pre_enable(struct drm_bridge *bridge) > { > struct exynos_mic *mic = bridge->driver_private; > @@ -377,6 +381,7 @@ static void mic_enable(struct drm_bridge *bridge) { } > static const struct drm_bridge_funcs mic_bridge_funcs = { > .disable = mic_disable, > .post_disable = mic_post_disable, > + .mode_set = mic_mode_set, > .pre_enable = mic_pre_enable, > .enable = mic_enable, > }; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761751AbdAKFdT (ORCPT ); Wed, 11 Jan 2017 00:33:19 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:56533 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755643AbdAKFdQ (ORCPT ); Wed, 11 Jan 2017 00:33:16 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a38-f79836d00000492b-a3-5875c399917e Content-transfer-encoding: 8BIT Message-id: <5875C398.6000906@samsung.com> Date: Wed, 11 Jan 2017 14:33:12 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hoegeun Kwon , robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.hajda@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com Subject: Re: [PATCH v7 1/4] drm/exynos: mic: Add mode_set callback function In-reply-to: <1483611609-23522-2-git-send-email-hoegeun.kwon@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0wTaRT1m+lMB2P1o6h7g1HJJGYjSJcpLcyqNb5TFzWs/rDRaB3hC1Tp I52WVaMJCqKU+kBigrULrhp1a6IEX0BE3fqo/qFGTUTIFnY3C0SjNb6iJoptR6P/zrn33NfJ 5WjtGTaTszk8xO2QKnh2tOrSjem63MM3vJa8I4+x2Hu2mxH3dt+lxEevhxix5WaCPnwTZ8X4 KR8r9nyoZcT9/z2lxWi0VS0+6AyyYlP0KiWOXGlXi+87m1VzNeaOwN9qc1uojjVffjvAmPvr I5R534UQMr9qm1LMriazy4lUStxZxFHiLLU5ykx80UrrAquxIE/IFX4WC/ksh2QnJn7h0uLc xbaKxKZ8VqVU4U2EiiVZ5n+aM9vt9HpIVrlT9pj4NYKg1wl5hTq9Xq8z5K+dqTcmJOtJeV/d /4zrLN58saZbXYWCGh9K4wAbwNd0W6XgiXAvdo71odGcFrcjuH7iDFLIbgquRmrVXyuCkXu0 kggiiBzbRSUTGpwO7xpjiVYcR+OpcPP+pmSYxtNh+PVBlaKPIRjxxxlFnw0NL6pTtSo8DW51 /ZHCbAI3nO5nk3gCtkBHy9vU4PF4P4KO07ZkIxrfQVDdcyAlysBFUH9tgE7iNLwEequeI2XT XjUcPT8/uRDgydB2nVbCC+HI+yil4Ax4Ernw5bBJEPrUSyX7A65H8MjvZxWyB8HHupEvJuVD /0CMVk4bC8/f+BllgAb21GoViRluDYZZBc+Dnqo4pVzfh+D3xk7mAJoa+M6wwDfDAt8ZdhTR ITSRuGR7GZEFl0EnS3bZ6yjTlTjtbSj1qNliO7rSvTSMMIf4MZrhuMeiZaRKeYs9jICj+fGa X8Nei1ZTKm3ZStxOq9tbQeQwMib8bqAzJ5Q4E2/v8FgFQ4Fg0BsEoVCfp+d/0BzfMcuixWWS h2wixEXcX+soLi2zCnndteOi27Yvm7IstF51P31cvt+4Mv5P7LeXGw4/tm3c8ezP82SD0eh7 d/nfVYdcP+Y4Kptdfc+E1kUZxl92SvzkoZzWFdvau+rVc7i1o5xd66zLKavJ9cE7I7tm1HBR za6NNapgZFr6ip4Ha7SDlScH/1pQkJOT3xjAzidDQ63+ahOvksslIZt2y9JnG6shxb4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t9jQd0Zh0sjDJpOmFjcWneO1aL33Ekm i+tfnrNazD8C5F75+p7N4v3yLjaLG7/aWC36H79mtjh/fgO7xeVdc9gsZpzfx2Txf88Odouf u+axOPB67Jx1l91j06pONo/t3x6wetzvPs7k0bdlFaPH501yAWxRbjYZqYkpqUUKqXnJ+SmZ eem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W0rdLcMu43fmUtWCdQMXW lnPsDYxzeLsYOTkkBEwk5hy/wAxhi0lcuLeerYuRi0NIYBajxPNlN1lBErwCghI/Jt9j6WLk 4GAWkJc4cikbwlSXmDIlF6L8AaNE26r9UOVaEhM/NDOB2CwCqhJH9y4Es9mA7Ikr7rOB9IoK REh0n6gE6RUR6GWU2L/hEFgNs8AJRom3De4gtrCAt0T3/gfMEAtuM0o0PprMApLgFPCUuNXw jnECI9CVCOfNQjhvFsJ5CxiZVzFKpBYkFxQnpeca5qWW6xUn5haX5qXrJefnbmIER+kzqR2M B3e5H2IU4GBU4uF98KIkQog1say4MvcQowQHs5IIb+Ch0ggh3pTEyqrUovz4otKc1OJDjKZA /01klhJNzgcmkLySeEMTcxNzYwMLc0tLEyMlcd7G2c/ChQTSE0tSs1NTC1KLYPqYODilGhhL bmmF1azeEnZ6aoFAmDjvsg1aB98bPjBccDhxqVyxX1Asx27frvKAtqlHZR2dd5+yLbn7IDbh QLLvJoXS2sQ11/LvvlwjZJGlomdYteHlu58hvxLjPDPl/wh0FuvOWSXN2//nxmbZd/c/vpt1 98ByFmOzW2em2Hy6azfJ6lE9O/u7VWYWkieUWIozEg21mIuKEwFskYbH6AIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111053312epcas1p40d38d5ce7f3c51e3772436cd036c7369 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1M1L1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170105102012epcas5p3666c67cfc82d2439c993f917f8e2d0ce X-RootMTR: 20170105102012epcas5p3666c67cfc82d2439c993f917f8e2d0ce References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-2-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get videomode struct through > mode_set callback function. > > Signed-off-by: Hoegeun Kwon > Reviewed-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > index a0def0b..fed1a94 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > @@ -286,13 +286,6 @@ static int parse_dt(struct exynos_mic *mic) > } > nodes[j++] = remote_node; > > - ret = of_get_videomode(remote_node, > - &mic->vm, 0); > - if (ret) { > - DRM_ERROR("mic: failed to get videomode"); > - goto exit; > - } > - > break; > default: > DRM_ERROR("mic: Unknown endpoint from MIC"); > @@ -329,6 +322,17 @@ static void mic_post_disable(struct drm_bridge *bridge) > mutex_unlock(&mic_mutex); > } > > +static void mic_mode_set(struct drm_bridge *bridge, > + struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode) > +{ > + struct exynos_mic *mic = bridge->driver_private; > + > + mutex_lock(&mic_mutex); > + drm_display_mode_to_videomode(mode, &mic->vm); > + mutex_unlock(&mic_mutex); > +} > + > static void mic_pre_enable(struct drm_bridge *bridge) > { > struct exynos_mic *mic = bridge->driver_private; > @@ -377,6 +381,7 @@ static void mic_enable(struct drm_bridge *bridge) { } > static const struct drm_bridge_funcs mic_bridge_funcs = { > .disable = mic_disable, > .post_disable = mic_post_disable, > + .mode_set = mic_mode_set, > .pre_enable = mic_pre_enable, > .enable = mic_enable, > }; >