From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board Date: Wed, 11 Jan 2017 17:40:09 +0900 Message-ID: <5875EF69.1070803@samsung.com> References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-4-git-send-email-hoegeun.kwon@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-reply-to: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrzej Hajda , Hoegeun Kwon , krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Hyungwon Hwang List-Id: linux-samsung-soc@vger.kernel.org 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: > On 11.01.2017 07:33, Hoegeun Kwon wrote: >> From: Hyungwon Hwang >> >> This patch add the panel device tree node for S6E3HA2 display >> controller to TM2 dts. >> >> Signed-off-by: Hyungwon Hwang >> Signed-off-by: Andrzej Hajda >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Hoegeun Kwon >> Tested-by: Chanwoo Choi >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index ddba2f8..6d362f9 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -18,6 +18,18 @@ >> compatible = "samsung,tm2", "samsung,exynos5433"; >> }; >> >> +&dsi { >> + panel@0 { >> + compatible = "samsung,s6e3ha2"; >> + reg = <0>; >> + vdd3-supply = <&ldo27_reg>; >> + vci-supply = <&ldo28_reg>; >> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; > The same here (as in 1st comment) , te-gpios should be dropper - decon > uses hw-trigger. Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together. Thanks. > > Regards > Andrzej >> + }; >> +}; >> + >> &hsi2c_9 { >> status = "okay"; >> > > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936568AbdAKIkR (ORCPT ); Wed, 11 Jan 2017 03:40:17 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:54588 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935922AbdAKIkN (ORCPT ); Wed, 11 Jan 2017 03:40:13 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2e-f79f46d000002a13-06-5875ef6901e7 Content-transfer-encoding: 8BIT Message-id: <5875EF69.1070803@samsung.com> Date: Wed, 11 Jan 2017 17:40:09 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andrzej Hajda , Hoegeun Kwon , krzk@kernel.org, robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com, andi.shyti@samsung.com, Hyungwon Hwang Subject: Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA01TWUwTURT1zbTTAR0Zy+INRsGJRsFQmFJgUFGJxDSBjxr9aDQGR5gASlvS aVVcEpeILLK5BXABCRXFiIqgoMYFmxD8ABVRo1hQFI0mEBQVMYDTDkbzfs69Oefde07eI3F1 ExFIZphtgtXMZzKEt+LGw5CQsK1DdmNEcS3GvarvUHKFHe0Yd9M5oORejHxUcpVOqffs+xDB DdXmE5yjrEjJvRzLUXLF/V9wrrPzqorrunWa4Mo672Lc5J1mFffr1lnFKh99S8Ublb6hLo/Q 3/zRp9T3FrRh+qLGOqT/1jDPQGwQlqcLfKpgDRbMKZbUDHNaHJO4Lnl1clR0BBvGxnIxTLCZ NwlxTEKSIWxNRqa0MxO8nc+0Sy0DL4pM+IrlVovdJgSnW0RbHLORZbUaNiJGo9VqNbrITUu1 URJls5A+8uAQllVA7aw5PonvQy7vfORFAq2DvJOXcBkHwGPXFSIfeZNq2oGgeqJMIReHMTgw WKP4qxh5VKJ0YzVdi6D56Hw3puhZMHrMJXFIEqeDwPl0m7uN0yHQdPuKSr7HhaCvvQTJ/FB4 19mjcmMFvRAK7l32bEFIuPRCL+HG/rQRWip/eMR+dCOC4dNNmLvA6Z8IigcveNS+dAp0Hy70 bOdFrwTX9bceD0APq+DbmZ+elYCeCw33p3wmwOi5X5iMfeFzW6NKxnNg3PEKydoCBC+OHJm6 KBfBeN7klP9I6O1z4bK5mVD4+z0mD6AgN0ctU/RQ/vDJ1Nx4aM4Jk+0XYfC7uxAvQUEV/yVW 8S+xiv8Sq0J4HQoQskRTmiBGZUVqRN4k2s1pmhSLqQF5nmyophlNVCW2IppEzAyK2283qpX8 djHb1IqAxBk/6vxnqUWl8tm7BKsl2WrPFMRWFCUFXooH+qdYpA9gtiWzumhWp42VTgwbw8ym qnYuM6rpNN4mbBOELMH6V4eRXoH7UEjunsfxS2Krvaqr+/u/THOVk+M16/uCjAHfocVGDc7c 69AXtcxP/RSUYBg46azkTwyXjnX1GKlT1+rJttxVb3dsXHpJZ3+wKR5pA+uHBi4u6HrDXvNd FL6FSlzss+eg/73nHyKXjTm/vi6NS/JzPF80mj1hmM5P7zGM7Y5es/asH6MQ03k2FLeK/B9Y u46+yAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t9jAd3M96URBkdm81ncWneO1aL33Ekm i+1HnrFaXP/ynNVi/hGg2JWv79ks3i/vYrNYOqOP1eLGrzZWi/7Hr5ktzp/fwG5xedccNosZ 5/cxWfzfs4Pd4ueueSwO/B47Z91l99i0qpPNY/u3B6we97uPM3n0bVnF6PF5k1wAW5SbTUZq YkpqkUJqXnJ+SmZeuq1SaIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLc Mr4cbGUq6OatWDLlP3MD4z2uLkZODgkBE4kvpyawQthiEhfurWcDsYUEljJKPOuQBrF5BQQl fky+x9LFyMHBLCAvceRSNkiYWUBdYtK8RcxdjFxA5Q8YJV7uXMUGUa8l8ej8HXYQm0VAVaJ7 /1pmEJsNyJ644j4byBxRgQiJ7hOVIL0iAlsYJTbdO8QO4jALfGeUOLbnHwtIg7BAssTRdfNZ IA7qY5JYeVQExOYUsJe4t/kh2wRGgVlI7puFcN8sJPctYGRexSiRWpBcUJyUnmuUl1quV5yY W1yal66XnJ+7iREcu8+kdzAe3uV+iFGAg1GJh/fF+5IIIdbEsuLK3EOMEhzMSiK8y16VRgjx piRWVqUW5ccXleakFh9iNAV6cCKzlGhyPjCt5JXEG5qYm5gbG1iYW1qaGCmJ8zbOfhYuJJCe WJKanZpakFoE08fEwSnVwFhYcfaG4s24HZL5rMu4q0vCfysdaOFelvSba6FVcElAf13Yh1q5 t49L09nmL7nwMd9PYOekhvvbf4uJP+pg/8iz4gLTMvFgawMdhh//N7Zzxpza8u2X/C7XOJN1 F7lkr+QbfZ+ar3D5sr1x/nybfu1Qvv9J9VvmBgvWXi7TCInS++qZUzZhrhJLcUaioRZzUXEi ABUilKDzAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111084009epcas5p1b23bbd94630d4e3f7a609963660b53a5 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1M1L1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 X-RootMTR: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-4-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: > On 11.01.2017 07:33, Hoegeun Kwon wrote: >> From: Hyungwon Hwang >> >> This patch add the panel device tree node for S6E3HA2 display >> controller to TM2 dts. >> >> Signed-off-by: Hyungwon Hwang >> Signed-off-by: Andrzej Hajda >> Signed-off-by: Chanwoo Choi >> Signed-off-by: Hoegeun Kwon >> Tested-by: Chanwoo Choi >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index ddba2f8..6d362f9 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -18,6 +18,18 @@ >> compatible = "samsung,tm2", "samsung,exynos5433"; >> }; >> >> +&dsi { >> + panel@0 { >> + compatible = "samsung,s6e3ha2"; >> + reg = <0>; >> + vdd3-supply = <&ldo27_reg>; >> + vci-supply = <&ldo28_reg>; >> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; > The same here (as in 1st comment) , te-gpios should be dropper - decon > uses hw-trigger. Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together. Thanks. > > Regards > Andrzej >> + }; >> +}; >> + >> &hsi2c_9 { >> status = "okay"; >> > > > >