From: Daniel Borkmann <daniel@iogearbox.net>
To: Sowmini Varadhan <sowmini.varadhan@oracle.com>, netdev@vger.kernel.org
Cc: willemb@google.com, davem@davemloft.net
Subject: Re: [PATCH net-next] tools: psock_lib: harden socket filter used by psock tests
Date: Thu, 12 Jan 2017 15:37:20 +0100 [thread overview]
Message-ID: <587794A0.8030807@iogearbox.net> (raw)
In-Reply-To: <2dbc0b384193b76bcb7f1845e1f81768610cc2b5.1484060892.git.sowmini.varadhan@oracle.com>
On 01/12/2017 02:10 PM, Sowmini Varadhan wrote:
> The filter added by sock_setfilter is intended to only permit
> packets matching the pattern set up by create_payload(), but
> we only check the ip_len, and a single test-character in
> the IP packet to ensure this condition.
>
> Harden the filter by adding additional constraints so that we only
> permit UDP/IPv4 packets that meet the ip_len and test-character
> requirements. Include the bpf_asm src as a comment, in case this
> needs to be enhanced in the future
>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
LGTM, thanks!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-01-12 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1484060892.git.sowmini.varadhan@oracle.com>
2017-01-10 15:47 ` [PATCH net-next] packet: pdiag_put_ring() should return TX_RING info for TPACKET_V3 Sowmini Varadhan
2017-01-11 2:03 ` David Miller
2017-01-12 13:10 ` [PATCH net-next] tools: psock_lib: harden socket filter used by psock tests Sowmini Varadhan
2017-01-12 14:37 ` Daniel Borkmann [this message]
2017-01-12 15:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587794A0.8030807@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sowmini.varadhan@oracle.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.