diff for duplicates of <587C57FD.7050601@ti.com> diff --git a/a/1.txt b/N1/1.txt index 936600a..a5ed90c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,8 +2,9 @@ Hi, On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: > Hi, -> -> Às 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: +> = + +> =C0s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> *num-lanes* dt property is parsed in dw_pcie_host_init. However >> *num-lanes* property is applicable to both root complex mode and >> endpoint mode. As a first step, move the parsing of this property @@ -16,51 +17,69 @@ On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: >> drivers/pci/dwc/pcie-designware.h | 1 - >> 2 files changed, 11 insertions(+), 8 deletions(-) >> ->> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c +>> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-de= +signware.c >> index 00a0fdc..89cdb6b 100644 >> --- a/drivers/pci/dwc/pcie-designware.c >> +++ b/drivers/pci/dwc/pcie-designware.c >> @@ -551,10 +551,6 @@ int dw_pcie_host_init(struct pcie_port *pp) >> } >> } ->> ->> - ret = of_property_read_u32(np, "num-lanes", &pci->lanes); +>> = + +>> - ret =3D of_property_read_u32(np, "num-lanes", &pci->lanes); >> - if (ret) ->> - pci->lanes = 0; +>> - pci->lanes =3D 0; >> - ->> ret = of_property_read_u32(np, "num-viewport", &pci->num_viewport); +>> ret =3D of_property_read_u32(np, "num-viewport", &pci->num_viewport); >> if (ret) ->> pci->num_viewport = 2; ->> @@ -751,18 +747,26 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn, ->> +>> pci->num_viewport =3D 2; +>> @@ -751,18 +747,26 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u3= +2 devfn, +>> = + >> void dw_pcie_setup_rc(struct pcie_port *pp) >> { >> + int ret; >> + u32 lanes; >> u32 val; ->> struct dw_pcie *pci = to_dw_pcie_from_pp(pp); ->> + struct device *dev = pci->dev; ->> + struct device_node *np = dev->of_node; ->> +>> struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); +>> + struct device *dev =3D pci->dev; +>> + struct device_node *np =3D dev->of_node; +>> = + >> /* get iATU unroll support */ ->> pci->iatu_unroll_enabled = dw_pcie_iatu_unroll_enabled(pci); +>> pci->iatu_unroll_enabled =3D dw_pcie_iatu_unroll_enabled(pci); >> dev_dbg(pci->dev, "iATU unroll: %s\n", >> pci->iatu_unroll_enabled ? "enabled" : "disabled"); ->> ->> + ret = of_property_read_u32(np, "num-lanes", &lanes); +>> = + +>> + ret =3D of_property_read_u32(np, "num-lanes", &lanes); >> + if (ret) ->> + lanes = 0; -> -> You moved from host_init to root complex setup function, which in my opinion did +>> + lanes =3D 0; +> = + +> You moved from host_init to root complex setup function, which in my opin= +ion did > not improve (in this scope). -> -> I suggest that instead of making so much intermediary patches, which is nice to -> understand your development sequence, but hard to review. Wouldn't be better to -> condense some of the patches? We would have a cloear vision of the final product :) +> = -I thought the other way. If squashing patches is easier to review, I'll do it. +> I suggest that instead of making so much intermediary patches, which is n= +ice to +> understand your development sequence, but hard to review. Wouldn't be bet= +ter to +> condense some of the patches? We would have a cloear vision of the final = +product :) + +I thought the other way. If squashing patches is easier to review, I'll do = +it. Btw, thanks for reviewing. Cheers Kishon + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index c1379ab..1525aaf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -25,8 +25,9 @@ "\n" "On Friday 13 January 2017 10:43 PM, Joao Pinto wrote:\n" "> Hi,\n" - "> \n" - "> \303\200s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu:\n" + "> =\n" + "\n" + "> =C0s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu:\n" ">> *num-lanes* dt property is parsed in dw_pcie_host_init. However\n" ">> *num-lanes* property is applicable to both root complex mode and\n" ">> endpoint mode. As a first step, move the parsing of this property\n" @@ -39,53 +40,71 @@ ">> drivers/pci/dwc/pcie-designware.h | 1 -\n" ">> 2 files changed, 11 insertions(+), 8 deletions(-)\n" ">>\n" - ">> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c\n" + ">> diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-de=\n" + "signware.c\n" ">> index 00a0fdc..89cdb6b 100644\n" ">> --- a/drivers/pci/dwc/pcie-designware.c\n" ">> +++ b/drivers/pci/dwc/pcie-designware.c\n" ">> @@ -551,10 +551,6 @@ int dw_pcie_host_init(struct pcie_port *pp)\n" ">> \t\t}\n" ">> \t}\n" - ">> \n" - ">> -\tret = of_property_read_u32(np, \"num-lanes\", &pci->lanes);\n" + ">> =\n" + "\n" + ">> -\tret =3D of_property_read_u32(np, \"num-lanes\", &pci->lanes);\n" ">> -\tif (ret)\n" - ">> -\t\tpci->lanes = 0;\n" + ">> -\t\tpci->lanes =3D 0;\n" ">> -\n" - ">> \tret = of_property_read_u32(np, \"num-viewport\", &pci->num_viewport);\n" + ">> \tret =3D of_property_read_u32(np, \"num-viewport\", &pci->num_viewport);\n" ">> \tif (ret)\n" - ">> \t\tpci->num_viewport = 2;\n" - ">> @@ -751,18 +747,26 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn,\n" - ">> \n" + ">> \t\tpci->num_viewport =3D 2;\n" + ">> @@ -751,18 +747,26 @@ static int dw_pcie_wr_conf(struct pci_bus *bus, u3=\n" + "2 devfn,\n" + ">> =\n" + "\n" ">> void dw_pcie_setup_rc(struct pcie_port *pp)\n" ">> {\n" ">> +\tint ret;\n" ">> +\tu32 lanes;\n" ">> \tu32 val;\n" - ">> \tstruct dw_pcie *pci = to_dw_pcie_from_pp(pp);\n" - ">> +\tstruct device *dev = pci->dev;\n" - ">> +\tstruct device_node *np = dev->of_node;\n" - ">> \n" + ">> \tstruct dw_pcie *pci =3D to_dw_pcie_from_pp(pp);\n" + ">> +\tstruct device *dev =3D pci->dev;\n" + ">> +\tstruct device_node *np =3D dev->of_node;\n" + ">> =\n" + "\n" ">> \t/* get iATU unroll support */\n" - ">> \tpci->iatu_unroll_enabled = dw_pcie_iatu_unroll_enabled(pci);\n" + ">> \tpci->iatu_unroll_enabled =3D dw_pcie_iatu_unroll_enabled(pci);\n" ">> \tdev_dbg(pci->dev, \"iATU unroll: %s\\n\",\n" ">> \t\tpci->iatu_unroll_enabled ? \"enabled\" : \"disabled\");\n" - ">> \n" - ">> +\tret = of_property_read_u32(np, \"num-lanes\", &lanes);\n" + ">> =\n" + "\n" + ">> +\tret =3D of_property_read_u32(np, \"num-lanes\", &lanes);\n" ">> +\tif (ret)\n" - ">> +\t\tlanes = 0;\n" - "> \n" - "> You moved from host_init to root complex setup function, which in my opinion did\n" + ">> +\t\tlanes =3D 0;\n" + "> =\n" + "\n" + "> You moved from host_init to root complex setup function, which in my opin=\n" + "ion did\n" "> not improve (in this scope).\n" - "> \n" - "> I suggest that instead of making so much intermediary patches, which is nice to\n" - "> understand your development sequence, but hard to review. Wouldn't be better to\n" - "> condense some of the patches? We would have a cloear vision of the final product :)\n" + "> =\n" "\n" - "I thought the other way. If squashing patches is easier to review, I'll do it.\n" + "> I suggest that instead of making so much intermediary patches, which is n=\n" + "ice to\n" + "> understand your development sequence, but hard to review. Wouldn't be bet=\n" + "ter to\n" + "> condense some of the patches? We would have a cloear vision of the final =\n" + "product :)\n" + "\n" + "I thought the other way. If squashing patches is easier to review, I'll do =\n" + "it.\n" "\n" "Btw, thanks for reviewing.\n" "\n" "Cheers\n" - Kishon + "Kishon\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -333042e21d5f4c1366136df8f5291689faef7d1cba66cb74c96e37985342deac +add33ce5710e41fd24014c84d018507a6224d0f8da6c4beccb7f63bc48320a60
diff --git a/a/content_digest b/N2/content_digest index c1379ab..36c4e6c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -8,17 +8,17 @@ Bjorn Helgaas <bhelgaas@google.com> Jingoo Han <jingoohan1@gmail.com> " Arnd Bergmann <arnd@arndb.de>\0" - "Cc\0devicetree@vger.kernel.org" - linux-samsung-soc@vger.kernel.org - linux-doc@vger.kernel.org - linux-pci@vger.kernel.org - nsekhar@ti.com - linux-kernel@vger.kernel.org - linux-arm-kernel@axis.com - linux-arm-msm@vger.kernel.org - linux-omap@vger.kernel.org - linuxppc-dev@lists.ozlabs.org - " linux-arm-kernel@lists.infradead.org\0" + "Cc\0<linux-pci@vger.kernel.org>" + <linux-doc@vger.kernel.org> + <linux-kernel@vger.kernel.org> + <devicetree@vger.kernel.org> + <linux-omap@vger.kernel.org> + <linux-arm-kernel@lists.infradead.org> + <linux-samsung-soc@vger.kernel.org> + <linuxppc-dev@lists.ozlabs.org> + <linux-arm-kernel@axis.com> + <linux-arm-msm@vger.kernel.org> + " <nsekhar@ti.com>\0" "\00:1\0" "b\0" "Hi,\n" @@ -88,4 +88,4 @@ "Cheers\n" Kishon -333042e21d5f4c1366136df8f5291689faef7d1cba66cb74c96e37985342deac +bbb179a7d1761fff864d3f87fab2613f10d8a31aceb4a02eda4fcb71c82ac776
diff --git a/a/1.txt b/N3/1.txt index 936600a..5c9410d 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -3,7 +3,7 @@ Hi, On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: > Hi, > -> Às 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: +> ?s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> *num-lanes* dt property is parsed in dw_pcie_host_init. However >> *num-lanes* property is applicable to both root complex mode and >> endpoint mode. As a first step, move the parsing of this property diff --git a/a/content_digest b/N3/content_digest index c1379ab..ae4c49f 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,24 +1,10 @@ "ref\01484216786-17292-1-git-send-email-kishon@ti.com\0" "ref\01484216786-17292-10-git-send-email-kishon@ti.com\0" "ref\0c3c55af3-29d1-dc59-3ae4-9a4132c99092@synopsys.com\0" - "From\0Kishon Vijay Abraham I <kishon@ti.com>\0" - "Subject\0Re: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc\0" + "From\0kishon@ti.com (Kishon Vijay Abraham I)\0" + "Subject\0[PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc\0" "Date\0Mon, 16 Jan 2017 10:49:57 +0530\0" - "To\0Joao Pinto <Joao.Pinto@synopsys.com>" - Bjorn Helgaas <bhelgaas@google.com> - Jingoo Han <jingoohan1@gmail.com> - " Arnd Bergmann <arnd@arndb.de>\0" - "Cc\0devicetree@vger.kernel.org" - linux-samsung-soc@vger.kernel.org - linux-doc@vger.kernel.org - linux-pci@vger.kernel.org - nsekhar@ti.com - linux-kernel@vger.kernel.org - linux-arm-kernel@axis.com - linux-arm-msm@vger.kernel.org - linux-omap@vger.kernel.org - linuxppc-dev@lists.ozlabs.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi,\n" @@ -26,7 +12,7 @@ "On Friday 13 January 2017 10:43 PM, Joao Pinto wrote:\n" "> Hi,\n" "> \n" - "> \303\200s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu:\n" + "> ?s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu:\n" ">> *num-lanes* dt property is parsed in dw_pcie_host_init. However\n" ">> *num-lanes* property is applicable to both root complex mode and\n" ">> endpoint mode. As a first step, move the parsing of this property\n" @@ -88,4 +74,4 @@ "Cheers\n" Kishon -333042e21d5f4c1366136df8f5291689faef7d1cba66cb74c96e37985342deac +61c10b15c871f39283c35da137703f1ad80ba9af8f3960b892c94b23b5ad9194
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.