From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 11/37] PCI: dwc: Split pcie-designware.c into host and core files Date: Mon, 16 Jan 2017 10:51:48 +0530 Message-ID: <587C586C.6070003@ti.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-12-git-send-email-kishon@ti.com> <4a89fb45-af84-d660-5ef0-12227b141cda@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Return-path: Received: from fllnx210.ext.ti.com ([198.47.19.17]:40760 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdAPFWc (ORCPT ); Mon, 16 Jan 2017 00:22:32 -0500 In-Reply-To: <4a89fb45-af84-d660-5ef0-12227b141cda@synopsys.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Joao Pinto , Bjorn Helgaas , Jingoo Han , Arnd Bergmann Cc: linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, nsekhar@ti.com Hi Joao, On Friday 13 January 2017 10:19 PM, Joao Pinto wrote: > Ās 10:26 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> Split pcie-designware.c into pcie-designware-host.c that contains >> the host specific parts of the driver and pcie-designware.c that >> contains the parts used by both host driver and endpoint driver. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/Makefile | 2 +- >> drivers/pci/dwc/pcie-designware-host.c | 619 ++++++++++++++++++++++++++++++++ >> drivers/pci/dwc/pcie-designware.c | 613 +------------------------------ >> drivers/pci/dwc/pcie-designware.h | 8 + >> 4 files changed, 634 insertions(+), 608 deletions(-) >> create mode 100644 drivers/pci/dwc/pcie-designware-host.c >> >> diff --git a/drivers/pci/dwc/Makefile b/drivers/pci/dwc/Makefile >> index 7d27c14..3b57e55 100644 >> --- a/drivers/pci/dwc/Makefile >> +++ b/drivers/pci/dwc/Makefile >> @@ -1,4 +1,4 @@ > > (snip...) > >> -static void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, >> - int type, u64 cpu_addr, u64 pci_addr, >> - u32 size) >> +void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, int type, >> + u64 cpu_addr, u64 pci_addr, u32 size) >> { >> u32 retries, val; >> >> @@ -186,220 +151,6 @@ static void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, >> dev_err(pci->dev, "iATU is not being enabled\n"); >> } > > Kishon, iATU only makes sense in The Root Complex (host), so it should be inside > the pcie-designware-host. That is not true. Outbound ATU should be programmed to access host side buffers and inbound ATU should be programmed for the host to access EP mem space. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 11/37] PCI: dwc: Split pcie-designware.c into host and core files To: Joao Pinto , Bjorn Helgaas , Jingoo Han , Arnd Bergmann References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-12-git-send-email-kishon@ti.com> <4a89fb45-af84-d660-5ef0-12227b141cda@synopsys.com> From: Kishon Vijay Abraham I Message-ID: <587C586C.6070003@ti.com> Date: Mon, 16 Jan 2017 10:51:48 +0530 MIME-Version: 1.0 In-Reply-To: <4a89fb45-af84-d660-5ef0-12227b141cda@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="windows-1252" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Joao, On Friday 13 January 2017 10:19 PM, Joao Pinto wrote: > =C0s 10:26 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> Split pcie-designware.c into pcie-designware-host.c that contains >> the host specific parts of the driver and pcie-designware.c that >> contains the parts used by both host driver and endpoint driver. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/Makefile | 2 +- >> drivers/pci/dwc/pcie-designware-host.c | 619 +++++++++++++++++++++++++= +++++++ >> drivers/pci/dwc/pcie-designware.c | 613 +------------------------= ------ >> drivers/pci/dwc/pcie-designware.h | 8 + >> 4 files changed, 634 insertions(+), 608 deletions(-) >> create mode 100644 drivers/pci/dwc/pcie-designware-host.c >> >> diff --git a/drivers/pci/dwc/Makefile b/drivers/pci/dwc/Makefile >> index 7d27c14..3b57e55 100644 >> --- a/drivers/pci/dwc/Makefile >> +++ b/drivers/pci/dwc/Makefile >> @@ -1,4 +1,4 @@ > = > (snip...) > = >> -static void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, >> - int type, u64 cpu_addr, u64 pci_addr, >> - u32 size) >> +void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, int type, >> + u64 cpu_addr, u64 pci_addr, u32 size) >> { >> u32 retries, val; >> = >> @@ -186,220 +151,6 @@ static void dw_pcie_prog_outbound_atu(struct dw_pc= ie *pci, int index, >> dev_err(pci->dev, "iATU is not being enabled\n"); >> } > = > Kishon, iATU only makes sense in The Root Complex (host), so it should be= inside > the pcie-designware-host. That is not true. Outbound ATU should be programmed to access host side buf= fers and inbound ATU should be programmed for the host to access EP mem space. Thanks Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3v21nw2sD6zDqRc for ; Mon, 16 Jan 2017 16:22:28 +1100 (AEDT) Subject: Re: [PATCH 11/37] PCI: dwc: Split pcie-designware.c into host and core files To: Joao Pinto , Bjorn Helgaas , Jingoo Han , Arnd Bergmann References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-12-git-send-email-kishon@ti.com> <4a89fb45-af84-d660-5ef0-12227b141cda@synopsys.com> CC: , , , , , , , , , , From: Kishon Vijay Abraham I Message-ID: <587C586C.6070003@ti.com> Date: Mon, 16 Jan 2017 10:51:48 +0530 MIME-Version: 1.0 In-Reply-To: <4a89fb45-af84-d660-5ef0-12227b141cda@synopsys.com> Content-Type: text/plain; charset="windows-1252" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Joao, On Friday 13 January 2017 10:19 PM, Joao Pinto wrote: > Ās 10:26 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> Split pcie-designware.c into pcie-designware-host.c that contains >> the host specific parts of the driver and pcie-designware.c that >> contains the parts used by both host driver and endpoint driver. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/Makefile | 2 +- >> drivers/pci/dwc/pcie-designware-host.c | 619 ++++++++++++++++++++++++++++++++ >> drivers/pci/dwc/pcie-designware.c | 613 +------------------------------ >> drivers/pci/dwc/pcie-designware.h | 8 + >> 4 files changed, 634 insertions(+), 608 deletions(-) >> create mode 100644 drivers/pci/dwc/pcie-designware-host.c >> >> diff --git a/drivers/pci/dwc/Makefile b/drivers/pci/dwc/Makefile >> index 7d27c14..3b57e55 100644 >> --- a/drivers/pci/dwc/Makefile >> +++ b/drivers/pci/dwc/Makefile >> @@ -1,4 +1,4 @@ > > (snip...) > >> -static void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, >> - int type, u64 cpu_addr, u64 pci_addr, >> - u32 size) >> +void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, int type, >> + u64 cpu_addr, u64 pci_addr, u32 size) >> { >> u32 retries, val; >> >> @@ -186,220 +151,6 @@ static void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, >> dev_err(pci->dev, "iATU is not being enabled\n"); >> } > > Kishon, iATU only makes sense in The Root Complex (host), so it should be inside > the pcie-designware-host. That is not true. Outbound ATU should be programmed to access host side buffers and inbound ATU should be programmed for the host to access EP mem space. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Mon, 16 Jan 2017 10:51:48 +0530 Subject: [PATCH 11/37] PCI: dwc: Split pcie-designware.c into host and core files In-Reply-To: <4a89fb45-af84-d660-5ef0-12227b141cda@synopsys.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-12-git-send-email-kishon@ti.com> <4a89fb45-af84-d660-5ef0-12227b141cda@synopsys.com> Message-ID: <587C586C.6070003@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Joao, On Friday 13 January 2017 10:19 PM, Joao Pinto wrote: > ?s 10:26 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >> Split pcie-designware.c into pcie-designware-host.c that contains >> the host specific parts of the driver and pcie-designware.c that >> contains the parts used by both host driver and endpoint driver. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/Makefile | 2 +- >> drivers/pci/dwc/pcie-designware-host.c | 619 ++++++++++++++++++++++++++++++++ >> drivers/pci/dwc/pcie-designware.c | 613 +------------------------------ >> drivers/pci/dwc/pcie-designware.h | 8 + >> 4 files changed, 634 insertions(+), 608 deletions(-) >> create mode 100644 drivers/pci/dwc/pcie-designware-host.c >> >> diff --git a/drivers/pci/dwc/Makefile b/drivers/pci/dwc/Makefile >> index 7d27c14..3b57e55 100644 >> --- a/drivers/pci/dwc/Makefile >> +++ b/drivers/pci/dwc/Makefile >> @@ -1,4 +1,4 @@ > > (snip...) > >> -static void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, >> - int type, u64 cpu_addr, u64 pci_addr, >> - u32 size) >> +void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, int type, >> + u64 cpu_addr, u64 pci_addr, u32 size) >> { >> u32 retries, val; >> >> @@ -186,220 +151,6 @@ static void dw_pcie_prog_outbound_atu(struct dw_pcie *pci, int index, >> dev_err(pci->dev, "iATU is not being enabled\n"); >> } > > Kishon, iATU only makes sense in The Root Complex (host), so it should be inside > the pcie-designware-host. That is not true. Outbound ATU should be programmed to access host side buffers and inbound ATU should be programmed for the host to access EP mem space. Thanks Kishon