From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v2 11/11] drm/rockchip/dsi: fix insufficient bandwidth of some panel Date: Tue, 17 Jan 2017 17:31:53 +0800 Message-ID: <587DE489.2010004@rock-chips.com> References: <1484561311-494-1-git-send-email-zyw@rock-chips.com> <1484561311-494-12-git-send-email-zyw@rock-chips.com> <20170116124453.2154def9.john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170116124453.2154def9.john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, linux-rockchip@lists.infradead.org, yzq@rock-chips.com, linux-kernel@vger.kernel.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, robh+dt@kernel.org, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgSm9obgoKT24gMDEvMTYvMjAxNyAwODo0NCBQTSwgSm9obiBLZWVwaW5nIHdyb3RlOgo+IE9u IE1vbiwgMTYgSmFuIDIwMTcgMTg6MDg6MzEgKzA4MDAsIENocmlzIFpob25nIHdyb3RlOgo+Cj4+ IFNldCB0aGUgbGFuZXMgYnBzIHRvIDEgLyAwLjkgdGltZXMgb2YgcGNsaywgdGhlIG1hcmdpbiBp cyBub3QgZW5vdWdoCj4+IGZvciBzb21lIHBhbmVsLCBpdCB3aWxsIGNhdXNlIHRoZSBzY3JlZW4g ZGlzcGxheSBpcyBub3Qgbm9ybWFsLCBzbwo+PiBpbmNyZWFzZXMgdGhlIGJhZG53aWR0aCB0byAx IC8gMC44Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBaaG9uZyA8enl3QHJvY2stY2hpcHMu Y29tPgo+Pgo+PiAtLS0KPj4KPj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1k c2kuYyB8IDQgKystLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHct bWlwaS1kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4+IGlu ZGV4IDlkZmE3M2QuLjVhOTczZmUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2Nr Y2hpcC9kdy1taXBpLWRzaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1t aXBpLWRzaS5jCj4+IEBAIC01MDEsOCArNTAxLDggQEAgc3RhdGljIGludCBkd19taXBpX2RzaV9n ZXRfbGFuZV9icHMoc3RydWN0IGR3X21pcGlfZHNpICpkc2kpCj4+ICAgCj4+ICAgCW1wY2xrID0g RElWX1JPVU5EX1VQKGRzaS0+bW9kZS0+Y2xvY2ssIE1TRUNfUEVSX1NFQyk7Cj4+ICAgCWlmICht cGNsaykgewo+PiAtCQkvKiB0YWtlIDEgLyAwLjksIHNpbmNlIG1icHMgbXVzdCBiaWcgdGhhbiBi YW5kd2lkdGggb2YgUkdCICovCj4+IC0JCXRtcCA9IG1wY2xrICogKGJwcCAvIGRzaS0+bGFuZXMp ICogMTAgLyA5Owo+PiArCQkvKiB0YWtlIDEgLyAwLjgsIHNpbmNlIG1icHMgbXVzdCBiaWcgdGhh biBiYW5kd2lkdGggb2YgUkdCICovCj4+ICsJCXRtcCA9IG1wY2xrICogKGJwcCAvIGRzaS0+bGFu ZXMpICogMTAgLyA4Owo+IFRoaXMgYW5kIHBhdGNoIDkgYXJlIGp1c3QgaGFja2luZyBhcm91bmQg dGhlIHVuZGVybHlpbmcgcHJvYmxlbSBpbiBvcmRlcgo+IHRvIG1ha2UgcGFydGljdWxhciBwYW5l bHMgd29yay4gIEknbSBwcmV0dHkgc3VyZSB0aGUgYWN0dWFsIGlzc3VlIGlzIHRoZQo+IHVzZSBv ZiBoYXJkY29kZWQgdmFsdWVzIHdoZW4gY29uZmlndXJpbmcgdGhlIFBIWSwgc2luY2UgdGhlIFBI WQo+IHBhcmFtZXRlcnMgYXJlIHNwZWNpZmllZCBpbiBjbG9jayBjeWNsZXMgYnV0IHRoZSBNSVBJ IHNwZWMgcmVxdWlyZXMKPiBhYnNvbHV0ZSB0aW1lIGR1cmF0aW9ucy4KPgo+IEkgcG9zdGVkIGEg c2VyaWVzIGFkZHJlc3NpbmcgdGhpcyBhIHdoaWxlIGFnbywgYWx0aG91Z2ggSSBzY3Jld2VkIHVw Cj4gc2VuZGluZyBpdCBzbyBzb21lIHBhdGNoZXMgd2VyZSBpbmNsdWRlZCB0d2ljZSBhbmQgc2lu Y2Ugbm8gb25lCj4gZXhwcmVzc2VkIGFueSBpbnRlcmVzdCBJIGRpZG4ndCBwb3N0IGEgY2xlYW5l ZCB1cCB2ZXJzaW9uLgo+Cj4gVGhlIHJlbGV2YW50IHBhdGNoIGlzIGhlcmU6Cj4KPiBodHRwczov L3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzkzNDAxOTMvClRoYW5rcyB2ZXJ5IG11Y2gsIHlv dXIgcGF0Y2hlcyBhcmUgdmVyeSB1c2VmdWwgZm9yIG1lLiBJdCBsb29rcyB5b3VyIAptZXRob2Qg aXMgY29ycmVjdC4KQW5kIEkgYW0gdmVyeSBjb25mdXNlZCB3aHkgTWFyayBZYW8gYW5kIG1lIGRp ZCBub3QgcmVjZWl2ZSB5b3VyIHBhdGNoZXMgCmJlZm9yZSwKYWx0aG91Z2ggd2UgaGF2ZSBzdWJz Y3JpYmVkIHRoZSA8bGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZz4uCgpJbiBhZGRp dGlvbiwgY291bGQgeW91IHRlbGwgbWUgd2hpY2ggZGV2aWNlIHdhcmUgeW91IHRlc3Rpbmcgd2l0 aCB0aGVzZSAKbWlwaSBwYXRjaGVzLgpJIGdvaW5nIHRvIHRlc3QgdGhlbSB0aGVzZSBkYXkuCgpD aHJpcyBaaG9uZwo+PiAgIAkJaWYgKHRtcCA8IG1heF9tYnBzKQo+PiAgIAkJCXRhcmdldF9tYnBz ID0gdG1wOwo+PiAgIAkJZWxzZQo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: zyw@rock-chips.com (Chris Zhong) Date: Tue, 17 Jan 2017 17:31:53 +0800 Subject: [PATCH v2 11/11] drm/rockchip/dsi: fix insufficient bandwidth of some panel In-Reply-To: <20170116124453.2154def9.john@metanate.com> References: <1484561311-494-1-git-send-email-zyw@rock-chips.com> <1484561311-494-12-git-send-email-zyw@rock-chips.com> <20170116124453.2154def9.john@metanate.com> Message-ID: <587DE489.2010004@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi John On 01/16/2017 08:44 PM, John Keeping wrote: > On Mon, 16 Jan 2017 18:08:31 +0800, Chris Zhong wrote: > >> Set the lanes bps to 1 / 0.9 times of pclk, the margin is not enough >> for some panel, it will cause the screen display is not normal, so >> increases the badnwidth to 1 / 0.8. >> >> Signed-off-by: Chris Zhong >> >> --- >> >> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> index 9dfa73d..5a973fe 100644 >> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> @@ -501,8 +501,8 @@ static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi) >> >> mpclk = DIV_ROUND_UP(dsi->mode->clock, MSEC_PER_SEC); >> if (mpclk) { >> - /* take 1 / 0.9, since mbps must big than bandwidth of RGB */ >> - tmp = mpclk * (bpp / dsi->lanes) * 10 / 9; >> + /* take 1 / 0.8, since mbps must big than bandwidth of RGB */ >> + tmp = mpclk * (bpp / dsi->lanes) * 10 / 8; > This and patch 9 are just hacking around the underlying problem in order > to make particular panels work. I'm pretty sure the actual issue is the > use of hardcoded values when configuring the PHY, since the PHY > parameters are specified in clock cycles but the MIPI spec requires > absolute time durations. > > I posted a series addressing this a while ago, although I screwed up > sending it so some patches were included twice and since no one > expressed any interest I didn't post a cleaned up version. > > The relevant patch is here: > > https://patchwork.kernel.org/patch/9340193/ Thanks very much, your patches are very useful for me. It looks your method is correct. And I am very confused why Mark Yao and me did not receive your patches before, although we have subscribed the . In addition, could you tell me which device ware you testing with these mipi patches. I going to test them these day. Chris Zhong >> if (tmp < max_mbps) >> target_mbps = tmp; >> else > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751140AbdAQJcq (ORCPT ); Tue, 17 Jan 2017 04:32:46 -0500 Received: from regular1.263xmail.com ([211.150.99.135]:42081 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbdAQJch (ORCPT ); Tue, 17 Jan 2017 04:32:37 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: mark.yao@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <3296369cd164375390bb3df7fbfbbf5a> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 11/11] drm/rockchip/dsi: fix insufficient bandwidth of some panel To: John Keeping References: <1484561311-494-1-git-send-email-zyw@rock-chips.com> <1484561311-494-12-git-send-email-zyw@rock-chips.com> <20170116124453.2154def9.john@metanate.com> Cc: dianders@chromium.org, tfiga@chromium.org, heiko@sntech.de, yzq@rock-chips.com, mark.rutland@arm.com, devicetree@vger.kernel.org, robh+dt@kernel.org, galak@codeaurora.org, pawel.moll@arm.com, seanpaul@chromium.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Mark Yao From: Chris Zhong Message-ID: <587DE489.2010004@rock-chips.com> Date: Tue, 17 Jan 2017 17:31:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20170116124453.2154def9.john@metanate.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John On 01/16/2017 08:44 PM, John Keeping wrote: > On Mon, 16 Jan 2017 18:08:31 +0800, Chris Zhong wrote: > >> Set the lanes bps to 1 / 0.9 times of pclk, the margin is not enough >> for some panel, it will cause the screen display is not normal, so >> increases the badnwidth to 1 / 0.8. >> >> Signed-off-by: Chris Zhong >> >> --- >> >> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> index 9dfa73d..5a973fe 100644 >> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> @@ -501,8 +501,8 @@ static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi) >> >> mpclk = DIV_ROUND_UP(dsi->mode->clock, MSEC_PER_SEC); >> if (mpclk) { >> - /* take 1 / 0.9, since mbps must big than bandwidth of RGB */ >> - tmp = mpclk * (bpp / dsi->lanes) * 10 / 9; >> + /* take 1 / 0.8, since mbps must big than bandwidth of RGB */ >> + tmp = mpclk * (bpp / dsi->lanes) * 10 / 8; > This and patch 9 are just hacking around the underlying problem in order > to make particular panels work. I'm pretty sure the actual issue is the > use of hardcoded values when configuring the PHY, since the PHY > parameters are specified in clock cycles but the MIPI spec requires > absolute time durations. > > I posted a series addressing this a while ago, although I screwed up > sending it so some patches were included twice and since no one > expressed any interest I didn't post a cleaned up version. > > The relevant patch is here: > > https://patchwork.kernel.org/patch/9340193/ Thanks very much, your patches are very useful for me. It looks your method is correct. And I am very confused why Mark Yao and me did not receive your patches before, although we have subscribed the . In addition, could you tell me which device ware you testing with these mipi patches. I going to test them these day. Chris Zhong >> if (tmp < max_mbps) >> target_mbps = tmp; >> else > >