From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: vop: make vop register setting take effect Date: Tue, 17 Jan 2017 18:06:59 +0800 Message-ID: <587DECC3.50304@rock-chips.com> References: <1472269178-16593-1-git-send-email-zyw@rock-chips.com> <57C3A341.9030302@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Tomasz Figa Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , "open list:ARM/Rockchip SoC..." , =?UTF-8?B?5aea5pm65oOF?= , briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Douglas Anderson , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , David Airlie , Sean Paul , Chris Zhong , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-rockchip.vger.kernel.org SGkgVG9tYXN6CgpJIGhhZCBzZW50IHRvIERhdmUsIGJ1dCBtYXliZSBzb21ldGhpbmcgaXMgd3Jv bmcsIGl0IG1pc3MuCgp0aGUgcGF0Y2ggaXMgb24gdGhpcyBwdWxsLXJlcXVlc3Q6Cmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE2LVNlcHRlbWJlci8x MTg1MDUuaHRtbAoKSSBmb3Jnb3QgdG8gZG91YmxlIGNoZWNrIGl0LCBJIHdpbGwgcmVzZW5kIHRv IERhdmUgc29vbi4KClRoYW5rcy4KCk9uIDIwMTflubQwMeaciDE35pelIDE3OjMyLCBUb21hc3og RmlnYSB3cm90ZToKPiBIaSBNYXJrLAo+Cj4gT24gTW9uLCBBdWcgMjksIDIwMTYgYXQgMTE6NTEg QU0sIE1hcmsgeWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4gd3JvdGU6Cj4+IE9uIDIwMTbl ubQwOOaciDI35pelIDExOjM5LCBDaHJpcyBaaG9uZyB3cm90ZToKPj4+IFRoZSBzZXR0aW5nIG9m IHZvcCByZWdpc3RlcnMgbmVlZCBhIHJlZ19kb25lIHdyaXRpbmcgdG8gdGFrZSBlZmZlY3QuCj4+ PiBJbiB2b3BfZW5hYmxlIHRoZSB2b3AgcmV0dXJuIHRvIHdvcmsgYnkgYnkgcmVzdG9yaW5nIHJl Z2lzdGVycywgYnV0IHRoZQo+Pj4gcmVnaXN0ZXJzIGRvIG5vdCB0YWtlIGVmZmVjdCBpbW1lZGlh dGVseSwgaXQgc2hvdWxkIGEgdm9wX2NmZ19kb25lCj4+PiBhZnRlciBpdC4gVGhlIHNhbWUgdGhp bmcgaXMgbmVlZGVkIGJ5IHdpbmRvd3NfZGlzYWJsZWQgaW4KPj4+IHZvcF9jcnRjX2Rpc2FibGUu Cj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgWmhvbmcgPHp5d0Byb2NrLWNoaXBzLmNvbT4K Pj4+IC0tLQo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3Au YyB8IDQgKysrKwo+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+PiBUaGFu a3MgZm9yIHlvdXIgZml4Lgo+Pgo+PiBhcHBsaWVkIHRvIG15IGRybS1maXhlcy4KPiBUaGlzIHBh dGNoIHNlZW1zIHRvIGhhdmUgYmVlbiBsb3N0IGluIGFjdGlvbi4gSSBkb24ndCBzZWUgaXQgaW4g bGludXgtbmV4dC4KPgo+IEJlc3QgcmVnYXJkcywKPiBUb21hc3oKPgo+Cj4KCgotLSAK77ytYXJr IFlhbwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpM aW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJv Y2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Tue, 17 Jan 2017 18:06:59 +0800 Subject: [PATCH] drm/rockchip: vop: make vop register setting take effect In-Reply-To: References: <1472269178-16593-1-git-send-email-zyw@rock-chips.com> <57C3A341.9030302@rock-chips.com> Message-ID: <587DECC3.50304@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tomasz I had sent to Dave, but maybe something is wrong, it miss. the patch is on this pull-request: https://lists.freedesktop.org/archives/dri-devel/2016-September/118505.html I forgot to double check it, I will resend to Dave soon. Thanks. On 2017?01?17? 17:32, Tomasz Figa wrote: > Hi Mark, > > On Mon, Aug 29, 2016 at 11:51 AM, Mark yao wrote: >> On 2016?08?27? 11:39, Chris Zhong wrote: >>> The setting of vop registers need a reg_done writing to take effect. >>> In vop_enable the vop return to work by by restoring registers, but the >>> registers do not take effect immediately, it should a vop_cfg_done >>> after it. The same thing is needed by windows_disabled in >>> vop_crtc_disable. >>> >>> Signed-off-by: Chris Zhong >>> --- >>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >> Thanks for your fix. >> >> applied to my drm-fixes. > This patch seems to have been lost in action. I don't see it in linux-next. > > Best regards, > Tomasz > > > -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbdAQKIS (ORCPT ); Tue, 17 Jan 2017 05:08:18 -0500 Received: from regular1.263xmail.com ([211.150.99.132]:55894 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbdAQKIN (ORCPT ); Tue, 17 Jan 2017 05:08:13 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: briannorris@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: vop: make vop register setting take effect To: Tomasz Figa References: <1472269178-16593-1-git-send-email-zyw@rock-chips.com> <57C3A341.9030302@rock-chips.com> Cc: Chris Zhong , =?UTF-8?B?5aea5pm65oOF?= , =?UTF-8?Q?Heiko_St=c3=bcbner?= , David Airlie , Douglas Anderson , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sean Paul , briannorris@chromium.org From: Mark yao Message-ID: <587DECC3.50304@rock-chips.com> Date: Tue, 17 Jan 2017 18:06:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz I had sent to Dave, but maybe something is wrong, it miss. the patch is on this pull-request: https://lists.freedesktop.org/archives/dri-devel/2016-September/118505.html I forgot to double check it, I will resend to Dave soon. Thanks. On 2017年01月17日 17:32, Tomasz Figa wrote: > Hi Mark, > > On Mon, Aug 29, 2016 at 11:51 AM, Mark yao wrote: >> On 2016年08月27日 11:39, Chris Zhong wrote: >>> The setting of vop registers need a reg_done writing to take effect. >>> In vop_enable the vop return to work by by restoring registers, but the >>> registers do not take effect immediately, it should a vop_cfg_done >>> after it. The same thing is needed by windows_disabled in >>> vop_crtc_disable. >>> >>> Signed-off-by: Chris Zhong >>> --- >>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >> Thanks for your fix. >> >> applied to my drm-fixes. > This patch seems to have been lost in action. I don't see it in linux-next. > > Best regards, > Tomasz > > > -- Ｍark Yao