Re: [PATCH] drm/i915: Fix a typo in vgt_balloon_space()

[Zhi Wang <zhi.a.wang@intel.com>]

Thanks, Will update it in V2 :P

于 01/17/17 22:27, Jani Nikula:
> On Tue, 17 Jan 2017, Zhi Wang <zhi.a.wang@intel.com> wrote:
>> From: Zhenyu Wang <zhenyuw@linux.intel.com>
>>
>> Commit 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a
>> helper") introduces this typo which can cause a driver loading failure
>> in Linux GVT-g guest.
>
> The proper format for fixes is:
>
> Fixes: 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper")
>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Zhiyuan Lv <zhiyuan.lv@intel.com>
>> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
>> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_vgpu.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_vgpu.c b/drivers/gpu/drm/i915/i915_vgpu.c
>> index f1ad4fb..d0abfd0 100644
>> --- a/drivers/gpu/drm/i915/i915_vgpu.c
>> +++ b/drivers/gpu/drm/i915/i915_vgpu.c
>> @@ -122,7 +122,7 @@ static int vgt_balloon_space(struct i915_ggtt *ggtt,
>>   {
>>   	unsigned long size = end - start;
>>
>> -	if (start <= end)
>> +	if (start >= end)
>>   		return -EINVAL;
>>
>>   	DRM_INFO("balloon space: range [ 0x%lx - 0x%lx ] %lu KiB.\n",
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx