Re: [PATCH v3 2/2] tpm: enhance TPM 2.0 PCR extend to support multiple banks

[Nayna <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>]

On 01/16/2017 03:11 PM, Jarkko Sakkinen wrote:
> On Fri, Jan 13, 2017 at 03:19:59PM -0500, Ken Goldman wrote:
>> On 1/13/2017 11:43 AM, Jarkko Sakkinen wrote:
>>
>>>>>> +struct tpml_digest_values {
>>>>>> +	u32 count;
>>>>>> +	struct tpmt_ha digests[TPM2_ACTIVE_PCR_BANKS];
>>>>>> +} __packed;
>>>>>
>>>>> Please remove this structure.
>>>>
>>>> Sorry Jarkko, I didn't understand this comment.
>>>> Why do we want to remove this structure.
>>>
>>> Well it is only used to pass two parameters.
>>
>> Might it be good in general to reuse TPM Part 2
>> structures?  For someone familiar with the TPM
>> spec, it could make reading the device driver code
>> easier.
>
> Having a structure to encapsulate two parameters is an overkill.

As per TCG TPM 2.0 Spec, struct tpml_digest_values is member of both 
extend structure and tcg_pcr_event structure.

These two structs are part of event log patch set also
So, will update event log patch as well.

Thanks & Regards,
    - Nayna

>
> /Jarkko
>
> ------------------------------------------------------------------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today. http://sdm.link/xeonphi
> _______________________________________________
> tpmdd-devel mailing list
> tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot