From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C4B7C87FCB for ; Tue, 5 Aug 2025 15:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:From:References:To:MIME-Version:Date:Message-ID:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m6pV9Pw5jmiGuWvNOoAWij+ypI3b8byoPpkcEh2T/RQ=; b=HGVpyZ4Shy/A+8IXVBVGm8AcqL xFnOhkR2FUPLAzjYtsI0HPmqNxudP+I9nutSBLcPQZcnXgyMmEv2ysKPXMgTNpcelEVfc0okoy0nW 0sZu8/8fTKIshOnSilHESM+BAAqxutL8k+Ac6wlkfa06/7F+3il0grHXjGVhoJUBFFwU=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1ujJr6-0004dG-9L; Tue, 05 Aug 2025 15:45:36 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ujJr4-0004d8-TM for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Aug 2025 15:45:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=47A3S9FnGtkQV47KZ1o1yY1stYF6mjY7RIPXGnIszns=; b=Xe+qPh9KObjwNbH3Xy2GsBePUj b7gYBpi3GJ0i3pAUCVtl8Z/5/Iia81ZdwQXkp/XiraNywf0BwZ+Bh7k4Sn9191s8NcZiHVkeasqyk xm8wnr/qzTrSB/HOAUQXAp39FCz9yMqfk57o2Mwv210EfjZHY4n+ZMQQswbZS6f0/Els=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=47A3S9FnGtkQV47KZ1o1yY1stYF6mjY7RIPXGnIszns=; b=W377OCNsXm17vIVFc3y2hhBw9f q11ci9zhbL+EU3EL0DiHe+TUkSKVjHVBsmjHt6zYd4z1q0nhETwxJ61aINueSf/lQd63x7xr0P6Jm Ijt5r7HkbMo1F1E1bvipcvk38wqukHSQi/rjA5ezciclINXKvkfVlv4nsv+aHbxpM3TM=; Received: from mail-qt1-f170.google.com ([209.85.160.170]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1ujJr4-0002yl-C4 for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Aug 2025 15:45:34 +0000 Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4abd3627e7eso75673571cf.0 for ; Tue, 05 Aug 2025 08:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1754408723; x=1755013523; darn=lists.sourceforge.net; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=47A3S9FnGtkQV47KZ1o1yY1stYF6mjY7RIPXGnIszns=; b=yyFJIo24pY8WIawKB09jsPzLLlLMZxxgQrxfC6xOIDULBQZActjbzaabGN9Xxn+4il QyyO/u1If5gMgRrUXfsJCO28lVBhIXx/O2Z8AHDcwL8QoVKB1MJHv+pkqGtg07VejXkh DNLArqGesHNKIdhVinUMwg9eu1fg5c+424rwr9YudgBvej58udXS6618a1IGNqU2uK45 mydxO+oFOfLc4fhh9i9/9QxEIL27SnTP8C+E3Ek07I+3IrHYJvcc36SOHUpYK4QkgLpw QMfjwpm6+tdzZ3cEHHzRRkwgNf+CcSra5lKAKMxGzPssjrBX/YCqRwJN0jUomAfnIQ7t J92w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754408723; x=1755013523; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=47A3S9FnGtkQV47KZ1o1yY1stYF6mjY7RIPXGnIszns=; b=Ww3E01jwC74BCsKS+SCCumwIolbZPix6iuTGgV0hqfmjU9OfUQdhSVaF3alcJKG/k6 QQAFkHF8WJuS1PSP4A0QKGXL4X2l1OkS2Lhdz/L1zOc0+WP6XbtWnv5ZfevYFbEddeCe VkoAKxJmvJ6nMA8rLBRaEODP9TexaMm/rYWPfn1VFE1QrJSiHSV5B+0eTHUJc2qEOSXJ Tr4Pf9F5vapJH2rgGOqgsi+0JEhNGQKZH0tjlK+o49SXTUEgPZI7r09Zof9mtjc6S7PB pD0x9o9/o7Om6UsPhuU1ceU4WXCwfqFJQpE5e0982YFNt9QGPZDQ6XhRPvtitL6DhVd8 60qg== X-Gm-Message-State: AOJu0Yy/aEdM+DkZGpV+F15yOu1cMBPvHGw2zVUdhoWZHmEGV30BU/Fx Daih5eNom0ZLFht8HxzZnORMh9fLPhaqdKHLD+IOaWGi9RIUoHOYusrJ1T9kdPIXY4Wev48i9to wMlhn X-Gm-Gg: ASbGncv3CKizq6+adMYQG/kxLNqyvUW0zSz+uX9MK3HPZsPsX/InVW2BJytyml20dms 3gTlOdsHhEJponnvRmVlK0B6Mw5zauVycG9IOjhL3g21RXyxkjBNQ3CGTR83z1kOcNmGPMO0wfP vPh6O9C83pgp4Ol46gEkL8WaxVwG14rlIMzauWdMn1kgPfH46JXsiEE0qdkyNlxiW7iysWS5sFh 0wtAoEn4gkXKJT8LifBISpNgfiqlA1mJM4viu4gmcqlvSOmxPbpxlWncTYmR4aZBG+CpammCaXd YCSqyYCg5oaH0KgGc4k91EuxH7N4Wt2KBZEOFIBeCbeW32llTMGbtRnaG9yvInURiTB4wc/zXD1 lfWPMnupJCzjZWWe14qOFPZJBwdq7uoU= X-Google-Smtp-Source: AGHT+IFbGSolRCLm47b3U3xA+x+p+1MYURYNlUpeNbBwyIHwxQaPUJLM1WRayP7DldFQq37IC2UIEg== X-Received: by 2002:a17:903:2446:b0:240:2e99:906c with SMTP id d9443c01a7336-24246f6b703mr201065385ad.15.1754408266480; Tue, 05 Aug 2025 08:37:46 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241d1f1efe8sm135152195ad.69.2025.08.05.08.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 08:37:45 -0700 (PDT) Message-ID: <587aaee2-8d84-4eb5-9b87-22947abd0752@kernel.dk> Date: Tue, 5 Aug 2025 09:37:44 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Chao Yu , jaegeuk@kernel.org References: <20250805061914.3067747-1-chao@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250805061914.3067747-1-chao@kernel.org> X-Headers-End: 1ujJr4-0002yl-C4 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix to return -EOPNOTSUPP for uncached write X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qi Han , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 8/5/25 12:19 AM, Chao Yu wrote: > f2fs doesn't support uncached write yet, for write() w/ IOCB_DONTCACHE > flag, let's return -EOPNOTSUPP instead of ignoring IOCB_DONTCACHE flag > and write w/o uncached IO. Didn't we agree that write support should be pursued first before bifurcating the read/write DONTCACHE support? -- Jens Axboe _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 692291DE2C2 for ; Tue, 5 Aug 2025 15:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754408269; cv=none; b=prhcH9FsQn70fi8YY+TvUq7gzZ1SA5z2rmCP1DseAmjAflGXl7rkQ5MRfrr3y1kKyB9qyV+Iktrki7ZNEr10MBTPNXz25rOWhDE0+4SFw3emMLYFPuPVOi8o/1RvbVcefbLpmRV03vk2abTso2qX3gT6w0BE6RFaLgCItrG8F00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754408269; c=relaxed/simple; bh=8b3r82mCrVkXVOkxHyvPWTaQtOq7d/lEZRMHoIM7T5g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=STKTQEc66B903ykrcA4lcd6Rs2t5+zGnoUpuXBPgtaGIabhO1g2tAQflo/GT73ws9JD/n2ur3isb6mh8ToGKDoewmrjZA1zIojP7mNFtYf0aFSIqQEcvTIERLMmOvApMCIuSdztLqoIW/ilEKg2d9DMPnNDJYAOFLfv6E/I2DBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=yy07/7iv; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="yy07/7iv" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-b427f4a9652so140882a12.2 for ; Tue, 05 Aug 2025 08:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1754408266; x=1755013066; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=47A3S9FnGtkQV47KZ1o1yY1stYF6mjY7RIPXGnIszns=; b=yy07/7iv9ZOOjqnlqKd/RUP9qexNGKlsWpAVphKrj+Dy82uQnt3yJeqq4pTxsHzA59 eXmorgSIPc49coVurZkw5QWsxN8m4DStxzfmV3bkDlUnBRXLyuG1r87VJ1tlibCwUU2p mx6QrXn7SqVYs1tGxYB/NEzI+t4q45Mki0BM/hZY5nC99GDv+4H1lA1CQqWmggynbQZQ TwiKHzAbzS6npkkN6sOIKBrd6TUgqbfloNBttw+EWPWgbd8NEocLKAQ97m127V7/yiZD xA9/J9sdCrBoUMIZygb63vOQV5c/nqATSPNFNUvhYkcCEcv5E7uSFwYzWlD29LdY41V3 j/MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754408266; x=1755013066; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=47A3S9FnGtkQV47KZ1o1yY1stYF6mjY7RIPXGnIszns=; b=vTCzZhihO+jyurDsjTnUdp9EElmfwku8JQek8L4/piujkQ6l+Oz6jNcpn12PcmWzBV 0tRO+TcsqoGiVmYDkWqVDPqQRsN5xqcksHobwMxTXghzXbYL527OFrVBAfyadYupZXky Xs1jFNoV1wpBNl2DfOr7ygB+/daqzt5VWrVXcByA+t98O0YJAE1OMxqN0GRX/Md3Pw+w vnU7/strzwKiYd9yRyeTbGWMnQXWgG95xhtOiioocypi0xhzPqdyAuOIT0WgTfJAEsVn 0rOsIUvcwo8SjZRlspssqMxgfbOarTrDBRYjMQHYZFLHqrJ9B17cyQM7R4Rk/66WzcHE 0EIg== X-Forwarded-Encrypted: i=1; AJvYcCUbbqer04eRX/BI/LMxqP3BG08uehKLzUIpywe+9Xh9yYLvjuC8NngrnCtx/qVea66XlP7nml/ileY3tHw=@vger.kernel.org X-Gm-Message-State: AOJu0YxLpDVGYo6LJDLfnK2Oo2KXryqxoYfIrjwV/xH10AnJUENLT/Vh A+tSK/mXy8KHKVDB2WEqYjewKB+4320a+rYiK7XSZRz56sT/zLKnd1is88yes6SgEc/i9BhGS+o uBL7V X-Gm-Gg: ASbGnctMD+20zXEVuX1ir1VzVQE1gpLNveejnSFlSTkNsUMXAEPGXDqfGYj1Czftt/2 o2/y7+kgNU6l+MaCirMemuX5w47daziTLi+H4f+LjtLkARLt3cOuEPthzTGM1yWCAn3UM3OmaR6 vshsxwmnTSZG13mcy13ruLSoycJgcz240LvNiX1+S/zhB/8UeJwOIWdbIDwM3j0jD0exr5BjBle qTWszViiu7eMD/azHvSTLIUrCSwMorwKiqihbn35mQ5GmKeZkbK4NsuiXrJLbqWnxjnJ6Tb+0Is tLJaYlQfnkqLzAEwQ7KIb+GUBDr6+PwWuH2SYUK4aHoSXQEHogo+gbTaoQA0jAkURAICSRmSwjM JLhixd87Qsbd4XoOpwyAs X-Google-Smtp-Source: AGHT+IFbGSolRCLm47b3U3xA+x+p+1MYURYNlUpeNbBwyIHwxQaPUJLM1WRayP7DldFQq37IC2UIEg== X-Received: by 2002:a17:903:2446:b0:240:2e99:906c with SMTP id d9443c01a7336-24246f6b703mr201065385ad.15.1754408266480; Tue, 05 Aug 2025 08:37:46 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241d1f1efe8sm135152195ad.69.2025.08.05.08.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 08:37:45 -0700 (PDT) Message-ID: <587aaee2-8d84-4eb5-9b87-22947abd0752@kernel.dk> Date: Tue, 5 Aug 2025 09:37:44 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] f2fs: fix to return -EOPNOTSUPP for uncached write To: Chao Yu , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Qi Han References: <20250805061914.3067747-1-chao@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250805061914.3067747-1-chao@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/5/25 12:19 AM, Chao Yu wrote: > f2fs doesn't support uncached write yet, for write() w/ IOCB_DONTCACHE > flag, let's return -EOPNOTSUPP instead of ignoring IOCB_DONTCACHE flag > and write w/o uncached IO. Didn't we agree that write support should be pursued first before bifurcating the read/write DONTCACHE support? -- Jens Axboe