From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH 1/3] drm/exynos/decon5433: do not disable video after reset Date: Fri, 20 Jan 2017 16:56:54 +0900 Message-ID: <5881C2C6.9080103@samsung.com> References: <1484662520-17012-1-git-send-email-a.hajda@samsung.com> <1484662520-17012-2-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F7626EB3C for ; Fri, 20 Jan 2017 07:56:58 +0000 (UTC) Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OK2017M4JEVDL50@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 20 Jan 2017 16:56:55 +0900 (KST) In-reply-to: <1484662520-17012-2-git-send-email-a.hajda@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda , dri-devel@lists.freedesktop.org Cc: Marek Szyprowski , linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz List-Id: dri-devel@lists.freedesktop.org QXBwbGllZCBpbmNsdWRpbmcgb3RoZXIgdHdvIHBhdGNoZXMuCgpUaGFua3MuCgoyMDE364WEIDAx 7JuUIDE37J28IDIzOjE17JeQIEFuZHJ6ZWogSGFqZGEg7J20KOqwgCkg7JO0IOq4gDoKPiBkZWNv bl9jb21taXQgaXMgY2FsbGVkIGp1c3QgYWZ0ZXIgcmVzZXQgc28gdmlkZW8gaXMgZGlzYWJsZWQg YW55d2F5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ftc3Vu Zy5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zNTQzM19kcm1fZGVj b24uYyB8IDIgLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zNTQzM19kcm1fZGVjb24uYyBiL2Ry aXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zNTQzM19kcm1fZGVjb24uYwo+IGluZGV4IDYzNGNm ZDcuLjZmZDJiMTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3M1 NDMzX2RybV9kZWNvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3M1NDMz X2RybV9kZWNvbi5jCj4gQEAgLTE1OCw4ICsxNTgsNiBAQCBzdGF0aWMgdm9pZCBkZWNvbl9jb21t aXQoc3RydWN0IGV4eW5vc19kcm1fY3J0YyAqY3J0YykKPiAgCQltLT5jcnRjX3ZzeW5jX2VuZCA9 IG0tPmNydGNfdnN5bmNfc3RhcnQgKyAxOwo+ICAJfQo+ICAKPiAtCWRlY29uX3NldF9iaXRzKGN0 eCwgREVDT05fVklEQ09OMCwgVklEQ09OMF9FTlZJRCwgMCk7Cj4gLQo+ICAJLyogZW5hYmxlIGNs b2NrIGdhdGUgKi8KPiAgCXZhbCA9IENNVV9DTEtHQUdFX01PREVfU0ZSX0YgfCBDTVVfQ0xLR0FH RV9NT0RFX01FTV9GOwo+ICAJd3JpdGVsKHZhbCwgY3R4LT5hZGRyICsgREVDT05fQ01VKTsKPiAK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbdATH5G (ORCPT ); Fri, 20 Jan 2017 02:57:06 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:41203 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbdATH5E (ORCPT ); Fri, 20 Jan 2017 02:57:04 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a59-f79c56d000006d2c-de-5881c2c7d88d Content-transfer-encoding: 8BIT Message-id: <5881C2C6.9080103@samsung.com> Date: Fri, 20 Jan 2017 16:56:54 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andrzej Hajda , dri-devel@lists.freedesktop.org Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/exynos/decon5433: do not disable video after reset In-reply-to: <1484662520-17012-2-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEKsWRmVeSWpSXmKPExsWy7bCmuu7xQ40RBlfXSVrcWneO1WLjjPWs Fle+vmezuLxrDpvF2iN32R1YPe53H2fy6NuyitHj8ya5AOaoVJuM1MSU1CKF1Lzk/JTMvHRb Je/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoJVKCmWJOaVAoYDE4mIlfTubovzSklSF jPziElulaENDIz1DA3M9IyMjPRPjWCsjU6CShNSMj5862AtWsVf0HP3B2sA4ka2LkZNDQsBE ouvkUWYIW0ziwr31QHEuDiGBpYwSTZN/MkM47UwS+2+8ZYXp2PBjM1TVckaJiUvmMYIkeAUE JX5MvsfSxcjBwSwgL3HkUjZImFlAU+LFl0ksEPX3GCVu7f7BBlGvJXHh4VMmEJtFQFWi995S sDPYgOyJK+6D1YgKREjsnP+NHcQWEfCQODptERPIIGaBVkaJr+f+gxUJCwRKPLpykxVkMaeA i8TTRxUQh3azS1zaLgASlhCQldh0AOpLF4mfR+5AfS8s8er4FnYIW1ri79JbjCDjgVoZJa73 9LBBOB2MEn87/7NAVBlL3H9wjxniMz6J3t9PmCAW8Ep0tAlBmB4STQcVIaodJaZvOcQI8ftF RomGly9ZJjDKz0IKrlmI4JqFFFwLGJlXMYqlFhTnpqcWmxaY6hUn5haX5qXrJefnbmIEpzet yB2MV2YGHWIU4GBU4uGd4dQYIcSaWFZcmXuIUYKDWUmEt2c9UIg3JbGyKrUoP76oNCe1+BCj KTC0JzJLiSbnA1NvXkm8oYmZoYmRJRCaG5orifMuqLCOEBJITyxJzU5NLUgtgulj4uCUamCs bG2ezVIQw94uHn/PyKbn2vQ9MjY2wYZMc/9UabVZrhT/wP6BR2XXEc66DPMnVkukX29RCf+y +urNH2f0Uvb8bqiskulgiGa8+pSP5XRsY8adQ557H/lcnCl4MkArsoSn3KFN6MR/Fy+Ng4nN Uj6hPMwdGVbbkhyUrD89CnTsemR45up/aSWW4oxEQy3mouJEAL5Og++FAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsVy+t9jAd1jhxojDE4vtrK4te4cq8XGGetZ La58fc9mcXnXHDaLtUfusjuwetzvPs7k0bdlFaPH501yAcxRbjYZqYkpqUUKqXnJ+SmZeem2 SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W0rdLcMv4+KmDvWAVe0XP0R+s DYwT2boYOTkkBEwkNvzYDGWLSVy4tx7MFhJYyijxfG4JiM0rICjxY/I9li5GDg5mAXmJI5ey IUx1iSlTcrsYuYCqHzBK7F/7iR2iXEviwsOnTCA2i4CqRO+9pcwgNhuQPXHFfTaQXlGBCInu E5UgYREBD4mj0xYxgcxhFmhllJhyeTIrSEJYwF/i7oMOFogFFxkl7jR+Zwdp5hRwkXj6qGIC o8AsJNfNQrhuFsJ1CxiZVzFKpBYkFxQnpeca5aWW6xUn5haX5qXrJefnbmIEx8wz6R2Mh3e5 H2IU4GBU4uHNkGiMEGJNLCuuzD3EKMHBrCTC27MeKMSbklhZlVqUH19UmpNafIjRFOi9icxS osn5wHjOK4k3NDE3MTc2sDC3tDQxUhLnbZz9LFxIID2xJDU7NbUgtQimj4mDU6qBkTHeVdYg cKrLoa0p3ZXBrP/+c6dKTP/+RLVb1z2C5/D2l2e9jhifSfjA82/jI6Yf191U9W/MEd6+/+2H SKX1M81KzfddXNSn9kvzm9yUg3Ods+V+cUpfuRC9+k1Wh8nn3RIZe45e+Ljk3W5NCZW0FIVt K5Xy9mqnvd5qeGD2CZliq09T6jb0iCuxFGckGmoxFxUnAgBdUFMurwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170120075654epcas5p31bdddeb2460b53efabf6ae2af6a6f71b X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1M1L1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170117141533eucas1p2494854a3707ce9cfa78ef3d6030535df X-RootMTR: 20170117141533eucas1p2494854a3707ce9cfa78ef3d6030535df References: <1484662520-17012-1-git-send-email-a.hajda@samsung.com> <1484662520-17012-2-git-send-email-a.hajda@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied including other two patches. Thanks. 2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글: > decon_commit is called just after reset so video is disabled anyway. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > index 634cfd7..6fd2b11 100644 > --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > @@ -158,8 +158,6 @@ static void decon_commit(struct exynos_drm_crtc *crtc) > m->crtc_vsync_end = m->crtc_vsync_start + 1; > } > > - decon_set_bits(ctx, DECON_VIDCON0, VIDCON0_ENVID, 0); > - > /* enable clock gate */ > val = CMU_CLKGAGE_MODE_SFR_F | CMU_CLKGAGE_MODE_MEM_F; > writel(val, ctx->addr + DECON_CMU); >