From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v2 14/26] drm/rockchip: dw-mipi-dsi: fix escape clock rate Date: Sun, 22 Jan 2017 17:37:18 +0800 Message-ID: <58847D4E.9020002@rock-chips.com> References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-15-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170121163128.22240-15-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping , Mark Yao Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org UmV2aWV3ZWQtYnk6IENocmlzIFpob25nIDx6eXdAcm9jay1jaGlwcy5jb20+CgpPbiAwMS8yMi8y MDE3IDEyOjMxIEFNLCBKb2huIEtlZXBpbmcgd3JvdGU6Cj4gVXNlIHRoZSBzYW1lIGNhbGN1bGF0 aW9uIGFzIHRoZSB2ZW5kb3Iga2VybmVsIHRvIGRlcml2ZSB0aGUgZXNjYXBlIGNsb2NrCj4gc3Bl ZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKb2huIEtlZXBpbmcgPGpvaG5AbWV0YW5hdGUuY29tPgo+ IC0tLQo+IFVuY2hhbmdlZCBpbiB2Mgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw L2R3LW1pcGktZHNpLmMgfCA0ICsrKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvZHctbWlwaS1kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5j Cj4gaW5kZXggMjkwMjgyZTg2ZDE2Li5jMmUwYmE5NmUwYTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v cm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+IEBAIC03MTAsMTEgKzcxMCwxMyBAQCBzdGF0aWMgdm9p ZCBkd19taXBpX2RzaV9kaXNhYmxlKHN0cnVjdCBkd19taXBpX2RzaSAqZHNpKQo+ICAgCj4gICBz dGF0aWMgdm9pZCBkd19taXBpX2RzaV9pbml0KHN0cnVjdCBkd19taXBpX2RzaSAqZHNpKQo+ICAg ewo+ICsJdTMyIGVzY19jbGtfZGl2aXNpb24gPSAoZHNpLT5sYW5lX21icHMgPj4gMykgLyAyMCAr IDE7Cj4gKwo+ICAgCWRzaV93cml0ZShkc2ksIERTSV9QV1JfVVAsIFJFU0VUKTsKPiAgIAlkc2lf d3JpdGUoZHNpLCBEU0lfUEhZX1JTVFosIFBIWV9ESVNGT1JDRVBMTCB8IFBIWV9ESVNBQkxFQ0xL Cj4gICAJCSAgfCBQSFlfUlNUWiB8IFBIWV9TSFVURE9XTlopOwo+ICAgCWRzaV93cml0ZShkc2ks IERTSV9DTEtNR1JfQ0ZHLCBUT19DTEtfRElWSURTSU9OKDEwKSB8Cj4gLQkJICBUWF9FU0NfQ0xL X0RJVklEU0lPTig3KSk7Cj4gKwkJICBUWF9FU0NfQ0xLX0RJVklEU0lPTihlc2NfY2xrX2Rpdmlz aW9uKSk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIGR3X21pcGlfZHNpX2RwaV9jb25maWco c3RydWN0IGR3X21pcGlfZHNpICpkc2ksCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: zyw@rock-chips.com (Chris Zhong) Date: Sun, 22 Jan 2017 17:37:18 +0800 Subject: [PATCH v2 14/26] drm/rockchip: dw-mipi-dsi: fix escape clock rate In-Reply-To: <20170121163128.22240-15-john@metanate.com> References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-15-john@metanate.com> Message-ID: <58847D4E.9020002@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Reviewed-by: Chris Zhong On 01/22/2017 12:31 AM, John Keeping wrote: > Use the same calculation as the vendor kernel to derive the escape clock > speed. > > Signed-off-by: John Keeping > --- > Unchanged in v2 > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 290282e86d16..c2e0ba96e0a0 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -710,11 +710,13 @@ static void dw_mipi_dsi_disable(struct dw_mipi_dsi *dsi) > > static void dw_mipi_dsi_init(struct dw_mipi_dsi *dsi) > { > + u32 esc_clk_division = (dsi->lane_mbps >> 3) / 20 + 1; > + > dsi_write(dsi, DSI_PWR_UP, RESET); > dsi_write(dsi, DSI_PHY_RSTZ, PHY_DISFORCEPLL | PHY_DISABLECLK > | PHY_RSTZ | PHY_SHUTDOWNZ); > dsi_write(dsi, DSI_CLKMGR_CFG, TO_CLK_DIVIDSION(10) | > - TX_ESC_CLK_DIVIDSION(7)); > + TX_ESC_CLK_DIVIDSION(esc_clk_division)); > } > > static void dw_mipi_dsi_dpi_config(struct dw_mipi_dsi *dsi, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751187AbdAVJhv (ORCPT ); Sun, 22 Jan 2017 04:37:51 -0500 Received: from regular1.263xmail.com ([211.150.99.136]:50653 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdAVJhs (ORCPT ); Sun, 22 Jan 2017 04:37:48 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <101e9a4b2234119a9b51bc84658d7e7e> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 14/26] drm/rockchip: dw-mipi-dsi: fix escape clock rate To: John Keeping , Mark Yao References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-15-john@metanate.com> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Chris Zhong Message-ID: <58847D4E.9020002@rock-chips.com> Date: Sun, 22 Jan 2017 17:37:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20170121163128.22240-15-john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Chris Zhong On 01/22/2017 12:31 AM, John Keeping wrote: > Use the same calculation as the vendor kernel to derive the escape clock > speed. > > Signed-off-by: John Keeping > --- > Unchanged in v2 > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 290282e86d16..c2e0ba96e0a0 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -710,11 +710,13 @@ static void dw_mipi_dsi_disable(struct dw_mipi_dsi *dsi) > > static void dw_mipi_dsi_init(struct dw_mipi_dsi *dsi) > { > + u32 esc_clk_division = (dsi->lane_mbps >> 3) / 20 + 1; > + > dsi_write(dsi, DSI_PWR_UP, RESET); > dsi_write(dsi, DSI_PHY_RSTZ, PHY_DISFORCEPLL | PHY_DISABLECLK > | PHY_RSTZ | PHY_SHUTDOWNZ); > dsi_write(dsi, DSI_CLKMGR_CFG, TO_CLK_DIVIDSION(10) | > - TX_ESC_CLK_DIVIDSION(7)); > + TX_ESC_CLK_DIVIDSION(esc_clk_division)); > } > > static void dw_mipi_dsi_dpi_config(struct dw_mipi_dsi *dsi,