From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v2 20/26] drm/rockchip: dw-mipi-dsi: use specific poll helper Date: Mon, 23 Jan 2017 08:49:22 +0800 Message-ID: <58855312.7020207@rock-chips.com> References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-21-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170121163128.22240-21-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping , Mark Yao Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org ClJldmlld2VkLWJ5OiBDaHJpcyBaaG9uZyA8enl3QHJvY2stY2hpcHMuY29tPgoKT24gMDEvMjIv MjAxNyAxMjozMSBBTSwgSm9obiBLZWVwaW5nIHdyb3RlOgo+IEFzIHRoZSBkb2N1bWVudGF0aW9u IGZvciByZWFkeF9wb2xsX3RpbWVvdXQgc2F5cywgd2Ugd2FudCB0byB1c2UgdGhlCj4gc3BlY2lh bGl6ZWQgbWFjcm8gZm9yIHJlYWRsIHJhdGhlciB0aGFuIHVzaW5nIHRoZSBnZW5lcmljIHZlcnNp b24KPiBkaXJlY3RseS4KPgo+IFNpZ25lZC1vZmYtYnk6IEpvaG4gS2VlcGluZyA8am9obkBtZXRh bmF0ZS5jb20+Cj4gLS0tCj4gVW5jaGFuZ2VkIGluIHYyCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYyB8IDEwICsrKysrLS0tLS0KPiAgIDEgZmlsZSBjaGFu Z2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvZHctbWlwaS1kc2kuYwo+IGluZGV4IGYyMzIwY2YxMzY2Yy4uM2UxOTY5M2FlNTliIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMKPiBAQCAtNDcxLDE0ICs0 NzEsMTQgQEAgc3RhdGljIGludCBkd19taXBpX2RzaV9waHlfaW5pdChzdHJ1Y3QgZHdfbWlwaV9k c2kgKmRzaSkKPiAgIAkJCQkgICAgIFBIWV9VTlJTVFogfCBQSFlfVU5TSFVURE9XTlopOwo+ICAg Cj4gICAKPiAtCXJldCA9IHJlYWR4X3BvbGxfdGltZW91dChyZWFkbCwgZHNpLT5iYXNlICsgRFNJ X1BIWV9TVEFUVVMsCj4gKwlyZXQgPSByZWFkbF9wb2xsX3RpbWVvdXQoZHNpLT5iYXNlICsgRFNJ X1BIWV9TVEFUVVMsCj4gICAJCQkJIHZhbCwgdmFsICYgTE9DSywgMTAwMCwgUEhZX1NUQVRVU19U SU1FT1VUX1VTKTsKPiAgIAlpZiAocmV0IDwgMCkgewo+ICAgCQlkZXZfZXJyKGRzaS0+ZGV2LCAi ZmFpbGVkIHRvIHdhaXQgZm9yIHBoeSBsb2NrIHN0YXRlXG4iKTsKPiAgIAkJcmV0dXJuIHJldDsK PiAgIAl9Cj4gICAKPiAtCXJldCA9IHJlYWR4X3BvbGxfdGltZW91dChyZWFkbCwgZHNpLT5iYXNl ICsgRFNJX1BIWV9TVEFUVVMsCj4gKwlyZXQgPSByZWFkbF9wb2xsX3RpbWVvdXQoZHNpLT5iYXNl ICsgRFNJX1BIWV9TVEFUVVMsCj4gICAJCQkJIHZhbCwgdmFsICYgU1RPUF9TVEFURV9DTEtfTEFO RSwgMTAwMCwKPiAgIAkJCQkgUEhZX1NUQVRVU19USU1FT1VUX1VTKTsKPiAgIAlpZiAocmV0IDwg MCkgewo+IEBAIC01OTQsNyArNTk0LDcgQEAgc3RhdGljIGludCBkd19taXBpX2RzaV9nZW5fcGt0 X2hkcl93cml0ZShzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSwgdTMyIGhkcl92YWwpCj4gICAJaW50 IHJldDsKPiAgIAl1MzIgdmFsLCBtYXNrOwo+ICAgCj4gLQlyZXQgPSByZWFkeF9wb2xsX3RpbWVv dXQocmVhZGwsIGRzaS0+YmFzZSArIERTSV9DTURfUEtUX1NUQVRVUywKPiArCXJldCA9IHJlYWRs X3BvbGxfdGltZW91dChkc2ktPmJhc2UgKyBEU0lfQ01EX1BLVF9TVEFUVVMsCj4gICAJCQkJIHZh bCwgISh2YWwgJiBHRU5fQ01EX0ZVTEwpLCAxMDAwLAo+ICAgCQkJCSBDTURfUEtUX1NUQVRVU19U SU1FT1VUX1VTKTsKPiAgIAlpZiAocmV0IDwgMCkgewo+IEBAIC02MDUsNyArNjA1LDcgQEAgc3Rh dGljIGludCBkd19taXBpX2RzaV9nZW5fcGt0X2hkcl93cml0ZShzdHJ1Y3QgZHdfbWlwaV9kc2kg KmRzaSwgdTMyIGhkcl92YWwpCj4gICAJZHNpX3dyaXRlKGRzaSwgRFNJX0dFTl9IRFIsIGhkcl92 YWwpOwo+ICAgCj4gICAJbWFzayA9IEdFTl9DTURfRU1QVFkgfCBHRU5fUExEX1dfRU1QVFk7Cj4g LQlyZXQgPSByZWFkeF9wb2xsX3RpbWVvdXQocmVhZGwsIGRzaS0+YmFzZSArIERTSV9DTURfUEtU X1NUQVRVUywKPiArCXJldCA9IHJlYWRsX3BvbGxfdGltZW91dChkc2ktPmJhc2UgKyBEU0lfQ01E X1BLVF9TVEFUVVMsCj4gICAJCQkJIHZhbCwgKHZhbCAmIG1hc2spID09IG1hc2ssCj4gICAJCQkJ IDEwMDAsIENNRF9QS1RfU1RBVFVTX1RJTUVPVVRfVVMpOwo+ICAgCWlmIChyZXQgPCAwKSB7Cj4g QEAgLTY2NCw3ICs2NjQsNyBAQCBzdGF0aWMgaW50IGR3X21pcGlfZHNpX2Rjc19sb25nX3dyaXRl KHN0cnVjdCBkd19taXBpX2RzaSAqZHNpLAo+ICAgCQkJbGVuIC09IHBsZF9kYXRhX2J5dGVzOwo+ ICAgCQl9Cj4gICAKPiAtCQlyZXQgPSByZWFkeF9wb2xsX3RpbWVvdXQocmVhZGwsIGRzaS0+YmFz ZSArIERTSV9DTURfUEtUX1NUQVRVUywKPiArCQlyZXQgPSByZWFkbF9wb2xsX3RpbWVvdXQoZHNp LT5iYXNlICsgRFNJX0NNRF9QS1RfU1RBVFVTLAo+ICAgCQkJCQkgdmFsLCAhKHZhbCAmIEdFTl9Q TERfV19GVUxMKSwgMTAwMCwKPiAgIAkJCQkJIENNRF9QS1RfU1RBVFVTX1RJTUVPVVRfVVMpOwo+ ICAgCQlpZiAocmV0IDwgMCkgewoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: zyw@rock-chips.com (Chris Zhong) Date: Mon, 23 Jan 2017 08:49:22 +0800 Subject: [PATCH v2 20/26] drm/rockchip: dw-mipi-dsi: use specific poll helper In-Reply-To: <20170121163128.22240-21-john@metanate.com> References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-21-john@metanate.com> Message-ID: <58855312.7020207@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Reviewed-by: Chris Zhong On 01/22/2017 12:31 AM, John Keeping wrote: > As the documentation for readx_poll_timeout says, we want to use the > specialized macro for readl rather than using the generic version > directly. > > Signed-off-by: John Keeping > --- > Unchanged in v2 > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index f2320cf1366c..3e19693ae59b 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -471,14 +471,14 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi) > PHY_UNRSTZ | PHY_UNSHUTDOWNZ); > > > - ret = readx_poll_timeout(readl, dsi->base + DSI_PHY_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, > val, val & LOCK, 1000, PHY_STATUS_TIMEOUT_US); > if (ret < 0) { > dev_err(dsi->dev, "failed to wait for phy lock state\n"); > return ret; > } > > - ret = readx_poll_timeout(readl, dsi->base + DSI_PHY_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, > val, val & STOP_STATE_CLK_LANE, 1000, > PHY_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -594,7 +594,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > int ret; > u32 val, mask; > > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, !(val & GEN_CMD_FULL), 1000, > CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -605,7 +605,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > dsi_write(dsi, DSI_GEN_HDR, hdr_val); > > mask = GEN_CMD_EMPTY | GEN_PLD_W_EMPTY; > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, (val & mask) == mask, > 1000, CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -664,7 +664,7 @@ static int dw_mipi_dsi_dcs_long_write(struct dw_mipi_dsi *dsi, > len -= pld_data_bytes; > } > > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, !(val & GEN_PLD_W_FULL), 1000, > CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751082AbdAWAuA (ORCPT ); Sun, 22 Jan 2017 19:50:00 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:35264 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbdAWAt7 (ORCPT ); Sun, 22 Jan 2017 19:49:59 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <375becad2e72c4a2581a6a49f55d234c> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 20/26] drm/rockchip: dw-mipi-dsi: use specific poll helper To: John Keeping , Mark Yao References: <20170121163128.22240-1-john@metanate.com> <20170121163128.22240-21-john@metanate.com> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Chris Zhong Message-ID: <58855312.7020207@rock-chips.com> Date: Mon, 23 Jan 2017 08:49:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20170121163128.22240-21-john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Chris Zhong On 01/22/2017 12:31 AM, John Keeping wrote: > As the documentation for readx_poll_timeout says, we want to use the > specialized macro for readl rather than using the generic version > directly. > > Signed-off-by: John Keeping > --- > Unchanged in v2 > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index f2320cf1366c..3e19693ae59b 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -471,14 +471,14 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi *dsi) > PHY_UNRSTZ | PHY_UNSHUTDOWNZ); > > > - ret = readx_poll_timeout(readl, dsi->base + DSI_PHY_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, > val, val & LOCK, 1000, PHY_STATUS_TIMEOUT_US); > if (ret < 0) { > dev_err(dsi->dev, "failed to wait for phy lock state\n"); > return ret; > } > > - ret = readx_poll_timeout(readl, dsi->base + DSI_PHY_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_PHY_STATUS, > val, val & STOP_STATE_CLK_LANE, 1000, > PHY_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -594,7 +594,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > int ret; > u32 val, mask; > > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, !(val & GEN_CMD_FULL), 1000, > CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -605,7 +605,7 @@ static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > dsi_write(dsi, DSI_GEN_HDR, hdr_val); > > mask = GEN_CMD_EMPTY | GEN_PLD_W_EMPTY; > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, (val & mask) == mask, > 1000, CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) { > @@ -664,7 +664,7 @@ static int dw_mipi_dsi_dcs_long_write(struct dw_mipi_dsi *dsi, > len -= pld_data_bytes; > } > > - ret = readx_poll_timeout(readl, dsi->base + DSI_CMD_PKT_STATUS, > + ret = readl_poll_timeout(dsi->base + DSI_CMD_PKT_STATUS, > val, !(val & GEN_PLD_W_FULL), 1000, > CMD_PKT_STATUS_TIMEOUT_US); > if (ret < 0) {