From: Rajendra Nayak <rnayak@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
sricharan@codeaurora.org
Subject: Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable
Date: Mon, 23 Jan 2017 09:33:10 +0530 [thread overview]
Message-ID: <5885807E.7040500@codeaurora.org> (raw)
In-Reply-To: <20170120232049.GB20800@codeaurora.org>
On 01/21/2017 04:50 AM, Stephen Boyd wrote:
> On 01/10, Stanimir Varbanov wrote:
>>
>>> + udelay(1);
>>> +
>>> + reg = sc->gds_hw_ctrl ? sc->gds_hw_ctrl : sc->gdscr;
>>> + ret = gdsc_poll_status(sc, reg, 0);
>>
>> This should be gdsc_poll_status(sc, reg, true) because after disabling
>> hw_control we expect that the GDSC is in power_on state.
>>
>>> + if (ret)
>>> + return ret;
>>> }
>>>
>>> if (sc->pwrsts & PWRSTS_OFF)
>>>
>
> I expect this patch is going for v2?
Yes, sorry, coming up shortly.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2017-01-23 4:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 5:54 [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable Rajendra Nayak
2017-01-10 9:31 ` Stanimir Varbanov
2017-01-20 23:20 ` Stephen Boyd
2017-01-23 4:03 ` Rajendra Nayak [this message]
2017-01-23 4:06 ` Rajendra Nayak
2017-01-10 16:43 ` Stanimir Varbanov
2017-01-10 19:29 ` Sricharan
2017-01-10 19:29 ` Sricharan
2017-01-11 8:55 ` Stanimir Varbanov
2017-01-12 8:47 ` Sricharan
2017-01-12 8:47 ` Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5885807E.7040500@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.