From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "build: Always build the libfdt python module"
Date: Mon, 23 Jan 2017 13:57:13 +0100 [thread overview]
Message-ID: <5885FDA9.5000002@denx.de> (raw)
In-Reply-To: <20170123123750.791-1-sjg@chromium.org>
Hello Simon,
Am 23.01.2017 um 13:37 schrieb Simon Glass:
> This appears to cause problems with powerpc:
>
> +x86_64-linux-gnu-gcc: error: unrecognized command line option ?-melf32ppclinux?
> +error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
> +make[2]: *** [tools/_libfdt.so] Error 1
> +make[1]: *** [tools] Error 2
> +make: *** [sub-make] Error 2
>
> It may need to be made ARM-specific.
>
> This reverts commit 1905c8fc711a527ff10550425498bc77e4db9ac3.
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> tools/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Yup, I posted this issue exactly today ...
Reviewed-by: Heiko Schocher <hs@denx.de>
Tested on the tqm5200 board, so:
Tested-by: Heiko Schocher <hs@denx.de>
> diff --git a/tools/Makefile b/tools/Makefile
> index a609d058595..5b81dde4b06 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -111,7 +111,7 @@ fit_check_sign-objs := $(dumpimage-mkimage-objs) fit_check_sign.o
>
> # Build a libfdt Python module if swig is available
> # Use 'sudo apt-get install swig libpython-dev' to enable this
> -hostprogs-y += \
> +hostprogs-$(CONFIG_SPL_OF_PLATDATA) += \
> $(if $(shell which swig 2> /dev/null),_libfdt.so)
> _libfdt.so-sharedobjs += $(LIBFDT_OBJS)
> libfdt:
>
Why do we need this at all?
Fedora for example has no "libpython-dev" ... So at least the
"if" should check for "libpython-dev" too...
# dnf install libpython-dev Last metadata expiration check: 1:50:58 ago on Mon Jan 23 07:49:26 2017.
No package libpython-dev available.
Error: Unable to find a match.
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2017-01-23 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 12:37 [U-Boot] [PATCH] Revert "build: Always build the libfdt python module" Simon Glass
2017-01-23 12:56 ` Emmanuel Vadot
2017-01-23 13:41 ` Tom Rini
2017-01-23 12:57 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5885FDA9.5000002@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.