From: Murali Karicheri <m-karicheri2@ti.com>
To: "open list:TI NETCP ETHERNET DRIVER" <netdev@vger.kernel.org>
Subject: iproute2: using .maxattr = IFLA_VLAN_MAX??
Date: Mon, 23 Jan 2017 12:44:53 -0500 [thread overview]
Message-ID: <58864115.4060608@ti.com> (raw)
Hi iproute2 experts,
Found the below usage of IFLA_VLAN_MAX in ip/iplink_hsr.c
struct link_util hsr_link_util = {
.id = "hsr",
.maxattr = IFLA_VLAN_MAX, <==== should be IFLA_HSR_MAX
.parse_opt = hsr_parse_opt,
.print_opt = hsr_print_opt,
.print_help = hsr_print_help,
};
This appears to be a cut-n-paste bug as the source is based on
ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX. If yes,
I will send a patch for this.
Thanks.
--
Murali Karicheri
Linux Kernel, Keystone
next reply other threads:[~2017-01-23 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 17:44 Murali Karicheri [this message]
2017-01-23 20:45 ` iproute2: using .maxattr = IFLA_VLAN_MAX?? Rosen, Rami
2017-01-26 16:27 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58864115.4060608@ti.com \
--to=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.