From: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] ltp-aiodio/dio_sparse: Fix usleep in read_sparse()
Date: Wed, 25 Jan 2017 12:02:50 +0800 [thread overview]
Message-ID: <5888236A.1010702@cn.fujitsu.com> (raw)
In-Reply-To: <20170124134351.GD29054@rei.lan>
Hi Cyril,
Thanks for your review.
On 01/24/2017 09:43 PM, Cyril Hrubis wrote:
> Hi!
>> diff --git a/testcases/kernel/io/ltp-aiodio/common_sparse.h b/testcases/kernel/io/ltp-aiodio/common_sparse.h
>> index f7f4ef4..a7f5035 100644
>> --- a/testcases/kernel/io/ltp-aiodio/common_sparse.h
>> +++ b/testcases/kernel/io/ltp-aiodio/common_sparse.h
>> @@ -123,7 +123,7 @@ static void read_sparse(char *filename, int filesize)
>> fprintf(stderr, "Child %i waits for '%s' to appear\n",
>> getpid(), filename);
>>
>> - usleep(100000);
>> + usleep(10);
>
> Isn't 10us too small? Also we really should increase the number of the
> loop iterations if we reduce the sleep as much.
>
Most of the time child works well by usleep(100), but there is still
a small chance that it misses the test on my system...
OK, I will also increase the loop number and send a V2.
Thanks.
Best Regards,
Guangwen Feng
>> }
>>
>> if (fd == -1) {
>> --
>> 1.8.4.2
>>
>>
>>
>>
>> --
>> Mailing list info: https://lists.linux.it/listinfo/ltp
>
next prev parent reply other threads:[~2017-01-25 4:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 9:32 [LTP] [PATCH 1/2] ltp-aiodio/dio_sparse: Fix write in dio_sparse() Guangwen Feng
2017-01-19 9:32 ` [LTP] [PATCH 2/2] ltp-aiodio/dio_sparse: Fix usleep in read_sparse() Guangwen Feng
2017-01-24 13:43 ` Cyril Hrubis
2017-01-25 4:02 ` Guangwen Feng [this message]
2017-02-09 7:23 ` [LTP] [PATCH v2] " Guangwen Feng
2017-02-09 9:35 ` Cyril Hrubis
2017-02-14 3:20 ` Guangwen Feng
2017-03-21 8:08 ` [LTP] [PATCH] ltp-aiodio: Create the file before fork Guangwen Feng
2017-03-22 15:33 ` Cyril Hrubis
2017-01-24 13:40 ` [LTP] [PATCH 1/2] ltp-aiodio/dio_sparse: Fix write in dio_sparse() Cyril Hrubis
2017-01-25 4:33 ` Guangwen Feng
2017-02-09 8:56 ` Guangwen Feng
2017-02-09 9:31 ` Cyril Hrubis
2017-02-14 8:53 ` Guangwen Feng
2017-02-16 13:12 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5888236A.1010702@cn.fujitsu.com \
--to=fenggw-fnst@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.