From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752646AbdAZCqQ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Jan 2017 21:46:16 -0500
Received: from prod-mail-xrelay07.akamai.com ([23.79.238.175]:23418 "EHLO
        prod-mail-xrelay07.akamai.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752453AbdAZCqP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Jan 2017 21:46:15 -0500
Subject: Re: [PATCH] perf probe: Ignore vmlinux build-id when offline vmlinux
 and dry-run used
To: Masami Hiramatsu <mhiramat@kernel.org>
References: <1485294088-17361-1-git-send-email-johunt@akamai.com>
 <20170126113743.2abec2b978377e31a450334b@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-kernel@vger.kernel.org, bgregg@netflix.com
From: Josh Hunt <johunt@akamai.com>
Message-ID: <588962F2.3090208@akamai.com>
Date: Wed, 25 Jan 2017 20:46:10 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20170126113743.2abec2b978377e31a450334b@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/25/2017 08:37 PM, Masami Hiramatsu wrote:
> On Tue, 24 Jan 2017 16:41:28 -0500
> Josh Hunt <johunt@akamai.com> wrote:
>
>> Commit e50243bb ("perf probe: Ignore vmlinux Build-id when offline vmlinux given")
>> added the ability to ignore vmlinux when an offline vmlinux is passed and no
>> l, d, or a flag is also passed. This extends that to ignore build-id when
>> -n/--dry-run is used. This way we can gather probe information for offline kernels
>> using the method Brendan Gregg mentions in this post:
>> http://www.brendangregg.com/blog/2014-09-11/perf-kernel-line-tracing.html .
>
> Sorry, NAK.
> Could you use -D (--definition) for that usage? It directly gives you
> the definition on stdout, and also ignore the buildid.

Ahhh! I guess I totally missed the point of that flag. You're right. It 
works exactly the way I want :)

Thanks. Please ignore my patch.

Josh