From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v2 4/4] phy: qcom-ufs: Suppress extraneous logging Date: Thu, 26 Jan 2017 20:56:49 +0530 Message-ID: <588A1539.8020901@ti.com> References: <20170122211749.22803-1-bjorn.andersson@linaro.org> <20170122211749.22803-4-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from lelnx193.ext.ti.com ([198.47.27.77]:30346 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbdAZP0x (ORCPT ); Thu, 26 Jan 2017 10:26:53 -0500 In-Reply-To: <20170122211749.22803-4-bjorn.andersson@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org On Monday 23 January 2017 02:47 AM, Bjorn Andersson wrote: > The error paths of the common qcom-ufs functions for registering the > phy, acquiring clocks and acquiring regulators all print specific error > messages before returning an error, so there is no value in printing yet > another - more generic - message when this occur. > > Reviewed-by: Vivek Gautam > Reviewed-by: Subhash Jadavani > Signed-off-by: Bjorn Andersson merged the series, thanks. -Kishon > --- > > Changes since v1: > - Picked up reviewed-bys from Vivek and Subhash > > drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++------------ > drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++---------- > 2 files changed, 5 insertions(+), 22 deletions(-) > > diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c > index c71c84734916..12a1b498dc4b 100644 > --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c > +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c > @@ -132,27 +132,18 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev) > &ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops); > > if (!generic_phy) { > - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", > - __func__); > err = -EIO; > goto out; > } > > err = ufs_qcom_phy_init_clks(phy_common); > - if (err) { > - dev_err(phy_common->dev, > - "%s: ufs_qcom_phy_init_clks() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > err = ufs_qcom_phy_init_vregulators(phy_common); > - if (err) { > - dev_err(phy_common->dev, > - "%s: ufs_qcom_phy_init_vregulators() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > + > phy_common->vdda_phy.max_uV = UFS_PHY_VDDA_PHY_UV; > phy_common->vdda_phy.min_uV = UFS_PHY_VDDA_PHY_UV; > > diff --git a/drivers/phy/phy-qcom-ufs-qmp-20nm.c b/drivers/phy/phy-qcom-ufs-qmp-20nm.c > index 1a26a64e06d3..4f68acb58b73 100644 > --- a/drivers/phy/phy-qcom-ufs-qmp-20nm.c > +++ b/drivers/phy/phy-qcom-ufs-qmp-20nm.c > @@ -190,25 +190,17 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct platform_device *pdev) > &ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops); > > if (!generic_phy) { > - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", > - __func__); > err = -EIO; > goto out; > } > > err = ufs_qcom_phy_init_clks(phy_common); > - if (err) { > - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_clks() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > err = ufs_qcom_phy_init_vregulators(phy_common); > - if (err) { > - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_vregulators() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > ufs_qcom_phy_qmp_20nm_advertise_quirks(phy_common); > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753446AbdAZP0y (ORCPT ); Thu, 26 Jan 2017 10:26:54 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:30346 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbdAZP0x (ORCPT ); Thu, 26 Jan 2017 10:26:53 -0500 Subject: Re: [PATCH v2 4/4] phy: qcom-ufs: Suppress extraneous logging To: Bjorn Andersson References: <20170122211749.22803-1-bjorn.andersson@linaro.org> <20170122211749.22803-4-bjorn.andersson@linaro.org> CC: , From: Kishon Vijay Abraham I Message-ID: <588A1539.8020901@ti.com> Date: Thu, 26 Jan 2017 20:56:49 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20170122211749.22803-4-bjorn.andersson@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 23 January 2017 02:47 AM, Bjorn Andersson wrote: > The error paths of the common qcom-ufs functions for registering the > phy, acquiring clocks and acquiring regulators all print specific error > messages before returning an error, so there is no value in printing yet > another - more generic - message when this occur. > > Reviewed-by: Vivek Gautam > Reviewed-by: Subhash Jadavani > Signed-off-by: Bjorn Andersson merged the series, thanks. -Kishon > --- > > Changes since v1: > - Picked up reviewed-bys from Vivek and Subhash > > drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++------------ > drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++---------- > 2 files changed, 5 insertions(+), 22 deletions(-) > > diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c > index c71c84734916..12a1b498dc4b 100644 > --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c > +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c > @@ -132,27 +132,18 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev) > &ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops); > > if (!generic_phy) { > - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", > - __func__); > err = -EIO; > goto out; > } > > err = ufs_qcom_phy_init_clks(phy_common); > - if (err) { > - dev_err(phy_common->dev, > - "%s: ufs_qcom_phy_init_clks() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > err = ufs_qcom_phy_init_vregulators(phy_common); > - if (err) { > - dev_err(phy_common->dev, > - "%s: ufs_qcom_phy_init_vregulators() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > + > phy_common->vdda_phy.max_uV = UFS_PHY_VDDA_PHY_UV; > phy_common->vdda_phy.min_uV = UFS_PHY_VDDA_PHY_UV; > > diff --git a/drivers/phy/phy-qcom-ufs-qmp-20nm.c b/drivers/phy/phy-qcom-ufs-qmp-20nm.c > index 1a26a64e06d3..4f68acb58b73 100644 > --- a/drivers/phy/phy-qcom-ufs-qmp-20nm.c > +++ b/drivers/phy/phy-qcom-ufs-qmp-20nm.c > @@ -190,25 +190,17 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct platform_device *pdev) > &ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops); > > if (!generic_phy) { > - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n", > - __func__); > err = -EIO; > goto out; > } > > err = ufs_qcom_phy_init_clks(phy_common); > - if (err) { > - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_clks() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > err = ufs_qcom_phy_init_vregulators(phy_common); > - if (err) { > - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_vregulators() failed %d\n", > - __func__, err); > + if (err) > goto out; > - } > > ufs_qcom_phy_qmp_20nm_advertise_quirks(phy_common); > >