From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v2 2/2] PM / devfreq: Add suspend frequency support Date: Tue, 31 Jan 2017 09:33:39 +0900 Message-ID: <588FDB63.2080105@samsung.com> References: <1482926828-19746-1-git-send-email-cw00.choi@samsung.com> <1482926828-19746-3-git-send-email-cw00.choi@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:45198 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753638AbdAaAq0 (ORCPT ); Mon, 30 Jan 2017 19:46:26 -0500 In-reply-to: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: MyungJoo Ham , Kyungmin Park , hl@rock-chips.com, tjakobi@math.uni-bielefeld.de, chanwoo@kernel.org, "Rafael J. Wysocki" , Linux PM list , "linux-kernel@vger.kernel.org" Hi Viresh, On 2017년 01월 30일 13:50, Viresh Kumar wrote: > On Wed, Dec 28, 2016 at 5:37 PM, Chanwoo Choi wrote: >> +++ b/drivers/devfreq/devfreq.c >> @@ -620,6 +620,23 @@ struct devfreq *devfreq_add_device(struct device *dev, >> goto err_init; >> } >> >> + /* >> + * Get the suspend frequency from OPP table. But the devfreq device >> + * using passive governor don't need to get the suspend frequency >> + * because the passive devfreq device depend on the parent devfreq >> + * device. >> + */ >> + devfreq->suspend_freq = 0L; >> + if (strncmp(devfreq->governor_name, "passive", 7)) { >> + struct dev_pm_opp *opp; >> + >> + rcu_read_lock(); >> + opp = dev_pm_opp_get_suspend_opp(dev); >> + if (opp) >> + devfreq->suspend_freq = dev_pm_opp_get_freq(opp); > > The interface has changed a bit recently. Can you please use below > function instead ? I knew. This patch posted before applying your patch. > > dev_pm_opp_get_suspend_opp_freq() This patch has not yet reviewed by devfreq maintainer. So, I'm just waiting the review. But, this patch is wrong on latest opp patches. I'll fix it and resend it. -- Best Regards, Chanwoo Choi Samsung Electronics