All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jean-Noël AVILA" <jn.avila@free.fr>
To: Brad Smith <brad@comstyle.com>, Collin Funk <collin.funk1@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: Solaris sed
Date: Fri, 13 Jun 2025 22:13:48 +0200	[thread overview]
Message-ID: <5895400.DvuYhMxLoT@cayenne> (raw)
In-Reply-To: <874iwlegmg.fsf@gmail.com>

On Thursday, 12 June 2025 06:19:35 CEST Collin Funk wrote:
> Brad Smith <brad@comstyle.com> writes:

> > No errors or warnings after this is applied.
> 
> Likewise.
> 
> I checked on my Linux machine and both files are the same before and
> after the patch. Before the patch on Solaris 10, the following is
> generated:
> 
>     /* Automatically generated by generate-configlist.sh */
> 
> 
>     static const char *config_name_list[] = {
>             NULL,
>     };
> 
> After the patch the output on Solaris is the same as on Linux.
> 
> So the patch is perfect.
> 
> Reviewed-by: Collin Funk <collin.funk1@gmail.com>
> 
> Collin

Hello, 

Would it be possible to set up some kind of CI to check for compatibility with 
such systems. This is the second time I introduced regressions without even 
knowing it, and it would be really great to catch them before borking a 
release process.

Thanks,

JN




  reply	other threads:[~2025-06-13 20:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12  3:23 Solaris sed Brad Smith
2025-06-12  3:42 ` Collin Funk
2025-06-12  3:49   ` Brad Smith
2025-06-12  4:16     ` Eli Schwartz
2025-06-12  4:25       ` Collin Funk
2025-06-12  4:26       ` Brad Smith
2025-06-12  4:03 ` Junio C Hamano
2025-06-12  4:13   ` Brad Smith
2025-06-12  4:19     ` Collin Funk
2025-06-13 20:13       ` Jean-Noël AVILA [this message]
2025-06-13 20:23         ` Eric Sunshine
2025-06-13 20:30         ` Collin Funk
2025-06-12  5:50   ` Eric Sunshine
2025-06-12 13:35     ` Paul Smith
2025-06-12 16:40       ` Eric Sunshine
  -- strict thread matches above, loose matches on Subject: below --
2025-06-12 22:52 Ben Knoble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5895400.DvuYhMxLoT@cayenne \
    --to=jn.avila@free.fr \
    --cc=brad@comstyle.com \
    --cc=collin.funk1@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.