From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v17 0/7] drm/rockchip: Add CDN DP driver Date: Sun, 5 Feb 2017 16:42:23 +0800 Message-ID: <5896E56F.6020500@rock-chips.com> References: <1486281302-28200-1-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1486281302-28200-1-git-send-email-zyw@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Zhong , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, groeck@chromium.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgQ2hyaXMKCkFwcGxpZWQgdG8gbXkgZHJtLW5leHQgYW5kIGFscmVhZHkgc2VudCBwdWxsIHJl cXVlc3QgdG8gRGF2ZS4KClRoYW5rcy4KCk9uIDIwMTflubQwMuaciDA15pelIDE1OjU0LCBDaHJp cyBaaG9uZyB3cm90ZToKPiBUaGlzIHNlcmllcyBhZGRzIHN1cHBvcnQgZm9yIHRoZSBDRE4gRFAg Y29udHJvbGxlciB0byB0aGUgcm9ja2NoaXAgZHJtCj4gZHJpdmVyLiBUaGlzIHZlcnNpb24gZml4 ZXMgc29tZSBjb2Rpbmcgc3R5bGUgZXJyb3IgaW4gdjE2LCBpdCBwb3N0IGJ5Cj4gU2VhbiBQYXVs LCB5b3UgY2FuIGZpbmQgaXQgaGVyZToKPiAJaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9w YXRjaC85NDQyMTM1Lwo+Cj4gQW5kIEkgc29ydGVkIG91dCBhIGZldyBwYXRjaGVzIHRvIGZpeCB0 aGUgZm9sbG93aW5nIHByb2JsZW1zOgo+IC0gc3VzcGVuZC9yZXN1bWUgY3Jhc2ggY2F1c2UgYnkg ZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50Cj4gLSBjcmFzaCBkdXJpbmcgc2h1dGRvd24gd2hlbiBj ZG4tZHAgZmFpbGVkIHRvIGJpbmQKPiAtIGNoZWNrIHNpbmsgY291bnQgZmFpbGVkIGFmdGVyIHJl Y29ubmVjdGlvbgo+IC0gc3VzcGVuZC9yZXVzbWUgY3Jhc2ggaW4gbW9kZV9zZXQgZnVuY3Rpb24K Pgo+IEkgYWxzbyBhZGRlZCB0aGVzZSAyIHBhdGNoZXMgdG8gdGhpcyBzZXJpZXMsIGFsdGhvdWdo IG5vdGhpbmcgY2hhbmdlZDoKPiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzk0 NDIxNDEvCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85NDQyMTUxLwo+Cj4K PiBDaGFuZ2VzIGluIHYxNzoKPiAtIENvcnJlY3QgdGhlIGNsb2NrIGNoZWNrIGNvbmRpdGlvbgo+ IC0gQ29ycmVjdCB0aGUgY29kaW5nIHN0eWxlCj4gLSBjaGFuZ2UgTEFORV9SRUZfQ1lDIHRvIDB4 ODAwMAo+Cj4gQ2hyaXMgWmhvbmcgKDQpOgo+ICAgIGRybS9yb2NrY2hpcDogY2RuLWRwOiBhZGQg Y2RuIERQIHN1cHBvcnQgZm9yIHJrMzM5OQo+ICAgIGRybS9yb2NrY2hpcDogY2RuLWRwOiBkbyBu b3QgdXNlIGRybV9oZWxwZXJfaHBkX2lycV9ldmVudAo+ICAgIGRybS9yb2NrY2hpcDogY2RuLWRw OiByZXRyeSB0byBjaGVjayBzaW5rIGNvdW50Cj4gICAgZHJtL3JvY2tjaGlwOiBjZG4tZHA6IGRv bid0IGNvbmZpZ3VyZSBoYXJkd2FyZSBpbiBtb2RlX3NldAo+Cj4gR3VlbnRlciBSb2VjayAoMik6 Cj4gICAgZHJtL3JvY2tjaGlwOiBjZG4tZHA6IExvYWQgZmlybXdhcmUgaWYgbm8gbW9uaXRvciBj b25uZWN0ZWQKPiAgICBkcm0vcm9ja2NoaXA6IGNkbi1kcDogRG8gbm90IHJ1biB3b3JrZXIgd2hp bGUgc3VzcGVuZGVkCj4KPiBKZWZmeSBDaGVuICgxKToKPiAgICBkcm0vcm9ja2NoaXA6IGNkbi1k cDogTW92ZSBtdXRleF9pbml0IHRvIHByb2JlCj4KPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9LY29uZmlnICAgICAgICAgICAgfCAgIDEwICsKPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9NYWtlZmlsZSAgICAgICAgICAgfCAgICAyICsKPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9jZG4tZHAtY29yZS5jICAgICAgfCAxMjYwICsrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2Nkbi1kcC1jb3JlLmggICAgICB8ICAxMTIgKysr Cj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvY2RuLWRwLXJlZy5jICAgICAgIHwgIDk3OSAr KysrKysrKysrKysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAt cmVnLmggICAgICAgfCAgNDgzICsrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9yb2NrY2hpcF9kcm1fdm9wLmMgfCAgIDEzICstCj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvcm9ja2NoaXBfZHJtX3ZvcC5oIHwgICAgOSArCj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvcm9ja2NoaXBfdm9wX3JlZy5jIHwgICAgMiArCj4gICA5IGZpbGVzIGNoYW5nZWQsIDI4Njcg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvY2RuLWRwLWNvcmUuYwo+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtY29yZS5oCj4gICBjcmVhdGUgbW9kZSAx MDA2NDQgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2Nkbi1kcC1yZWcuYwo+ICAgY3JlYXRlIG1v ZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtcmVnLmgKPgoKCi0tIArv vK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Sun, 5 Feb 2017 16:42:23 +0800 Subject: [PATCH v17 0/7] drm/rockchip: Add CDN DP driver In-Reply-To: <1486281302-28200-1-git-send-email-zyw@rock-chips.com> References: <1486281302-28200-1-git-send-email-zyw@rock-chips.com> Message-ID: <5896E56F.6020500@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chris Applied to my drm-next and already sent pull request to Dave. Thanks. On 2017?02?05? 15:54, Chris Zhong wrote: > This series adds support for the CDN DP controller to the rockchip drm > driver. This version fixes some coding style error in v16, it post by > Sean Paul, you can find it here: > https://patchwork.kernel.org/patch/9442135/ > > And I sorted out a few patches to fix the following problems: > - suspend/resume crash cause by drm_helper_hpd_irq_event > - crash during shutdown when cdn-dp failed to bind > - check sink count failed after reconnection > - suspend/reusme crash in mode_set function > > I also added these 2 patches to this series, although nothing changed: > https://patchwork.kernel.org/patch/9442141/ > https://patchwork.kernel.org/patch/9442151/ > > > Changes in v17: > - Correct the clock check condition > - Correct the coding style > - change LANE_REF_CYC to 0x8000 > > Chris Zhong (4): > drm/rockchip: cdn-dp: add cdn DP support for rk3399 > drm/rockchip: cdn-dp: do not use drm_helper_hpd_irq_event > drm/rockchip: cdn-dp: retry to check sink count > drm/rockchip: cdn-dp: don't configure hardware in mode_set > > Guenter Roeck (2): > drm/rockchip: cdn-dp: Load firmware if no monitor connected > drm/rockchip: cdn-dp: Do not run worker while suspended > > Jeffy Chen (1): > drm/rockchip: cdn-dp: Move mutex_init to probe > > drivers/gpu/drm/rockchip/Kconfig | 10 + > drivers/gpu/drm/rockchip/Makefile | 2 + > drivers/gpu/drm/rockchip/cdn-dp-core.c | 1260 +++++++++++++++++++++++++++ > drivers/gpu/drm/rockchip/cdn-dp-core.h | 112 +++ > drivers/gpu/drm/rockchip/cdn-dp-reg.c | 979 +++++++++++++++++++++ > drivers/gpu/drm/rockchip/cdn-dp-reg.h | 483 ++++++++++ > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 13 +- > drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 9 + > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 + > 9 files changed, 2867 insertions(+), 3 deletions(-) > create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-core.c > create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-core.h > create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.c > create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.h > -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbdBEImh (ORCPT ); Sun, 5 Feb 2017 03:42:37 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:37724 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbdBEImg (ORCPT ); Sun, 5 Feb 2017 03:42:36 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <423211038048e2f0bfa29a53acdece69> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v17 0/7] drm/rockchip: Add CDN DP driver To: Chris Zhong , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org References: <1486281302-28200-1-git-send-email-zyw@rock-chips.com> Cc: linux-kernel@vger.kernel.org, groeck@chromium.org, seanpaul@chromium.org, Heiko Stuebner , David Airlie , linux-arm-kernel@lists.infradead.org From: Mark yao Message-ID: <5896E56F.6020500@rock-chips.com> Date: Sun, 5 Feb 2017 16:42:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1486281302-28200-1-git-send-email-zyw@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris Applied to my drm-next and already sent pull request to Dave. Thanks. On 2017年02月05日 15:54, Chris Zhong wrote: > This series adds support for the CDN DP controller to the rockchip drm > driver. This version fixes some coding style error in v16, it post by > Sean Paul, you can find it here: > https://patchwork.kernel.org/patch/9442135/ > > And I sorted out a few patches to fix the following problems: > - suspend/resume crash cause by drm_helper_hpd_irq_event > - crash during shutdown when cdn-dp failed to bind > - check sink count failed after reconnection > - suspend/reusme crash in mode_set function > > I also added these 2 patches to this series, although nothing changed: > https://patchwork.kernel.org/patch/9442141/ > https://patchwork.kernel.org/patch/9442151/ > > > Changes in v17: > - Correct the clock check condition > - Correct the coding style > - change LANE_REF_CYC to 0x8000 > > Chris Zhong (4): > drm/rockchip: cdn-dp: add cdn DP support for rk3399 > drm/rockchip: cdn-dp: do not use drm_helper_hpd_irq_event > drm/rockchip: cdn-dp: retry to check sink count > drm/rockchip: cdn-dp: don't configure hardware in mode_set > > Guenter Roeck (2): > drm/rockchip: cdn-dp: Load firmware if no monitor connected > drm/rockchip: cdn-dp: Do not run worker while suspended > > Jeffy Chen (1): > drm/rockchip: cdn-dp: Move mutex_init to probe > > drivers/gpu/drm/rockchip/Kconfig | 10 + > drivers/gpu/drm/rockchip/Makefile | 2 + > drivers/gpu/drm/rockchip/cdn-dp-core.c | 1260 +++++++++++++++++++++++++++ > drivers/gpu/drm/rockchip/cdn-dp-core.h | 112 +++ > drivers/gpu/drm/rockchip/cdn-dp-reg.c | 979 +++++++++++++++++++++ > drivers/gpu/drm/rockchip/cdn-dp-reg.h | 483 ++++++++++ > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 13 +- > drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 9 + > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 + > 9 files changed, 2867 insertions(+), 3 deletions(-) > create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-core.c > create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-core.h > create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.c > create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.h > -- Ｍark Yao