Re: [PATCH] drm/i915: Re-enable aliasing PPGTT mode.

From: Zhi Wang <zhi.a.wang@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Michal Winiarski <michal.winiarski@intel.com>,
	Michel Thierry <michel.thierry@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>,
	Zhiyuan Lv <zhiyuan.lv@intel.com>
Subject: Re: [PATCH] drm/i915: Re-enable aliasing PPGTT mode.
Date: Mon, 06 Feb 2017 18:14:24 +0800	[thread overview]
Message-ID: <58984C80.3090605@intel.com> (raw)
In-Reply-To: <20170206085051.GA29658@nuc-i3427.alporthouse.com>

Yep. Wait a second. :P

On 02/06/17 16:50, Chris Wilson wrote:
> On Mon, Feb 06, 2017 at 04:18:23PM +0800, Zhi Wang wrote:
>> Hi Chris:
>>      Thanks for the reply! :P Have you also fixed here with your new ideas?
>>
>> in intel_lrc:
>>
>> static u64 execlists_update_context(struct drm_i915_gem_request *rq)
>> {
>>          struct intel_context *ce = &rq->ctx->engine[rq->engine->id];
>>          struct i915_hw_ppgtt *ppgtt = rq->ctx->ppgtt;  // ---->
>> check if we should get ppgtt from dev_priv->mm.aliasing_ppgtt.
>
> Oh dear. Yup, that's a bug.
>
> Can you send a ppgtt = rq->ctx->ppgtt ?: &rq->i915->mm.aliasing_ppgtt;
>
> One day we will bite the bullet and set ctx->ppgtt to be the
> aliasing_ppgtt (and maybe even fix it so that we can global_gtt as
> appropriate), and then just fix up the more unusual case in execbuf to
> bind using vm = global_gtt instead (if aliasing).
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx