From: Zhi Wang <zhi.a.wang@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Michal Winiarski <michal.winiarski@intel.com>,
Michel Thierry <michel.thierry@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhiyuan Lv <zhiyuan.lv@intel.com>
Subject: Re: [PATCH] drm/i915: Let execlist_update_context() cover !FULL_PPGTT mode.
Date: Mon, 06 Feb 2017 19:03:39 +0800 [thread overview]
Message-ID: <5898580B.8000001@intel.com> (raw)
In-Reply-To: <20170206105824.GC12434@nuc-i3427.alporthouse.com>
Thanks for the merging. I guess that with your patches of keeping PD
structure under aliasing PPGTT mode in 32bit page table, the amount of
PDPs will not change anymore under aliasing PPGTT mode. :P
On 02/06/17 18:58, Chris Wilson wrote:
> On Mon, Feb 06, 2017 at 06:37:16PM +0800, Zhi Wang wrote:
>> execlist_update_context() will try to update PDPs in a context before a
>> ELSP submission only for full PPGTT mode, while PDPs was populated during
>> context initialization. Now the latter code path is removed. Let
>> execlist_update_context() also cover !FULL_PPGTT mode.
>>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Cc: Michal Winiarski <michal.winiarski@intel.com>
>> Cc: Michel Thierry <michel.thierry@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
>> Cc: Zhiyuan Lv <zhiyuan.lv@intel.com>
>> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
>
> My mistake from earlier missing the aliasing case.
>
> Fixes: 34869776c76b ("drm/i915: check ppgtt validity when init reg state")
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-06 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 10:37 [PATCH] drm/i915: Let execlist_update_context() cover !FULL_PPGTT mode Zhi Wang
2017-02-06 10:58 ` Chris Wilson
2017-02-06 11:03 ` Zhi Wang [this message]
2017-02-06 11:38 ` Chris Wilson
2017-02-07 9:22 ` Zhi Wang
2017-02-07 9:52 ` Chris Wilson
2017-02-06 13:54 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-06 15:18 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5898580B.8000001@intel.com \
--to=zhi.a.wang@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=michal.winiarski@intel.com \
--cc=michel.thierry@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.