All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samudrala, Sridhar <sridhar.samudrala@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [FIXUP PATCH 2/2] fixup! i40e: Add support for exposing VF port statistics via VFPR netdev on the host
Date: Mon, 06 Feb 2017 22:35:07 -0800	[thread overview]
Message-ID: <58996A9B.1060802@intel.com> (raw)
In-Reply-To: <20170206223840.30938-4-jacob.e.keller@intel.com>

On 2/6/2017 2:38 PM, Jacob Keller wrote:
> This fixes a compiler warning in commit abc0e7634722 ("i40e: Add support
> for exposing VF port statistics via VFPR netdev on the host",
> 2017-01-31) which is caused by a function that should have been marked
> as static.
>
> Jeff, please squash this patch into the given commit, or have the
> original author re-roll his patch to fix the warning.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Sridhar Samudrala <sridhar.samudrala@intel.com>

Jeff, Along with this patch, can you also squash this patch into this 
commit to fix percpu related
warning messages.

diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h
index 52ba9d5..7ddce0d 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h
@@ -85,7 +85,7 @@ struct vfpr_pcpu_stats {
  struct i40e_vfpr_netdev_priv {
         struct metadata_dst *vfpr_dst;
         struct i40e_vf *vf;
-       struct vfpr_pcpu_stats *vfpr_stats;
+       struct vfpr_pcpu_stats __percpu *vfpr_stats;
  };

  /* VF information structure */


> ---
>   drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> index 9efecff9c535..2686ddd65618 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> @@ -1062,7 +1062,7 @@ static int i40e_vfpr_netdev_stop(struct net_device *dev)
>    *
>    * Fills the hw statistics from the VSI corresponding to the associated VFPR
>    **/
> -void
> +static void
>   i40e_vfpr_netdev_get_stats64(struct net_device *netdev,
>   			     struct rtnl_link_stats64 *stats)
>   {


  reply	other threads:[~2017-02-07  6:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 22:38 [Intel-wired-lan] [FIXUP PATCH 0/2] fixup patches for warnings in queue Jacob Keller
2017-02-06 22:38 ` [Intel-wired-lan] [FIXUP PATCH 1/2] fixup! i40e: Introduce VF Port Representator(VFPR) netdevs Jacob Keller
2017-02-07  6:30   ` Samudrala, Sridhar
2017-02-06 22:38 ` [Intel-wired-lan] [PATCH 1/1] i40e: document drivers use of ntuple filters Jacob Keller
2017-02-06 22:38 ` [Intel-wired-lan] [FIXUP PATCH 2/2] fixup! i40e: Add support for exposing VF port statistics via VFPR netdev on the host Jacob Keller
2017-02-07  6:35   ` Samudrala, Sridhar [this message]
2017-02-07 17:46     ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58996A9B.1060802@intel.com \
    --to=sridhar.samudrala@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.