From: Heiko Schocher <hs@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: linux-input@vger.kernel.org, Guan Ben <ben.guan@cn.bosch.com>,
Mark Jonas <mark.jonas@de.bosch.com>,
devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Manfred Schlaegl <manfred.schlaegl@gmx.at>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] Input: pwm-beeper: support customized freq for SND_BELL
Date: Mon, 13 Feb 2017 07:12:09 +0100 [thread overview]
Message-ID: <58A14E39.40905@denx.de> (raw)
In-Reply-To: <20170210154833.lefb7m4gnxnvvcxo@rob-hp-laptop>
Hello Rob,
Am 10.02.2017 um 16:48 schrieb Rob Herring:
> On Tue, Feb 07, 2017 at 06:21:34AM +0100, Heiko Schocher wrote:
>> From: Guan Ben <ben.guan@cn.bosch.com>
>>
>> extend the pwm-beeper driver to support customized frequency
>> for SND_BELL from device tree.
>>
>> Signed-off-by: Guan Ben <ben.guan@cn.bosch.com>
>> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
>> [hs@denx.de: adapted to 4.10-rc7]
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>
>> ---
>>
>> .../devicetree/bindings/input/pwm-beeper.txt | 3 ++
>> drivers/input/misc/pwm-beeper.c | 36 ++++++++++++++++------
>> 2 files changed, 30 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt
>> index be332ae..438c6e0 100644
>> --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt
>> +++ b/Documentation/devicetree/bindings/input/pwm-beeper.txt
>> @@ -5,3 +5,6 @@ Registers a PWM device as beeper.
>> Required properties:
>> - compatible: should be "pwm-beeper"
>> - pwms: phandle to the physical PWM device
>> +
>> +optional properties:
>> +- bell-frequency: bell frequency in Hz
>
> Needs a unit suffix:
> bell-frequency-hz or just bell-hz as hz implies frequency.
>
> Or maybe beeper-hz would be more consistant.
Ok, I change it to "beeper-hz". Are this all issues with this patch?
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2017-02-13 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 5:21 [PATCH] Input: pwm-beeper: support customized freq for SND_BELL Heiko Schocher
[not found] ` <1486444894-18321-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2017-02-07 18:13 ` Dmitry Torokhov
2017-02-07 18:13 ` Dmitry Torokhov
2017-02-08 10:11 ` AW: " Jonas Mark (ST-FIR/ENG1)
2017-02-14 4:27 ` Dmitry Torokhov
2017-02-14 5:02 ` Heiko Schocher
2017-02-14 5:02 ` Heiko Schocher
2017-02-10 15:48 ` Rob Herring
2017-02-13 6:12 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58A14E39.40905@denx.de \
--to=hs@denx.de \
--cc=ben.guan@cn.bosch.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred.schlaegl@gmx.at \
--cc=mark.jonas@de.bosch.com \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.