From: Arvid Brodin <arvid.brodin@alten.se>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: "open list:TI NETCP ETHERNET DRIVER" <netdev@vger.kernel.org>
Subject: Re: Linux HSR driver question
Date: Mon, 13 Feb 2017 16:38:58 +0100 [thread overview]
Message-ID: <58A1D312.2030003@alten.se> (raw)
In-Reply-To: <589CD1F5.1060104@ti.com>
On 2017-02-09 21:32, Murali Karicheri wrote:
> Hi Arvid,
>
> While I work to add PRP support to the existing Linux HSR driver, I came across
> a piece of code related to prune node function. The hsr_device.c adds the
> prune timer in hsr_dev_finalize() by calling
>
> add_timer(&hsr->prune_timer);
>
> But it is never restarted in hsr_prune_nodes(). Is that intentional or a bug?
> I tried adding add_timer(&hsr->prune_timer) at the end of hsr_prune_nodes(),
> but then a iperf test stops with no traffic across the hsr interface and it
> never recovers. I have to delete the interface and create it again to recover.
> Is that the reason, it is currently disabled?
>
Hi Murali,
Sorry I don't remember the details here. I do know I tested that a node that had
been unplugged for two minutes was forgotten by the other nodes, so this has
worked at some time in the past, at least. :)
--
Arvid Brodin
Linux Consultant
ALTEN Sweden
next prev parent reply other threads:[~2017-02-13 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 20:32 Linux HSR driver question Murali Karicheri
2017-02-13 15:38 ` Arvid Brodin [this message]
2017-02-13 18:05 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58A1D312.2030003@alten.se \
--to=arvid.brodin@alten.se \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.