From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhoucm1 Subject: Re: [PATCH v2 1/2] drm/amdgpu: fix a potential deadlock in amdgpu_bo_create_restricted() Date: Tue, 14 Feb 2017 10:56:32 +0800 Message-ID: <58A271E0.9090807@amd.com> References: <20170209103337.1522-1-samuel.pitoiset@gmail.com> <3fc6e61c-cc70-7b10-9abb-45a4f22b3909@gmail.com> <7c0ece9f-8983-317b-0eae-adaf535c6d06@gmail.com> <4185541c-a3a4-7681-4539-54c5daddd0ac@gmail.com> <60486a5c-0ac3-675e-86f6-67f67db1213c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <60486a5c-0ac3-675e-86f6-67f67db1213c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?Tmljb2xhaSBIw6Robmxl?= , Samuel Pitoiset , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAyMDE35bm0MDLmnIgxNOaXpSAwMzowMywgTmljb2xhaSBIw6RobmxlIHdyb3RlOgo+IE9u IDEzLjAyLjIwMTcgMTk6NTgsIE5pY29sYWkgSMOkaG5sZSB3cm90ZToKPj4gT24gMTMuMDIuMjAx NyAxOTozOCwgU2FtdWVsIFBpdG9pc2V0IHdyb3RlOgo+Pj4KPj4+Cj4+PiBPbiAwMi8xMy8yMDE3 IDA3OjA5IFBNLCBOaWNvbGFpIEjDpGhubGUgd3JvdGU6Cj4+Pj4gT24gMTMuMDIuMjAxNyAxOTow NCwgTmljb2xhaSBIw6RobmxlIHdyb3RlOgo+Pj4+PiBPbiAxMy4wMi4yMDE3IDE4OjQ5LCBTYW11 ZWwgUGl0b2lzZXQgd3JvdGU6Cj4+Pj4+Pgo+Pj4+Pj4KPj4+Pj4+IE9uIDAyLzEzLzIwMTcgMDU6 MjUgUE0sIE5pY29sYWkgSMOkaG5sZSB3cm90ZToKPj4+Pj4+PiBPbiAwOS4wMi4yMDE3IDExOjMz LCBTYW11ZWwgUGl0b2lzZXQgd3JvdGU6Cj4+Pj4+Pj4+IFdoZW4gdHRtX2JvX2luaXQoKSBmYWls cywgdGhlIHJlc2VydmF0aW9uIG11dGV4IHNob3VsZCBiZSAKPj4+Pj4+Pj4gdW5sb2NrZWQuCj4+ Pj4+Pj4+Cj4+Pj4+Pj4+IEluIGRlYnVnIGJ1aWxkLCB0aGUga2VybmVsIHJlcG9ydGVkICJwb3Nz aWJsZSByZWN1cnNpdmUgbG9ja2luZwo+Pj4+Pj4+PiBkZXRlY3RlZCIgaW4gdGhpcyBjb2RlcGF0 aC4gRm9yIGRlYnVnZ2luZyBwdXJwb3NlcywgSSBhbHNvIGFkZGVkCj4+Pj4+Pj4+IGEgIldBUk5f T04od3dfbXV0ZXhfaXNfbG9ja2VkKCkpIiB3aGVuIHR0bV9ib19pbml0KCkgZmFpbHMgYW5kIHRo ZQo+Pj4+Pj4+PiBtdXRleCB3YXMgbG9ja2VkIGFzIGV4cGVjdGVkLgo+Pj4+Pj4+Pgo+Pj4+Pj4+ PiBUaGlzIHNob3VsZCBmaXggKHJhbmRvbSkgR1BVIGhhbmdzLiBUaGUgZWFzeSB3YXkgdG8gcmVw cm9kdWNlIHRoZQo+Pj4+Pj4+PiBpc3N1ZSBpcyB0byBjaGFuZ2UgdGhlICJTdXBlciBTYW1wbGlu ZyIgb3B0aW9uIGZyb20gMS4wIHRvIDIuMCBpbgo+Pj4+Pj4+PiBIaXRtYW4uIEl0IHdpbGwgY3Jl YXRlIGEgaHVnZSBidWZmZXIsIGV2aWN0IGEgYnVuY2ggb2YgYnVmZmVycwo+Pj4+Pj4+PiAoYXJv dW5kIH41aykgYW5kIGRlYWRsb2NrLgo+Pj4+Pj4+Pgo+Pj4+Pj4+PiBUaGlzIHJlZ3Jlc3Npb24g aGFzIGJlZW4gaW50cm9kdWNlZCBwcmV0dHkgcmVjZW50bHkuCj4+Pj4+Pj4+Cj4+Pj4+Pj4+IHYy OiBvbmx5IHJlbGVhc2UgdGhlIG11dGV4IGlmIHJlc3YgaXMgTlVMTAo+Pj4+Pj4+Pgo+Pj4+Pj4+ PiBGaXhlczogMTJhODUyMjE5NTgzICgiZHJtL2FtZGdwdTogaW1wcm92ZQo+Pj4+Pj4+PiBBTURH UFVfR0VNX0NSRUFURV9WUkFNX0NMRUFSRUQgaGFuZGxpbmcgKHYyKSIpCj4+Pj4+Pj4+IFNpZ25l ZC1vZmYtYnk6IFNhbXVlbCBQaXRvaXNldCA8c2FtdWVsLnBpdG9pc2V0QGdtYWlsLmNvbT4KPj4+ Pj4+Pj4gLS0tCj4+Pj4+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2Jq ZWN0LmMgfCA1ICsrKystCj4+Pj4+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCj4+Pj4+Pj4+Cj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmMKPj4+Pj4+Pj4gYi9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmMKPj4+Pj4+Pj4gaW5kZXggZDFlZjFkMDY0ZGU0 Li41NTYyMzZhMTEyYzEgMTAwNjQ0Cj4+Pj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9vYmplY3QuYwo+Pj4+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfb2JqZWN0LmMKPj4+Pj4+Pj4gQEAgLTQwMyw4ICs0MDMsMTEgQEAgaW50 IGFtZGdwdV9ib19jcmVhdGVfcmVzdHJpY3RlZChzdHJ1Y3QKPj4+Pj4+Pj4gYW1kZ3B1X2Rldmlj ZSAqYWRldiwKPj4+Pj4+Pj4gICAgICAgICAgICAgICZiby0+cGxhY2VtZW50LCBwYWdlX2FsaWdu LCAha2VybmVsLCBOVUxMLAo+Pj4+Pj4+PiAgICAgICAgICAgICAgYWNjX3NpemUsIHNnLCByZXN2 ID8gcmVzdiA6ICZiby0+dGJvLnR0bV9yZXN2LAo+Pj4+Pj4+PiAgICAgICAgICAgICAgJmFtZGdw dV90dG1fYm9fZGVzdHJveSk7Cj4+Pj4+Pj4+IC0gICAgaWYgKHVubGlrZWx5KHIgIT0gMCkpCj4+ Pj4+Pj4+ICsgICAgaWYgKHVubGlrZWx5KHIgIT0gMCkpIHsKPj4+Pj4+Pj4gKyAgICAgICAgaWYg KCFyZXN2KQo+Pj4+Pj4+PiArIHd3X211dGV4X3VubG9jaygmYm8tPnRiby5yZXN2LT5sb2NrKTsK Pj4+Pj4+Pj4gICAgICAgICAgcmV0dXJuIHI7Cj4+Pj4+Pj4+ICsgICAgfQo+Pj4+Pj4+Cj4+Pj4+ Pj4gSSB3YXMgbG9va2luZyBhdCB0aGlzIG15c2VsZiBhIGNvdXBsZSBvZiB3ZWVrcyBiYWNrLCBh bmQgSSdtIHByZXR0eQo+Pj4+Pj4+IHN1cmUKPj4+Pj4+PiBJIGhhZCB0aGlzIGV4YWN0IHNhbWUg cGF0Y2gganVzdCB0byByZWFsaXplIHRoYXQgaXQncyBhY3R1YWxseQo+Pj4+Pj4+IGluY29ycmVj dC4KPj4+Pj4+Pgo+Pj4+Pj4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgdHRtX2JvX2luaXQgd2lsbCBh Y3R1YWxseSBjYWxsIHRoZSBkZXN0cm95Cj4+Pj4+Pj4gZnVuY3Rpb24KPj4+Pj4+PiAoaW4gb3Vy IGNhc2UsIGFtZGdwdV90dG1fYm9fZGVzdHJveSksIHNvIGF0IHRoaXMgcG9pbnQsIGJvIGhhcyBi ZWVuCj4+Pj4+Pj4gZnJlZWQuCj4+Pj4+Pj4KPj4+Pj4+PiBUaGlzIGNvZGUgaXMgYSBodWdlIG1l c3MuIEknbSBzdXJwcmlzZWQgdGhvdWdoOiBoYXZlIHlvdSB2ZXJpZmllZAo+Pj4+Pj4+IHRoYXQK Pj4+Pj4+PiB0aGlzIHBhdGNoIGFjdHVhbGx5IGZpeGVzIGEgaGFuZz8KPj4+Pj4+Cj4+Pj4+PiBZ ZXMsIEkgdHJpcGxlLWNoZWNrZWQuIEkgY2FuJ3QgcmVwcm9kdWNlIHRoZSBoYW5ncyB3aXRoIEhp dG1hbi4KPj4+Pj4KPj4+Pj4gVGhhdCdzIHN1cnByaXNpbmcsIGJ1dCBhIHJlbGllZi4gTWF5YmUg aXQgdGllcyBpbnRvIHNvbWUgb2YgdGhlIG90aGVyCj4+Pj4+IHByb2JsZW1zIEknbSBzZWVpbmcg YXMgd2VsbC4KPj4+Pj4KPj4+Pj4gVGhpcyBtZWFucyB3ZSBuZWVkIGEgcmVhbCBmaXggZm9yIHRo aXM7IEkgc3RpbGwgdGhpbmsgdGhlIGN1cnJlbnQgCj4+Pj4+IHBhdGNoCj4+Pj4+IGlzIGJyb2tl bi4KPj4+Pj4KPj4+Pj4KPj4+Pj4+IFRoaXMgZml4ZXMgYSBkZWFkbG9jaywgaGVyZSdzIHRoZSBy ZXBvcnQ6Cj4+Pj4+PiBodHRwczovL2hhc3RlYmluLmNvbS9kdXJvZGl2b21hLnhtbAo+Pj4+Pj4K Pj4+Pj4+IFRoZSByZXN2LT5sb2NrIGhhcyB0byBiZSB1bmxvY2tlZCB3aGVuIHR0bV9ib19pbml0 KCkgZmFpbHMgKEkgCj4+Pj4+PiBjaGVja2VkCj4+Pj4+PiB3aXRoIGEgV0FSTl9PTihpc19sb2Nr ZWQpKSBiZWNhdXNlIGl0IGRvZXNuJ3QgY2FsbCB0aGUgZGVzdHJveQo+Pj4+Pj4gZnVuY3Rpb24K Pj4+Pj4+IGluIGFsbCBzaXR1YXRpb25zLiBQcmVzdW1hYmx5LCB3aGVuIGRybV92bWFfb2Zmc2V0 X2FkZCgpIGZhaWxzIGFuZAo+Pj4+Pj4gcmVzdgo+Pj4+Pj4gaXMgbm90IE5VTEwsIHRoZSBtdXRl eCBpcyBub3QgdW5sb2NrZWQuCj4+Pj4+Cj4+Pj4+IE9uIHdoaWNoIGNvZGUgcGF0aCBpcyB0aGUg ZGVzdHJveSBmdW5jdGlvbiBub3QgY2FsbGVkPyBJZiB0aGF0IGlzIHRoZQo+Pj4+PiBjYXNlLCB3 ZSdyZSBsZWFraW5nIG1lbW9yeS4KPj4+Pj4KPj4+Pj4gV2l0aCB0aGUgcGF0Y2ggYXMtaXMsIHRo ZSBlcnJvciBwYXRocyBhcmUgZWl0aGVyIGxlYWtpbmcgbWVtb3J5IChpZgo+Pj4+PiB5b3UncmUg cmlnaHQpIG9yIGFjY2Vzc2luZyBtZW1vcnkgYWZ0ZXIgaXQncyBmcmVlZCAob3RoZXJ3aXNlKS4K Pj4+Pj4gT2J2aW91c2x5LCBuZWl0aGVyIGlzIGdvb2QuCj4+Pj4KPj4+PiBBY3R1YWxseSwgSSBm aW5kIGl0IGV4dHJlbWVseSBzdXNwaWNpb3VzIHRoYXQgdGhpcyBwYXRjaCByZXNvbHZlcyAKPj4+ PiBoYW5ncy4KPj4+PiBCeSBhbGwgcmlnaHRzLCBubyBvdGhlciB0YXNrIHNob3VsZCBoYXZlIGEg cG9pbnRlciB0byB0aGlzIGJvIGxlZnQuIEl0Cj4+Pj4gcG9pbnRzIGF0IHByb2JsZW1zIGVsc2V3 aGVyZSBpbiB0aGUgY29kZSwgcG9zc2libHkgdGhlIHByZWNpc2UgcHJvYmxlbQo+Pj4+IEkndmUg YmVlbiB0cnlpbmcgdG8gdHJhY2sgZG93bi4KPj4+Cj4+PiBXZWxsLCBtYXliZSB3ZSBhcmUganVz dCBsdWNreSBidXQgYXMgSSBzYWlkLCBJIGNoZWNrZWQgbWFueSB0aW1lcyB0bwo+Pj4gcmVwcm9k dWNlIHRoZSBpc3N1ZSB3aXRoIHRoYXQgcGF0Y2ggYXBwbGllZCB3aXRob3V0IGFueSBzdWNjZXNz LCB5b3UgCj4+PiBjYW4KPj4+IHRydXN0IG1lLiBBbHRob3VnaCBJJ20gYWxzbyBzdGFydGluZyB0 byB0aGluayB0aGF0J3Mgbm90IHRoZSByaWdodAo+Pj4gc29sdXRpb24gKGFuZCBjb3VsZCBpbnRy b2R1Y2Ugb3RoZXIgb25lcykuCj4+Pgo+Pj4+Cj4+Pj4gQ291bGQgeW91IHBsZWFzZSByZXZlcnQg dGhlIHBhdGNoLCByZXByb2R1Y2UgdGhlIGhhbmcsIGFuZCByZXBvcnQKPj4+PiAvcHJvYy8kcGlk L3N0YWNrIGZvciBhbGwgdGhlIGh1bmcgdGFza3M/Cj4+Pgo+Pj4gU3VyZS4gVGhlIHRoaW5nIGlz OiBIaXRtYW4ncyBicmFuY2ggaGFzIGJlZW4gdXBkYXRlZCBkdXJpbmcgdGhlIHdlZWtlbmQKPj4+ IGFuZCBteSBsb2NhbCBpbnN0YWxsYXRpb24gaXMgYnJva2VuLiBJIG5lZWQgdG8gcmUtZG93bmxv YWQgdGhlIHdob2xlCj4+PiBnYW1lICh3aWxsIHRha2UgYSB3aGlsZSkuCj4+Pgo+Pj4gSSB3aWxs IGxldCB5b3Uga25vdyB3aGVuIEknbSBhYmxlIHRvIGdyYWIgdGhhdCByZXBvcnQuCj4+Cj4+IEht bSwgc28gSSB0aG91Z2h0IGFib3V0IHRoaXMgc29tZSBtb3JlLCBhbmQgSSdtIG5vIGxvbmdlciBz byBzdXJlIHRoYXQKPj4geW91ciBidWcgYW5kIG1pbmUgYXJlIHRoZSBzYW1lLiBJZiBpdCB3YXMg cmVsYXRlZCwgSSdkIHNvbWVob3cgZXhwZWN0Cj4+IHlvdSB0byBnZXQgYW4gZXJyb3IgYWJvdXQg YSBtdXRleCBiZWluZyBkZXN0cm95ZWQgd2hpbGUgaXQncyBoZWxkIChhdAo+PiBsZWFzdCB3aXRo IGxvY2sgZGVidWdnaW5nIGVuYWJsZWQpLgo+Pgo+PiBBbnl3YXkuLi4gd2UgbmVlZCB0byBjaGFu Z2UgdGhlIGNvbnRyYWN0IG9mIHR0bV9ib19pbml0LCBJJ20ganVzdCBub3QKPj4geWV0IHN1cmUg aG93LCBiZWNhdXNlIHRoZXJlIGFyZSB0d28gcG9pbnRzIG9mIGZhaWx1cmU6IG9uZSBxdWl0ZSBl YXJseQo+PiBvbiwgYW5kIHRoZSBzZWNvbmQgcmF0aGVyIGxhdGUgd2hpY2ggZ2V0cyBjbGVhbmVk IHVwIGJ5IHR0bV9ib191bnJlZi4KPgo+IE1heWJlIGl0IHdvdWxkIGFjdHVhbGx5IGJlIGJlc3Qg dG8gc3BsaXQgdHRtX2JvX2luaXQgaW50byB0d28gcGFydHM6IAo+IHRoZSBpbml0aWFsIGJ1bGsg b2Ygc3RydWN0dXJlIGluaXRpYWxpemF0aW9uIGFzIHRoZSBmaXJzdCBoYWxmLCBhbmQgCj4gdGhl IHR0bV9ib192YWxpZGF0ZSBpbiB0aGUgc2Vjb25kIGhhbGYuCkFncmVlZC4gSGF2ZSB5b3UgZ29u ZSBhaGVhZCB3aXRoIHlvdXIgcHJvcG9zYWw/CkFsdGhvdWdoIFNhbXVlbCdzIHBhdGNoIGlzbid0 IGJlc3Qgd2F5LCBpdCBpbmRlZWQgZml4IGEgT0NMIGJ1ZyB3aGljaCBpcyAKdHJ5aW5nIHRvIGFs bG9jYXRlIG11bHRpcGxlIGJpZyBidWZmZXJzLgoKVGhhbmtzLApEYXZpZCBaaG91Cj4KPiBDaGVl cnMsCj4gTmljb2xhaQo+Cj4+Cj4+IENoZWVycywKPj4gTmljb2xhaQo+Pgo+Pj4gVGhhbmtzIE5p Y29sYWkuCj4+Pj4KPj4+PiBUaGFua3MsCj4+Pj4gTmljb2xhaQo+Pgo+Cj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBhbWQtZ2Z4IG1haWxpbmcgbGlz dAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2FtZC1nZngK