From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org, paulus@samba.org,
lsorense@csclub.uwaterloo.ca, oohall@gmail.com,
naveen.n.rao@linux.vnet.ibm.com, ast@kernel.org,
chris@distroguy.com, aneesh.kumar@linux.vnet.ibm.com,
bsingharora@gmail.com, anton@samba.org,
paul.gortmaker@windriver.com, bauerman@linux.vnet.ibm.com,
viro@zeniv.linux.org.uk, christophe.leroy@c-s.fr, duwe@lst.de,
oss@buserror.net,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 2/2] powerpc: emulate_step tests for load/store instructions
Date: Tue, 14 Feb 2017 17:08:10 +0530 [thread overview]
Message-ID: <58A2EC22.8080209@linux.vnet.ibm.com> (raw)
In-Reply-To: <877f4tm4n2.fsf@concordia.ellerman.id.au>
On Tuesday 14 February 2017 04:16 PM, Michael Ellerman wrote:
> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> writes:
>
>> diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile
>> index 0e649d7..ddc879d 100644
>> --- a/arch/powerpc/lib/Makefile
>> +++ b/arch/powerpc/lib/Makefile
>> @@ -33,3 +33,7 @@ obj-$(CONFIG_ALTIVEC) += xor_vmx.o
>> CFLAGS_xor_vmx.o += -maltivec $(call cc-option,-mabi=altivec)
>>
>> obj-$(CONFIG_PPC64) += $(obj64-y)
>> +
>> +ifeq ($(CONFIG_PPC64), y)
>> +obj-$(CONFIG_KPROBES_SANITY_TEST) += test_emulate_step.o
>> +endif
> FYI, the right way to do that is:
>
> obj64-$(CONFIG_KPROBES_SANITY_TEST) += test_emulate_step.o
> obj-$(CONFIG_PPC64) += $(obj64-y)
>
> And in this Makefile you don't need to add the second line because it's
> already there.
Thanks for this. Will change accordingly and send next version.
Ravi
>
> cheers
>
prev parent reply other threads:[~2017-02-14 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 9:16 [PATCH v3 0/2] powerpc: Emulation support for load/store instructions on LE Ravi Bangoria
2017-02-14 9:16 ` [PATCH v3 1/2] " Ravi Bangoria
2017-02-14 10:20 ` Michael Ellerman
2017-02-14 11:35 ` Ravi Bangoria
2017-03-08 7:25 ` [v3, " Michael Ellerman
2017-02-14 9:16 ` [PATCH v3 2/2] powerpc: emulate_step tests for load/store instructions Ravi Bangoria
2017-02-14 10:41 ` Michael Ellerman
2017-02-14 10:46 ` Michael Ellerman
2017-02-14 11:38 ` Ravi Bangoria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58A2EC22.8080209@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=ast@kernel.org \
--cc=bauerman@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=chris@distroguy.com \
--cc=christophe.leroy@c-s.fr \
--cc=duwe@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=oohall@gmail.com \
--cc=oss@buserror.net \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.