From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: add extcon dependency for DP Date: Wed, 15 Feb 2017 09:06:15 +0800 Message-ID: <58A3A987.9020001@rock-chips.com> References: <20170214213215.2888509-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann , David Airlie Cc: Tobias Jakobi , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Zhong , Guenter Roeck , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxN+W5tDAy5pyIMTXml6UgMDU6MzEsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gVGhlIG5l d2x5IGFkZGVkIERQIGRyaXZlciBsaW5rcyBhZ2FpbnN0IHRoZSBleHRjb24gY29yZSwgd2hpY2gg ZmFpbHMgd2hlbgo+IGV4dGNvbiBpcyBhIG1vZHVsZSBhbmQgdGhpcyBkcml2ZXIgaXMgbm90Ogo+ Cj4gZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2Nkbi1kcC1jb3JlLm86IEluIGZ1bmN0aW9uIGBj ZG5fZHBfZ2V0X3BvcnRfbGFuZXMnOgo+IGNkbi1kcC1jb3JlLmM6KC50ZXh0LmNkbl9kcF9nZXRf cG9ydF9sYW5lcysweDI0KTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgZXh0Y29uX2dldF9zdGF0 ZScKPiBjZG4tZHAtY29yZS5jOigudGV4dC5jZG5fZHBfZ2V0X3BvcnRfbGFuZXMrMHg0NCk6IHVu ZGVmaW5lZCByZWZlcmVuY2UgdG8gYGV4dGNvbl9nZXRfcHJvcGVydHknCj4KPiBMZXQncyBtYWtl IEtjb25maWcgZW5mb3JjZSBjb3JyZWN0IGJlaGF2aW9yIHdpdGggYSBkZXBlbmRlbmN5LgoKVGhh bmtzIGZvciB0aGUgZml4LgoKQXBwbGllZCB0byBteSBkcm0tbmV4dC4KCj4gRml4ZXM6IDFhMGY3 ZWQzYWJlMiAoImRybS9yb2NrY2hpcDogY2RuLWRwOiBhZGQgY2RuIERQIHN1cHBvcnQgZm9yIHJr MzM5OSIpCj4gU2lnbmVkLW9mZi1ieTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPiAt LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnIHwgMSArCj4gICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v cm9ja2NoaXAvS2NvbmZpZyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnCj4gaW5k ZXggYWQzMWIzZWI0MDhmLi4wZTRlYjg0NWNiYjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL0tjb25maWcKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvS2Nv bmZpZwo+IEBAIC0yNCw2ICsyNCw3IEBAIGNvbmZpZyBST0NLQ0hJUF9BTkFMT0dJWF9EUAo+ICAg Y29uZmlnIFJPQ0tDSElQX0NETl9EUAo+ICAgICAgICAgICB0cmlzdGF0ZSAiUm9ja2NoaXAgY2Ru IERQIgo+ICAgICAgICAgICBkZXBlbmRzIG9uIERSTV9ST0NLQ0hJUAo+ICsJZGVwZW5kcyBvbiBF WFRDT04KPiAgIAlzZWxlY3QgU05EX1NPQ19IRE1JX0NPREVDIGlmIFNORF9TT0MKPiAgICAgICAg ICAgaGVscAo+ICAgCSAgVGhpcyBzZWxlY3RzIHN1cHBvcnQgZm9yIFJvY2tjaGlwIFNvQyBzcGVj aWZpYyBleHRlbnNpb25zCgoKLS0gCu+8rWFyayBZYW8KCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Wed, 15 Feb 2017 09:06:15 +0800 Subject: [PATCH] drm/rockchip: add extcon dependency for DP In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de> References: <20170214213215.2888509-1-arnd@arndb.de> Message-ID: <58A3A987.9020001@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2017?02?15? 05:31, Arnd Bergmann wrote: > The newly added DP driver links against the extcon core, which fails when > extcon is a module and this driver is not: > > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state' > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property' > > Let's make Kconfig enforce correct behavior with a dependency. Thanks for the fix. Applied to my drm-next. > Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index ad31b3eb408f..0e4eb845cbb0 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP > config ROCKCHIP_CDN_DP > tristate "Rockchip cdn DP" > depends on DRM_ROCKCHIP > + depends on EXTCON > select SND_SOC_HDMI_CODEC if SND_SOC > help > This selects support for Rockchip SoC specific extensions -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751647AbdBOBGs (ORCPT ); Tue, 14 Feb 2017 20:06:48 -0500 Received: from regular1.263xmail.com ([211.150.99.135]:50159 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbdBOBGq (ORCPT ); Tue, 14 Feb 2017 20:06:46 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: add extcon dependency for DP To: Arnd Bergmann , David Airlie References: <20170214213215.2888509-1-arnd@arndb.de> Cc: Sean Paul , Guenter Roeck , Heiko Stuebner , Daniel Vetter , Philipp Zabel , Chris Zhong , Tobias Jakobi , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <58A3A987.9020001@rock-chips.com> Date: Wed, 15 Feb 2017 09:06:15 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年02月15日 05:31, Arnd Bergmann wrote: > The newly added DP driver links against the extcon core, which fails when > extcon is a module and this driver is not: > > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state' > cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property' > > Let's make Kconfig enforce correct behavior with a dependency. Thanks for the fix. Applied to my drm-next. > Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index ad31b3eb408f..0e4eb845cbb0 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP > config ROCKCHIP_CDN_DP > tristate "Rockchip cdn DP" > depends on DRM_ROCKCHIP > + depends on EXTCON > select SND_SOC_HDMI_CODEC if SND_SOC > help > This selects support for Rockchip SoC specific extensions -- Ｍark Yao