From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Zhong Subject: Re: [PATCH v3 23/24] drm/rockchip: dw-mipi-dsi: add reset control Date: Thu, 16 Feb 2017 10:12:33 +0800 Message-ID: <58A50A91.6010202@rock-chips.com> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-24-john@metanate.com> <58A3CD45.9090309@rock-chips.com> <20170215123944.798ae363.john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170215123944.798ae363.john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: linux-rockchip.vger.kernel.org SGkgSm9obgoKT24gMDIvMTUvMjAxNyAwODozOSBQTSwgSm9obiBLZWVwaW5nIHdyb3RlOgo+IE9u IFdlZCwgMTUgRmViIDIwMTcgMTE6Mzg6NDUgKzA4MDAsIENocmlzIFpob25nIHdyb3RlOgo+Cj4+ IE9uIDAxLzI5LzIwMTcgMDk6MjQgUE0sIEpvaG4gS2VlcGluZyB3cm90ZToKPj4+IEluIG9yZGVy IHRvIGZ1bGx5IHJlc2V0IHRoZSBzdGF0ZSBvZiB0aGUgTUlQSSBjb250cm9sbGVyIHdlIG11c3Qg YXNzZXJ0Cj4+PiB0aGlzIHJlc2V0Lgo+Pj4KPj4+IFRoaXMgaXMgc2xpZ2h0bHkgbW9yZSBjb21w bGljYXRlZCB0aGFuIGl0IGNvdWxkIGJlIGluIG9yZGVyIHRvIG1haW50YWluCj4+PiBjb21wYXRp YmlsaXR5IHdpdGggZGV2aWNlIHRyZWVzIHRoYXQgZG8gbm90IHNwZWNpZnkgdGhlIHJlc2V0IHBy b3BlcnR5Lgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEpvaG4gS2VlcGluZyA8am9obkBtZXRhbmF0 ZS5jb20+Cj4+PiBSZXZpZXdlZC1ieTogQ2hyaXMgWmhvbmcgPHp5d0Byb2NrLWNoaXBzLmNvbT4K Pj4+IC0tLQo+Pj4gdjM6Cj4+PiAtIEFkZCBDaHJpcycgUmV2aWV3ZWQtYnkKPj4+IFVuY2hhbmdl ZCBpbiB2Mgo+Pj4KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5j IHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+PiAgICAxIGZpbGUgY2hhbmdl ZCwgMzAgaW5zZXJ0aW9ucygrKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v cm9ja2NoaXAvZHctbWlwaS1kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBp LWRzaS5jCj4+PiBpbmRleCA1OGNiOGFjZTJmZTguLmNmM2NhNmIwY2JkYiAxMDA2NDQKPj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+Pj4gQEAgLTEzLDYgKzEzLDcgQEAK Pj4+ICAgICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPj4+ICAgICNpbmNsdWRlIDxsaW51eC9v Zl9kZXZpY2UuaD4KPj4+ICAgICNpbmNsdWRlIDxsaW51eC9yZWdtYXAuaD4KPj4+ICsjaW5jbHVk ZSA8bGludXgvcmVzZXQuaD4KPj4+ICAgICNpbmNsdWRlIDxsaW51eC9tZmQvc3lzY29uLmg+Cj4+ PiAgICAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4+PiAgICAjaW5jbHVkZSA8 ZHJtL2RybV9jcnRjLmg+Cj4+PiBAQCAtMTEyNCw2ICsxMTI1LDcgQEAgc3RhdGljIGludCBkd19t aXBpX2RzaV9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLAo+ Pj4gICAgCQkJb2ZfbWF0Y2hfZGV2aWNlKGR3X21pcGlfZHNpX2R0X2lkcywgZGV2KTsKPj4+ICAg IAljb25zdCBzdHJ1Y3QgZHdfbWlwaV9kc2lfcGxhdF9kYXRhICpwZGF0YSA9IG9mX2lkLT5kYXRh Owo+Pj4gICAgCXN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYgPSB0b19wbGF0Zm9ybV9kZXZp Y2UoZGV2KTsKPj4+ICsJc3RydWN0IHJlc2V0X2NvbnRyb2wgKmFwYl9yc3Q7Cj4+PiAgICAJc3Ry dWN0IGRybV9kZXZpY2UgKmRybSA9IGRhdGE7Cj4+PiAgICAJc3RydWN0IGR3X21pcGlfZHNpICpk c2k7Cj4+PiAgICAJc3RydWN0IHJlc291cmNlICpyZXM7Cj4+PiBAQCAtMTE2Miw2ICsxMTY0LDM0 IEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVj dCBkZXZpY2UgKm1hc3RlciwKPj4+ICAgIAkJcmV0dXJuIHJldDsKPj4+ICAgIAl9Cj4+PiAgICAK Pj4+ICsJLyoKPj4+ICsJICogTm90ZSB0aGF0IHRoZSByZXNldCB3YXMgbm90IGRlZmluZWQgaW4g dGhlIGluaXRpYWwgZGV2aWNlIHRyZWUsIHNvCj4+PiArCSAqIHdlIGhhdmUgdG8gYmUgcHJlcGFy ZWQgZm9yIGl0IG5vdCBiZWluZyBmb3VuZC4KPj4+ICsJICovCj4+PiArCWFwYl9yc3QgPSBkZXZt X3Jlc2V0X2NvbnRyb2xfZ2V0KGRldiwgImFwYiIpOwo+Pj4gKwlpZiAoSVNfRVJSKGFwYl9yc3Qp KSB7Cj4+PiArCQlpZiAoUFRSX0VSUihhcGJfcnN0KSA9PSAtRU5PREVWKSB7Cj4+IEFjY29yZGlu ZyB0byBbMF0sIEkgdGhpbmsgaXQgc2hvdWxkIGJlIC1FTk9FTlQgaGVyZS4KPiBOaWNlIGNhdGNo LCBJJ2xsIGZpeCB0aGlzLgo+Cj4+IFswXQo+PiBodHRwczovL2dpdC5rZXJuZWwub3JnL2NnaXQv bGludXgva2VybmVsL2dpdC9uZXh0L2xpbnV4LW5leHQuZ2l0L2NvbW1pdC8/aWQ9M2Q4MTIxNmZk ZTQ2NWU3NmM1ZWFlOThmNjFkMzY2NjE2MzYzNDM5NQo+Pgo+PiBjb21taXQgM2Q4MTIxNmZkZTQ2 NWU3NmM1ZWFlOThmNjFkMzY2NjE2MzYzNDM5NQo+PiBBdXRob3I6IEFsYmFuIEJlZGVsIDxhbGJl dUBmcmVlLmZyPgo+PiBEYXRlOiAgIFR1ZSBTZXAgMSAxNzoyODozMSAyMDE1ICswMjAwCj4+Cj4+ ICAgICAgIHJlc2V0OiBGaXggb2ZfcmVzZXRfY29udHJvbF9nZXQoKSBmb3IgY29uc2lzdGVudCBy ZXR1cm4gdmFsdWVzCj4+Cj4+ICAgICAgIFdoZW4gb2ZfcmVzZXRfY29udHJvbF9nZXQoKSBpcyBj YWxsZWQgd2l0aG91dCBjb25uZWN0aW9uIElEIGl0IHJldHVybnMKPj4gICAgICAgLUVOT0VOVCB3 aGVuIHRoZSAncmVzZXRzJyBwcm9wZXJ0eSBkb2Vzbid0IGV4aXN0cyBvciBpcyBhbiBlbXB0eSBl bnRyeS4KPj4gICAgICAgSG93ZXZlciB3aGVuIGEgY29ubmVjdGlvbiBJRCBpcyBnaXZlbiBpdCBy ZXR1cm5zIC1FSU5WQUwgd2hlbiB0aGUKPj4gJ3Jlc2V0cycKPj4gICAgICAgcHJvcGVydHkgZG9l c24ndCBleGlzdHMgb3IgdGhlIHJlcXVlc3RlZCBuYW1lIGNhbid0IGJlIGZvdW5kLiBUaGlzIGlz Cj4+ICAgICAgIGJlY2F1c2UgdGhlIGVycm9yIGNvZGUgcmV0dXJuZWQgYnkgb2ZfcHJvcGVydHlf bWF0Y2hfc3RyaW5nKCkgaXMganVzdAo+PiAgICAgICBwYXNzZWQgZG93biBhcyBhbiBpbmRleCB0 byBvZl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncygpLCB3aGljaCB0aGVuCj4+ICAgICAgIHJldHVy bnMgLUVJTlZBTC4KPj4KPj4gICAgICAgVG8gZ2V0IGEgY29uc2lzdGVudCByZXR1cm4gdmFsdWUg d2l0aCBib3RoIGNvZGUgcGF0aHMgd2UgbXVzdCByZXR1cm4KPj4gICAgICAgLUVOT0VOVCB3aGVu IG9mX3Byb3BlcnR5X21hdGNoX3N0cmluZygpIGZhaWxzLgo+Pgo+PiAgICAgICBTaWduZWQtb2Zm LWJ5OiBBbGJhbiBCZWRlbCA8YWxiZXVAZnJlZS5mcj4KPj4gICAgICAgU2lnbmVkLW9mZi1ieTog UGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4KPj4KPj4KPj4+ICsJCQlhcGJf cnN0ID0gTlVMTDsKPj4+ICsJCX0gZWxzZSB7Cj4+PiArCQkJZGV2X2VycihkZXYsICJVbmFibGUg dG8gZ2V0IHJlc2V0IGNvbnRyb2w6ICVkXG4iLCByZXQpOwpBbHNvLCB3ZSBjYW4gbm90IGdldCBl cnJvciBudW1iZXIgZnJvbSAicmV0IiBoZXJlLgoKPj4+ICsJCQlyZXR1cm4gUFRSX0VSUihhcGJf cnN0KTsKPj4+ICsJCX0KPj4+ICsJfQo+Pj4gKwo+Pj4gKwlpZiAoYXBiX3JzdCkgewo+Pj4gKwkJ cmV0ID0gY2xrX3ByZXBhcmVfZW5hYmxlKGRzaS0+cGNsayk7Cj4+PiArCQlpZiAocmV0KSB7Cj4+ PiArCQkJZGV2X2VycihkZXYsICIlczogRmFpbGVkIHRvIGVuYWJsZSBwY2xrXG4iLCBfX2Z1bmNf Xyk7Cj4+PiArCQkJcmV0dXJuIHJldDsKPj4+ICsJCX0KPj4+ICsKPj4+ICsJCXJlc2V0X2NvbnRy b2xfYXNzZXJ0KGFwYl9yc3QpOwo+Pj4gKwkJdXNsZWVwX3JhbmdlKDEwLCAyMCk7Cj4+PiArCQly ZXNldF9jb250cm9sX2RlYXNzZXJ0KGFwYl9yc3QpOwo+Pj4gKwo+Pj4gKwkJY2xrX2Rpc2FibGVf dW5wcmVwYXJlKGRzaS0+cGNsayk7Cj4+PiArCX0KPj4+ICsKPj4+ICAgIAlyZXQgPSBjbGtfcHJl cGFyZV9lbmFibGUoZHNpLT5wbGxyZWZfY2xrKTsKPj4+ICAgIAlpZiAocmV0KSB7Cj4+PiAgICAJ CWRldl9lcnIoZGV2LCAiJXM6IEZhaWxlZCB0byBlbmFibGUgcGxscmVmX2Nsa1xuIiwgX19mdW5j X18pOwo+Pgo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: zyw@rock-chips.com (Chris Zhong) Date: Thu, 16 Feb 2017 10:12:33 +0800 Subject: [PATCH v3 23/24] drm/rockchip: dw-mipi-dsi: add reset control In-Reply-To: <20170215123944.798ae363.john@metanate.com> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-24-john@metanate.com> <58A3CD45.9090309@rock-chips.com> <20170215123944.798ae363.john@metanate.com> Message-ID: <58A50A91.6010202@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi John On 02/15/2017 08:39 PM, John Keeping wrote: > On Wed, 15 Feb 2017 11:38:45 +0800, Chris Zhong wrote: > >> On 01/29/2017 09:24 PM, John Keeping wrote: >>> In order to fully reset the state of the MIPI controller we must assert >>> this reset. >>> >>> This is slightly more complicated than it could be in order to maintain >>> compatibility with device trees that do not specify the reset property. >>> >>> Signed-off-by: John Keeping >>> Reviewed-by: Chris Zhong >>> --- >>> v3: >>> - Add Chris' Reviewed-by >>> Unchanged in v2 >>> >>> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >>> index 58cb8ace2fe8..cf3ca6b0cbdb 100644 >>> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >>> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >>> @@ -13,6 +13,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -1124,6 +1125,7 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master, >>> of_match_device(dw_mipi_dsi_dt_ids, dev); >>> const struct dw_mipi_dsi_plat_data *pdata = of_id->data; >>> struct platform_device *pdev = to_platform_device(dev); >>> + struct reset_control *apb_rst; >>> struct drm_device *drm = data; >>> struct dw_mipi_dsi *dsi; >>> struct resource *res; >>> @@ -1162,6 +1164,34 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master, >>> return ret; >>> } >>> >>> + /* >>> + * Note that the reset was not defined in the initial device tree, so >>> + * we have to be prepared for it not being found. >>> + */ >>> + apb_rst = devm_reset_control_get(dev, "apb"); >>> + if (IS_ERR(apb_rst)) { >>> + if (PTR_ERR(apb_rst) == -ENODEV) { >> According to [0], I think it should be -ENOENT here. > Nice catch, I'll fix this. > >> [0] >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=3d81216fde465e76c5eae98f61d3666163634395 >> >> commit 3d81216fde465e76c5eae98f61d3666163634395 >> Author: Alban Bedel >> Date: Tue Sep 1 17:28:31 2015 +0200 >> >> reset: Fix of_reset_control_get() for consistent return values >> >> When of_reset_control_get() is called without connection ID it returns >> -ENOENT when the 'resets' property doesn't exists or is an empty entry. >> However when a connection ID is given it returns -EINVAL when the >> 'resets' >> property doesn't exists or the requested name can't be found. This is >> because the error code returned by of_property_match_string() is just >> passed down as an index to of_parse_phandle_with_args(), which then >> returns -EINVAL. >> >> To get a consistent return value with both code paths we must return >> -ENOENT when of_property_match_string() fails. >> >> Signed-off-by: Alban Bedel >> Signed-off-by: Philipp Zabel >> >> >>> + apb_rst = NULL; >>> + } else { >>> + dev_err(dev, "Unable to get reset control: %d\n", ret); Also, we can not get error number from "ret" here. >>> + return PTR_ERR(apb_rst); >>> + } >>> + } >>> + >>> + if (apb_rst) { >>> + ret = clk_prepare_enable(dsi->pclk); >>> + if (ret) { >>> + dev_err(dev, "%s: Failed to enable pclk\n", __func__); >>> + return ret; >>> + } >>> + >>> + reset_control_assert(apb_rst); >>> + usleep_range(10, 20); >>> + reset_control_deassert(apb_rst); >>> + >>> + clk_disable_unprepare(dsi->pclk); >>> + } >>> + >>> ret = clk_prepare_enable(dsi->pllref_clk); >>> if (ret) { >>> dev_err(dev, "%s: Failed to enable pllref_clk\n", __func__); >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752958AbdBPCMt (ORCPT ); Wed, 15 Feb 2017 21:12:49 -0500 Received: from regular1.263xmail.com ([211.150.99.140]:44273 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbdBPCMr (ORCPT ); Wed, 15 Feb 2017 21:12:47 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 220.128.92.125 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 23/24] drm/rockchip: dw-mipi-dsi: add reset control To: John Keeping References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-24-john@metanate.com> <58A3CD45.9090309@rock-chips.com> <20170215123944.798ae363.john@metanate.com> Cc: Mark Yao , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Chris Zhong Message-ID: <58A50A91.6010202@rock-chips.com> Date: Thu, 16 Feb 2017 10:12:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20170215123944.798ae363.john@metanate.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John On 02/15/2017 08:39 PM, John Keeping wrote: > On Wed, 15 Feb 2017 11:38:45 +0800, Chris Zhong wrote: > >> On 01/29/2017 09:24 PM, John Keeping wrote: >>> In order to fully reset the state of the MIPI controller we must assert >>> this reset. >>> >>> This is slightly more complicated than it could be in order to maintain >>> compatibility with device trees that do not specify the reset property. >>> >>> Signed-off-by: John Keeping >>> Reviewed-by: Chris Zhong >>> --- >>> v3: >>> - Add Chris' Reviewed-by >>> Unchanged in v2 >>> >>> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >>> index 58cb8ace2fe8..cf3ca6b0cbdb 100644 >>> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >>> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >>> @@ -13,6 +13,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -1124,6 +1125,7 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master, >>> of_match_device(dw_mipi_dsi_dt_ids, dev); >>> const struct dw_mipi_dsi_plat_data *pdata = of_id->data; >>> struct platform_device *pdev = to_platform_device(dev); >>> + struct reset_control *apb_rst; >>> struct drm_device *drm = data; >>> struct dw_mipi_dsi *dsi; >>> struct resource *res; >>> @@ -1162,6 +1164,34 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master, >>> return ret; >>> } >>> >>> + /* >>> + * Note that the reset was not defined in the initial device tree, so >>> + * we have to be prepared for it not being found. >>> + */ >>> + apb_rst = devm_reset_control_get(dev, "apb"); >>> + if (IS_ERR(apb_rst)) { >>> + if (PTR_ERR(apb_rst) == -ENODEV) { >> According to [0], I think it should be -ENOENT here. > Nice catch, I'll fix this. > >> [0] >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=3d81216fde465e76c5eae98f61d3666163634395 >> >> commit 3d81216fde465e76c5eae98f61d3666163634395 >> Author: Alban Bedel >> Date: Tue Sep 1 17:28:31 2015 +0200 >> >> reset: Fix of_reset_control_get() for consistent return values >> >> When of_reset_control_get() is called without connection ID it returns >> -ENOENT when the 'resets' property doesn't exists or is an empty entry. >> However when a connection ID is given it returns -EINVAL when the >> 'resets' >> property doesn't exists or the requested name can't be found. This is >> because the error code returned by of_property_match_string() is just >> passed down as an index to of_parse_phandle_with_args(), which then >> returns -EINVAL. >> >> To get a consistent return value with both code paths we must return >> -ENOENT when of_property_match_string() fails. >> >> Signed-off-by: Alban Bedel >> Signed-off-by: Philipp Zabel >> >> >>> + apb_rst = NULL; >>> + } else { >>> + dev_err(dev, "Unable to get reset control: %d\n", ret); Also, we can not get error number from "ret" here. >>> + return PTR_ERR(apb_rst); >>> + } >>> + } >>> + >>> + if (apb_rst) { >>> + ret = clk_prepare_enable(dsi->pclk); >>> + if (ret) { >>> + dev_err(dev, "%s: Failed to enable pclk\n", __func__); >>> + return ret; >>> + } >>> + >>> + reset_control_assert(apb_rst); >>> + usleep_range(10, 20); >>> + reset_control_deassert(apb_rst); >>> + >>> + clk_disable_unprepare(dsi->pclk); >>> + } >>> + >>> ret = clk_prepare_enable(dsi->pllref_clk); >>> if (ret) { >>> dev_err(dev, "%s: Failed to enable pllref_clk\n", __func__); >> > >