From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhoucm1 Subject: Re: [PATCH v3 3/3] drm/amdgpu: simplify reservation handling during buffer creation Date: Fri, 17 Feb 2017 10:48:10 +0800 Message-ID: <58A6646A.30304@amd.com> References: <20170216113946.22046-1-nhaehnle@gmail.com> <20170216113946.22046-3-nhaehnle@gmail.com> <7ee88e29-2e43-f5a7-8e0e-3483da1d5b4b@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <7ee88e29-2e43-f5a7-8e0e-3483da1d5b4b@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , =?UTF-8?B?Tmljb2xhaSBIw6Robmxl?= , amd-gfx@lists.freedesktop.org Cc: =?UTF-8?B?Tmljb2xhaSBIw6Robmxl?= , dri-devel@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org CgpPbiAyMDE35bm0MDLmnIgxNuaXpSAyMDowOCwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBB bSAxNi4wMi4yMDE3IHVtIDEyOjM5IHNjaHJpZWIgTmljb2xhaSBIw6RobmxlOgo+PiBGcm9tOiBO aWNvbGFpIEjDpGhubGUgPG5pY29sYWkuaGFlaG5sZUBhbWQuY29tPgo+Pgo+PiBCeSB1c2luZyB0 dG1fYm9faW5pdF9yZXNlcnZlZCBpbnN0ZWFkIG9mIHRoZSBtYW51YWwgaW5pdGlhbGl6YXRpb24g b2YKPj4gdGhlIHJlc2VydmF0aW9uIG9iamVjdCwgdGhlIHJlc2VydmF0aW9uIGxvY2sgd2lsbCBi ZSBwcm9wZXJseSB1bmxvY2tlZAo+PiBhbmQgZGVzdHJveWVkIHdoZW4gdGhlIFRUTSBCTyBpbml0 aWFsaXphdGlvbiBmYWlscy4KPj4KPj4gQWN0dWFsIGRlYWRsb2NrcyBjYXVzZWQgYnkgdGhlIG1p c3NpbmcgdW5sb2NrIHNob3VsZCBoYXZlIGJlZW4gZml4ZWQKPj4gYnkgImRybS90dG06IG5ldmVy IGFkZCBCTyB0aGF0IGZhaWxlZCB0byB2YWxpZGF0ZSB0byB0aGUgTFJVIGxpc3QiLAo+PiBzdXBl cnNlZGluZyB0aGUgZmxhd2VkIGZpeCBpbiBjb21taXQgMzhmYzQ4NTZhZDk4ICgiZHJtL2FtZGdw dTogZml4Cj4+IGEgcG90ZW50aWFsIGRlYWRsb2NrIGluIGFtZGdwdV9ib19jcmVhdGVfcmVzdHJp Y3RlZCgpIikuCj4+Cj4+IFRoaXMgY2hhbmdlIGZpeGVzIHJlbWFpbmluZyByZWN1cnNpdmUgbG9j a2luZyBlcnJvcnMgdGhhdCBjYW4gYmUgc2Vlbgo+PiB3aXRoIGxvY2sgZGVidWdnaW5nIGVuYWJs ZWQsIGFuZCBhdm9pZHMgdGhlIGVycm9yIG9mIGZyZWVpbmcgYSBsb2NrZWQKPj4gbXV0ZXguCj4+ Cj4+IEFzIGFuIGFkZGl0aW9uYWwgbWlub3IgYm9udXMsIGJ1ZmZlcnMgY3JlYXRlZCB3aXRoIHJl c3YgPT0gTlVMTCBhbmQKPj4gdGhlIEFNREdQVV9HRU1fQ1JFQVRFX1ZSQU1fQ0xFQVJFRCBmbGFn IGFyZSBub3cgb25seSBhZGRlZCB0byB0aGUKPj4gZ2xvYmFsIExSVSBsaXN0IGFmdGVyIHRoZSBm aWxsIGNvbW1hbmRzIGhhdmUgYmVlbiBpc3N1ZWQuCj4+Cj4+IEZpeGVzOiAxMmE4NTIyMTk1ODMg KCJkcm0vYW1kZ3B1OiBpbXByb3ZlIAo+PiBBTURHUFVfR0VNX0NSRUFURV9WUkFNX0NMRUFSRUQg aGFuZGxpbmcgKHYyKSIpCj4+IFNpZ25lZC1vZmYtYnk6IE5pY29sYWkgSMOkaG5sZSA8bmljb2xh aS5oYWVobmxlQGFtZC5jb20+ClJldmlld2VkLWJ5OiBDaHVubWluZyBaaG91IDxkYXZpZDEuemhv dUBhbWQuY29tPiBhcyB3ZWxsCgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfb2JqZWN0LmMgfCAxNyArKysrLS0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jIAo+PiBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuYwo+PiBpbmRleCBjMmU1N2Y3Li40ZDA1 MzZkIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2Jq ZWN0LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5j Cj4+IEBAIC0zOTUsMTkgKzM5NSwxMCBAQCBpbnQgYW1kZ3B1X2JvX2NyZWF0ZV9yZXN0cmljdGVk KHN0cnVjdCAKPj4gYW1kZ3B1X2RldmljZSAqYWRldiwKPj4gICAgICAgYW1kZ3B1X2ZpbGxfcGxh Y2VtZW50X3RvX2JvKGJvLCBwbGFjZW1lbnQpOwo+PiAgICAgICAvKiBLZXJuZWwgYWxsb2NhdGlv biBhcmUgdW5pbnRlcnJ1cHRpYmxlICovCj4+ICAgLSAgICBpZiAoIXJlc3YpIHsKPj4gLSAgICAg ICAgYm9vbCBsb2NrZWQ7Cj4+IC0KPj4gLSAgICAgICAgcmVzZXJ2YXRpb25fb2JqZWN0X2luaXQo JmJvLT50Ym8udHRtX3Jlc3YpOwo+PiAtICAgICAgICBsb2NrZWQgPSB3d19tdXRleF90cnlsb2Nr KCZiby0+dGJvLnR0bV9yZXN2LmxvY2spOwo+PiAtICAgICAgICBXQVJOX09OKCFsb2NrZWQpOwo+ PiAtICAgIH0KPj4gLQo+PiAgICAgICBpbml0aWFsX2J5dGVzX21vdmVkID0gYXRvbWljNjRfcmVh ZCgmYWRldi0+bnVtX2J5dGVzX21vdmVkKTsKPj4gLSAgICByID0gdHRtX2JvX2luaXQoJmFkZXYt Pm1tYW4uYmRldiwgJmJvLT50Ym8sIHNpemUsIHR5cGUsCj4+IC0gICAgICAgICAgICAmYm8tPnBs YWNlbWVudCwgcGFnZV9hbGlnbiwgIWtlcm5lbCwgTlVMTCwKPj4gLSAgICAgICAgICAgIGFjY19z aXplLCBzZywgcmVzdiA/IHJlc3YgOiAmYm8tPnRiby50dG1fcmVzdiwKPj4gLSAgICAgICAgICAg ICZhbWRncHVfdHRtX2JvX2Rlc3Ryb3kpOwo+PiArICAgIHIgPSB0dG1fYm9faW5pdF9yZXNlcnZl ZCgmYWRldi0+bW1hbi5iZGV2LCAmYm8tPnRibywgc2l6ZSwgdHlwZSwKPj4gKyAgICAgICAgICAg ICAgICAgJmJvLT5wbGFjZW1lbnQsIHBhZ2VfYWxpZ24sICFrZXJuZWwsIE5VTEwsCj4+ICsgICAg ICAgICAgICAgICAgIGFjY19zaXplLCBzZywgcmVzdiwgJmFtZGdwdV90dG1fYm9fZGVzdHJveSk7 Cj4+ICAgICAgIGFtZGdwdV9jc19yZXBvcnRfbW92ZWRfYnl0ZXMoYWRldiwKPj4gICAgICAgICAg IGF0b21pYzY0X3JlYWQoJmFkZXYtPm51bV9ieXRlc19tb3ZlZCkgLSBpbml0aWFsX2J5dGVzX21v dmVkKTsKPj4gICBAQCAtNDMzLDcgKzQyNCw3IEBAIGludCBhbWRncHVfYm9fY3JlYXRlX3Jlc3Ry aWN0ZWQoc3RydWN0IAo+PiBhbWRncHVfZGV2aWNlICphZGV2LAo+PiAgICAgICAgICAgZmVuY2Vf cHV0KGZlbmNlKTsKPj4gICAgICAgfQo+PiAgICAgICBpZiAoIXJlc3YpCj4+IC0gICAgICAgIHd3 X211dGV4X3VubG9jaygmYm8tPnRiby5yZXN2LT5sb2NrKTsKPj4gKyAgICAgICAgdHRtX2JvX3Vu cmVzZXJ2ZSgmYm8tPnRibyk7Cj4KPiBZb3UgY2FuIGp1c3QgdXNlIGFtZGdwdV9ib191bnJlc2Vy dmUoKSBoZXJlLiBXaXRoIHRoYXQgZml4ZWQgdGhlIHdob2xlIAo+IHNldCBpcyBSZXZpZXdlZC1i eTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPi4KPgo+IFJlZ2Fy ZHMsCj4gQ2hyaXN0aWFuLgo+Cj4+ICAgICAgICpib19wdHIgPSBibzsKPj4gICAgICAgICB0cmFj ZV9hbWRncHVfYm9fY3JlYXRlKGJvKTsKPgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK