From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Sun, 19 Feb 2017 13:19:40 +0000 Subject: Re: [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c Message-Id: <58A99B6C.8000606@bfs.de> List-Id: References: <20170219054949.GA2754@localhost.localdomain> In-Reply-To: <20170219054949.GA2754@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Saurabh Badhwar Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Am 19.02.2017 06:49, schrieb Saurabh Badhwar: > Fix possible resource leak in tools/vm/page_owner_sort.c > Signed-off-by: Saurabh Badhwar > --- > tools/vm/page_owner_sort.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c > index f1c055f..8346261 100644 > --- a/tools/vm/page_owner_sort.c > +++ b/tools/vm/page_owner_sort.c > @@ -110,6 +110,8 @@ int main(int argc, char **argv) > buf = malloc(BUF_SIZE); > if (!list || !buf) { > printf("Out of memory\n"); > + fclose(fin); > + fclose(fout); > exit(1); > } the is no resource leak as file pointer get closed on exit ntl it is ok the close them but error messages should go to stderr an be more verbose. just my 2 cents, wh > > @@ -144,6 +146,7 @@ int main(int argc, char **argv) > > for (i = 0; i < count; i++) > fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt); > - > + > + fclose(fout); > return 0; > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbdBSNaZ (ORCPT ); Sun, 19 Feb 2017 08:30:25 -0500 Received: from mx02-sz.bfs.de ([194.94.69.103]:52067 "EHLO mx02-sz.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbdBSNaY (ORCPT ); Sun, 19 Feb 2017 08:30:24 -0500 Message-ID: <58A99B6C.8000606@bfs.de> Date: Sun, 19 Feb 2017 14:19:40 +0100 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Saurabh Badhwar CC: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c References: <20170219054949.GA2754@localhost.localdomain> In-Reply-To: <20170219054949.GA2754@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.02.2017 06:49, schrieb Saurabh Badhwar: > Fix possible resource leak in tools/vm/page_owner_sort.c > Signed-off-by: Saurabh Badhwar > --- > tools/vm/page_owner_sort.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c > index f1c055f..8346261 100644 > --- a/tools/vm/page_owner_sort.c > +++ b/tools/vm/page_owner_sort.c > @@ -110,6 +110,8 @@ int main(int argc, char **argv) > buf = malloc(BUF_SIZE); > if (!list || !buf) { > printf("Out of memory\n"); > + fclose(fin); > + fclose(fout); > exit(1); > } the is no resource leak as file pointer get closed on exit ntl it is ok the close them but error messages should go to stderr an be more verbose. just my 2 cents, wh > > @@ -144,6 +146,7 @@ int main(int argc, char **argv) > > for (i = 0; i < count; i++) > fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt); > - > + > + fclose(fout); > return 0; > }