From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Date: Mon, 20 Feb 2017 07:11:13 +0000 Subject: Re: [patch] drm/exynos/decon5433: & vs | typo Message-Id: <58AA9691.90602@samsung.com> List-Id: References: <20170214074620.GA9710@mwanda> In-Reply-To: <20170214074620.GA9710@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter , Andrzej Hajda Cc: linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Seung-Woo Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org Merged. Thanks, Inki Dae 2017년 02월 14일 16:46에 Dan Carpenter 이(가) 쓴 글: > "&" was obviously intended instead of "|". The original condition is > always true. > > Fixes: b93c2e8b5d9d ("drm/exynos/decon5433: configure sysreg in case of hardware trigger") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > index 0fd6f7a18364..cca32a4fdab3 100644 > --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > @@ -678,7 +678,7 @@ static int exynos5433_decon_probe(struct platform_device *pdev) > ctx->out_type |= IFTYPE_I80; > } > > - if (ctx->out_type | I80_HW_TRG) { > + if (ctx->out_type & I80_HW_TRG) { > ctx->sysreg = syscon_regmap_lookup_by_phandle(dev->of_node, > "samsung,disp-sysreg"); > if (IS_ERR(ctx->sysreg)) { > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [patch] drm/exynos/decon5433: & vs | typo Date: Mon, 20 Feb 2017 16:11:13 +0900 Message-ID: <58AA9691.90602@samsung.com> References: <20170214074620.GA9710@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <20170214074620.GA9710@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Andrzej Hajda Cc: linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Seung-Woo Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org List-Id: linux-samsung-soc@vger.kernel.org TWVyZ2VkLgoKVGhhbmtzLApJbmtpIERhZQoKMjAxN+uFhCAwMuyblCAxNOydvCAxNjo0NuyXkCBE YW4gQ2FycGVudGVyIOydtCjqsIApIOyTtCDquIA6Cj4gIiYiIHdhcyBvYnZpb3VzbHkgaW50ZW5k ZWQgaW5zdGVhZCBvZiAifCIuICBUaGUgb3JpZ2luYWwgY29uZGl0aW9uIGlzCj4gYWx3YXlzIHRy dWUuCj4gCj4gRml4ZXM6IGI5M2MyZThiNWQ5ZCAoImRybS9leHlub3MvZGVjb241NDMzOiBjb25m aWd1cmUgc3lzcmVnIGluIGNhc2Ugb2YgaGFyZHdhcmUgdHJpZ2dlciIpCj4gU2lnbmVkLW9mZi1i eTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vczU0MzNfZHJtX2RlY29uLmMgYi9kcml2 ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vczU0MzNfZHJtX2RlY29uLmMKPiBpbmRleCAwZmQ2Zjdh MTgzNjQuLmNjYTMyYTRmZGFiMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9z L2V4eW5vczU0MzNfZHJtX2RlY29uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4 eW5vczU0MzNfZHJtX2RlY29uLmMKPiBAQCAtNjc4LDcgKzY3OCw3IEBAIHN0YXRpYyBpbnQgZXh5 bm9zNTQzM19kZWNvbl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJCWN0 eC0+b3V0X3R5cGUgfD0gSUZUWVBFX0k4MDsKPiAgCX0KPiAgCj4gLQlpZiAoY3R4LT5vdXRfdHlw ZSB8IEk4MF9IV19UUkcpIHsKPiArCWlmIChjdHgtPm91dF90eXBlICYgSTgwX0hXX1RSRykgewo+ ICAJCWN0eC0+c3lzcmVnID0gc3lzY29uX3JlZ21hcF9sb29rdXBfYnlfcGhhbmRsZShkZXYtPm9m X25vZGUsCj4gIAkJCQkJCQkic2Ftc3VuZyxkaXNwLXN5c3JlZyIpOwo+ICAJCWlmIChJU19FUlIo Y3R4LT5zeXNyZWcpKSB7Cj4gLS0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2Vu ZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtc2Ftc3VuZy1zb2MiIGluCj4gdGhlIGJvZHkg b2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKPiBNb3JlIG1ham9yZG9t byBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwKPiAK PiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==