From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] shared/005,7: fix making sure debugfs sets negative i_size && add strict check for dd
Date: Wed, 22 Feb 2017 12:56:54 +0800 [thread overview]
Message-ID: <58AD1A16.10109@cn.fujitsu.com> (raw)
In-Reply-To: <20170222042041.GT24562@eguan.usersys.redhat.com>
On 2017/02/22 12:20, Eryu Guan wrote:
> On Mon, Feb 20, 2017 at 01:02:59PM +0800, Xiao Yang wrote:
>> 1) If the kernel bug has been fixed, stat command fails to get i_size
>> and reports "Structure needs cleaning". So we use debugfs -R "stat"
>> instead of stat command to make sure debugfs sets negative i_size.
>> These cases have been broken by commit 0e13e40b247a1 ("shared/005,7:
>> make sure debugfs sets negative i_size").
>>
>> 2) shared/007 passes unexpectedly on RHEL6.8GA and RHEL6.9Beta
>> because of invalid argument. When debugfs fails to set i_size
>> to -512, dd with direct flag fails and reports "invalid argument".
>> So we can add strict check.
> But you've already added the check for i_size and _notrun if debugfs
> failed to set i_size to -512, there's no chance for dd to hit EINVAL.
> And I think any error dd is hitting is acceptable, as long as test runs
> (which means i_size was set to -1/-512 successfully). So I don't think
> we need the check on dd's output. Did I miss anything?
Hi Eryu
Thanks for your comments.
xfs/134 passed unexpectedly on RHEL7.3GA because dd hits ENOSPC. So I think
all of these cases should fail instead of pass when hitting unexpected
error.
Do you think whether we only check on dd's output of xfs/133,4 or
remove all? :-)
Best Regards,
XIao Yang
>
>
> Thanks,
> Eryu
>
>
next prev parent reply other threads:[~2017-02-22 4:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 11:21 [PATCH] shared/005,7: add check whether debugfs succeeds to set a negative i_size or not Xiao Yang
2017-02-20 2:13 ` Xiao Yang
2017-02-20 2:36 ` Eryu Guan
2017-02-20 5:02 ` [PATCH] shared/005,7: fix making sure debugfs sets negative i_size && add strict check for dd Xiao Yang
2017-02-22 4:20 ` Eryu Guan
2017-02-22 4:56 ` Xiao Yang [this message]
2017-02-22 6:53 ` Eryu Guan
2017-02-22 8:17 ` [PATCH v2] shared/005,7: fix making sure debugfs sets negative i_size Xiao Yang
2017-02-20 9:37 ` [PATCH] xfs/133,4: make sure xfs_db sets negative i_size && add strict check for dd Xiao Yang
2017-02-22 9:31 ` [PATCH v2] xfs/133,4: make sure xfs_db sets negative i_size Xiao Yang
2017-02-22 10:49 ` Eryu Guan
2017-02-23 3:23 ` Xiao Yang
2017-02-23 3:35 ` [PATCH v3] " Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58AD1A16.10109@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.