From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yunlong Song Subject: Re: [PATCH] f2fs: clean up codes in f2fs_gc related with write_checkpoint Date: Thu, 23 Feb 2017 10:52:25 +0800 Message-ID: <58AE4E69.1050104@huawei.com> References: <1487681028-19410-1-git-send-email-yunlong.song@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1487681028-19410-1-git-send-email-yunlong.song@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: jaegeuk@kernel.org, cm224.lee@samsung.com, yuchao0@huawei.com, chao@kernel.org, sylinux@163.com, miaoxie@huawei.com Cc: bintian.wang@huawei.com, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org List-Id: linux-f2fs-devel.lists.sourceforge.net Ping... Since has_not_enough_free_secs(sbi, 0, 0) must be true if has_not_enough_free_secs(sbi, sec_freed, 0) is true, write_checkpoint is sure to execute in both conditions, and segno is NULL_SEGNO in both conditions. On 2017/2/21 20:43, Yunlong Song wrote: > Signed-off-by: Yunlong Song > --- > fs/f2fs/gc.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 88e5e7b..e5f2569 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -943,23 +943,15 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background) > * enough free sections, we should flush dent/node blocks and do > * garbage collections. > */ > - if (__get_victim(sbi, &segno, gc_type) || > - prefree_segments(sbi)) { > - ret = write_checkpoint(sbi, &cpc); > - if (ret) > - goto stop; > - segno = NULL_SEGNO; > - } else if (has_not_enough_free_secs(sbi, 0, 0)) { > - ret = write_checkpoint(sbi, &cpc); > - if (ret) > - goto stop; > - } > + ret = write_checkpoint(sbi, &cpc); > + if (ret) > + goto stop; > } else if (gc_type == BG_GC && !background) { > /* f2fs_balance_fs doesn't need to do BG_GC in critical path. */ > goto stop; > } > > - if (segno == NULL_SEGNO && !__get_victim(sbi, &segno, gc_type)) > + if (!__get_victim(sbi, &segno, gc_type)) > goto stop; > ret = 0; > -- Thanks, Yunlong Song From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com ([45.249.212.188]:2887 "EHLO dggrg02-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S933978AbdBWCzL (ORCPT ); Wed, 22 Feb 2017 21:55:11 -0500 Subject: Re: [PATCH] f2fs: clean up codes in f2fs_gc related with write_checkpoint To: , , , , , References: <1487681028-19410-1-git-send-email-yunlong.song@huawei.com> CC: , , , From: Yunlong Song Message-ID: <58AE4E69.1050104@huawei.com> Date: Thu, 23 Feb 2017 10:52:25 +0800 MIME-Version: 1.0 In-Reply-To: <1487681028-19410-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Ping... Since has_not_enough_free_secs(sbi, 0, 0) must be true if has_not_enough_free_secs(sbi, sec_freed, 0) is true, write_checkpoint is sure to execute in both conditions, and segno is NULL_SEGNO in both conditions. On 2017/2/21 20:43, Yunlong Song wrote: > Signed-off-by: Yunlong Song > --- > fs/f2fs/gc.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 88e5e7b..e5f2569 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -943,23 +943,15 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background) > * enough free sections, we should flush dent/node blocks and do > * garbage collections. > */ > - if (__get_victim(sbi, &segno, gc_type) || > - prefree_segments(sbi)) { > - ret = write_checkpoint(sbi, &cpc); > - if (ret) > - goto stop; > - segno = NULL_SEGNO; > - } else if (has_not_enough_free_secs(sbi, 0, 0)) { > - ret = write_checkpoint(sbi, &cpc); > - if (ret) > - goto stop; > - } > + ret = write_checkpoint(sbi, &cpc); > + if (ret) > + goto stop; > } else if (gc_type == BG_GC && !background) { > /* f2fs_balance_fs doesn't need to do BG_GC in critical path. */ > goto stop; > } > > - if (segno == NULL_SEGNO && !__get_victim(sbi, &segno, gc_type)) > + if (!__get_victim(sbi, &segno, gc_type)) > goto stop; > ret = 0; > -- Thanks, Yunlong Song