From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode Date: Tue, 28 Feb 2017 08:58:41 +0530 Message-ID: <58B4EE69.6030004@ti.com> References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-15-git-send-email-kishon@ti.com> <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: devicetree@vger.kernel.org, Joao Pinto , linux-doc@vger.kernel.org, Jingoo Han , nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On Monday 27 February 2017 10:10 PM, Rob Herring wrote: > On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote: >> Update device tree binding documentation of TI's dra7xx PCI >> controller to include property for enabling legacy mode. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Documentation/devicetree/bindings/pci/ti-pci.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt >> index 190828a..72ebe2b 100644 >> --- a/Documentation/devicetree/bindings/pci/ti-pci.txt >> +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt >> @@ -39,6 +39,10 @@ DEVICE MODE >> - interrupts : one interrupt entries must be specified for main interrupt. >> - num-ib-windows : number of inbound address translation windows >> - num-ob-windows : number of outbound address translation windows >> + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should >> + contain the register offset within syscon and the 2nd >> + argument should contain the bit field for setting the >> + legacy mode > > Vendor prefix needed and what does "legacy mode" mean? Perhaps name this > around what the mode is/does, not that it is legacy. All right, thanks! -Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode To: Rob Herring References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-15-git-send-email-kishon@ti.com> <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> From: Kishon Vijay Abraham I Message-ID: <58B4EE69.6030004@ti.com> Date: Tue, 28 Feb 2017 08:58:41 +0530 MIME-Version: 1.0 In-Reply-To: <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Joao Pinto , linux-doc@vger.kernel.org, Jingoo Han , nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Monday 27 February 2017 10:10 PM, Rob Herring wrote: > On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote: >> Update device tree binding documentation of TI's dra7xx PCI >> controller to include property for enabling legacy mode. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Documentation/devicetree/bindings/pci/ti-pci.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt >> index 190828a..72ebe2b 100644 >> --- a/Documentation/devicetree/bindings/pci/ti-pci.txt >> +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt >> @@ -39,6 +39,10 @@ DEVICE MODE >> - interrupts : one interrupt entries must be specified for main interrupt. >> - num-ib-windows : number of inbound address translation windows >> - num-ob-windows : number of outbound address translation windows >> + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should >> + contain the register offset within syscon and the 2nd >> + argument should contain the bit field for setting the >> + legacy mode > > Vendor prefix needed and what does "legacy mode" mean? Perhaps name this > around what the mode is/does, not that it is legacy. All right, thanks! -Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Tue, 28 Feb 2017 08:58:41 +0530 Subject: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode In-Reply-To: <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-15-git-send-email-kishon@ti.com> <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> Message-ID: <58B4EE69.6030004@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 27 February 2017 10:10 PM, Rob Herring wrote: > On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote: >> Update device tree binding documentation of TI's dra7xx PCI >> controller to include property for enabling legacy mode. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Documentation/devicetree/bindings/pci/ti-pci.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt >> index 190828a..72ebe2b 100644 >> --- a/Documentation/devicetree/bindings/pci/ti-pci.txt >> +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt >> @@ -39,6 +39,10 @@ DEVICE MODE >> - interrupts : one interrupt entries must be specified for main interrupt. >> - num-ib-windows : number of inbound address translation windows >> - num-ob-windows : number of outbound address translation windows >> + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should >> + contain the register offset within syscon and the 2nd >> + argument should contain the bit field for setting the >> + legacy mode > > Vendor prefix needed and what does "legacy mode" mean? Perhaps name this > around what the mode is/does, not that it is legacy. All right, thanks! -Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751435AbdB1FUO (ORCPT ); Tue, 28 Feb 2017 00:20:14 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:48748 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbdB1FUL (ORCPT ); Tue, 28 Feb 2017 00:20:11 -0500 Subject: Re: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode To: Rob Herring References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-15-git-send-email-kishon@ti.com> <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> CC: Bjorn Helgaas , Jingoo Han , Joao Pinto , , , , , , , From: Kishon Vijay Abraham I Message-ID: <58B4EE69.6030004@ti.com> Date: Tue, 28 Feb 2017 08:58:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 27 February 2017 10:10 PM, Rob Herring wrote: > On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote: >> Update device tree binding documentation of TI's dra7xx PCI >> controller to include property for enabling legacy mode. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Documentation/devicetree/bindings/pci/ti-pci.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt >> index 190828a..72ebe2b 100644 >> --- a/Documentation/devicetree/bindings/pci/ti-pci.txt >> +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt >> @@ -39,6 +39,10 @@ DEVICE MODE >> - interrupts : one interrupt entries must be specified for main interrupt. >> - num-ib-windows : number of inbound address translation windows >> - num-ob-windows : number of outbound address translation windows >> + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should >> + contain the register offset within syscon and the 2nd >> + argument should contain the bit field for setting the >> + legacy mode > > Vendor prefix needed and what does "legacy mode" mean? Perhaps name this > around what the mode is/does, not that it is legacy. All right, thanks! -Kishon