From: Mike Christie <mchristi@redhat.com>
To: Xiubo Li <lixiubo@cmss.chinamobile.com>,
Andy Grover <agrover@redhat.com>,
nab@linux-iscsi.org, shli@kernel.org
Cc: hch@lst.de, sheng@yasker.org, namei.unix@gmail.com,
bart.vanassche@sandisk.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jianfei Hu <hujianfei@cmss.chinamobile.com>,
Venky Shankar <vshankar@redhat.com>
Subject: Re: [PATCH] target/user: Add daynmic growing data area featuresupport
Date: Tue, 28 Feb 2017 12:13:22 -0600 [thread overview]
Message-ID: <58B5BDC2.3040300@redhat.com> (raw)
In-Reply-To: <983dc030-0352-05d8-9fc7-a6cdf2c59f8d@cmss.chinamobile.com>
On 02/27/2017 07:22 PM, Xiubo Li wrote:
> Hi Mike
>
> Thanks verrry much for your work and test cases.
>
>
>>>>> From: Xiubo Li <lixiubo@cmss.chinamobile.com>
>>>>>
>>>>> Currently for the TCMU, the ring buffer size is fixed to 64K cmd
>>>>> area + 1M data area, and this will be bottlenecks for high iops.
>>> Hi Xiubo, thanks for your work.
>>>
>>> daynmic -> dynamic
>>>
>>> Have you benchmarked this patch and determined what kind of iops
>>> improvement it allows? Do you see the data area reaching its
>>> fully-allocated size?
>>>
>> I tested this patch with Venky's tcmu-runner rbd aio patches, with one
>> 10 gig iscsi session, and for pretty basic fio direct io (64 -256K
>> read/writes with a queue depth of 64 numjobs between 1 and 4) tests read
>> throughput goes from about 80 to 500 MB/s.
> Looks nice.
>
>> Write throughput is pretty
>> low at around 150 MB/s.
> What's the original write throughput without this patch? Is it also
> around 80 MB/s ?
It is around 20-30 MB/s. Same fio args except using --rw=write.
next prev parent reply other threads:[~2017-02-28 18:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 9:24 [PATCH] target/user: Add daynmic growing data area feature support lixiubo
2017-02-22 20:32 ` Andy Grover
2017-02-24 2:07 ` [PATCH] target/user: Add daynmic growing data area featuresupport Xiubo Li
2017-02-24 22:29 ` Andy Grover
2017-02-27 5:59 ` Xiubo Li
2017-02-27 19:32 ` how to unmap pages in an anonymous mmap? Andy Grover
2017-02-27 19:32 ` Andy Grover
2017-03-10 1:45 ` Xiubo Li
2017-03-10 1:45 ` Xiubo Li
2017-03-10 1:45 ` Xiubo Li
2017-02-27 23:56 ` [PATCH] target/user: Add daynmic growing data area feature support Mike Christie
2017-02-28 1:22 ` [PATCH] target/user: Add daynmic growing data area featuresupport Xiubo Li
2017-02-28 18:13 ` Mike Christie [this message]
2017-03-01 1:22 ` Xiubo Li
2017-02-28 9:13 ` Xiubo Li
2017-03-01 10:53 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58B5BDC2.3040300@redhat.com \
--to=mchristi@redhat.com \
--cc=agrover@redhat.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=hujianfei@cmss.chinamobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=nab@linux-iscsi.org \
--cc=namei.unix@gmail.com \
--cc=sheng@yasker.org \
--cc=shli@kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=vshankar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.