From: Zhi Wang <zhi.a.wang@intel.com>
To: bing.niu@intel.com, intel-gfx@lists.freedesktop.org
Cc: zhiyuan.lv@intel.com
Subject: Re: [PATCH] drm/i915: suppress atomic commit error message under gvt-g env
Date: Fri, 03 Mar 2017 10:56:16 +0800 [thread overview]
Message-ID: <58B8DB50.7080708@intel.com> (raw)
In-Reply-To: <1488541988-22666-1-git-send-email-bing.niu@intel.com>
Can we directly use DRM_DEBUG_KMS() for this periodic error message?
On 03/03/17 19:53, bing.niu@intel.com wrote:
> From: Bing Niu <bing.niu@intel.com>
>
> under virtualization enviroment, it is possible guest update pipe
> registers across vblank intervals due to overhead of mmio traps or vm
> schedule out. However, it is safe since those pipe update happen in
> virual registers and will not be committed to hardware. suppress that
> atomic commit error message under virtualization case to avoid
> confusing user.
>
> Signed-off-by: Bing Niu <bing.niu@intel.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index b16a295..5ce1ec6 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -158,6 +158,7 @@ void intel_pipe_update_end(struct intel_crtc *crtc, struct intel_flip_work *work
> int scanline_end = intel_get_crtc_scanline(crtc);
> u32 end_vbl_count = intel_crtc_get_vblank_counter(crtc);
> ktime_t end_vbl_time = ktime_get();
> + struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
>
> if (work) {
> work->flip_queued_vblank = end_vbl_count;
> @@ -184,7 +185,7 @@ void intel_pipe_update_end(struct intel_crtc *crtc, struct intel_flip_work *work
> local_irq_enable();
>
> if (crtc->debug.start_vbl_count &&
> - crtc->debug.start_vbl_count != end_vbl_count) {
> + crtc->debug.start_vbl_count != end_vbl_count && !intel_vgpu_active(dev_priv)) {
> DRM_ERROR("Atomic update failure on pipe %c (start=%u end=%u) time %lld us, min %d, max %d, scanline start %d, end %d\n",
> pipe_name(pipe), crtc->debug.start_vbl_count,
> end_vbl_count,
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-03 3:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 11:53 [PATCH] drm/i915: suppress atomic commit error message under gvt-g env bing.niu
2017-03-03 2:56 ` Zhi Wang [this message]
2017-03-03 4:51 ` Niu, Bing
2017-03-03 11:53 ` Ville Syrjälä
2017-03-06 2:27 ` Zhi Wang
2017-03-03 4:18 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-03-03 11:52 ` [PATCH] " Ville Syrjälä
2017-03-06 2:47 ` bing.niu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58B8DB50.7080708@intel.com \
--to=zhi.a.wang@intel.com \
--cc=bing.niu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.