All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wols Lists <antlists@youngman.org.uk>
To: jes.sorensen@gmail.com
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] Fix oddity where mdadm did not recognise a relative path
Date: Fri, 3 Mar 2017 18:36:16 +0000	[thread overview]
Message-ID: <58B9B7A0.9040602@youngman.org.uk> (raw)
In-Reply-To: <wrfjzih4wt7l.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

> 
> I thought this was still pending but going back, it looks like I did
> apply it. The problem is I noticed a major issue in the patch, which
> doesn't belong in code, it is doing 'if () break' on the same line.

Sorry about that - corporate style and all that :-) but it is important
to not break the standard style.
> 
> Mind sending me a patch to fix that.
> 
> Thanks,
> Jes
> 
Cheers,
Wol

[-- Attachment #2: 0001-Fix-formatting-error.patch --]
[-- Type: text/x-patch, Size: 624 bytes --]

From 945b835cc89fd16279e01f743f8507b80219c8a1 Mon Sep 17 00:00:00 2001
From: Wol <anthony@youngman.org.uk>
Date: Fri, 3 Mar 2017 18:31:52 +0000
Subject: [PATCH] Fix formatting error

---
 mdadm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mdadm.c b/mdadm.c
index b5d89e4..d973ae4 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1902,7 +1902,8 @@ static int misc_list(struct mddev_dev *devlist,
 		switch(dv->devname[0] == '/') {
 			case 0:
 				mdfd = open_dev(dv->devname);
-				if (mdfd >= 0) break;
+				if (mdfd >= 0)
+					break;
 			case 1:
 				mdfd = open_mddev(dv->devname, 1);  
 		}
-- 
2.7.3


      reply	other threads:[~2017-03-03 18:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 19:07 [PATCH] Fix oddity where mdadm did not recognise a relative path Wols Lists
2017-01-29 17:48 ` jes.sorensen
2017-01-29 18:24   ` Wols Lists
2017-03-01 22:03 ` jes.sorensen
2017-03-03 18:36   ` Wols Lists [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58B9B7A0.9040602@youngman.org.uk \
    --to=antlists@youngman.org.uk \
    --cc=jes.sorensen@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.