From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] usb: dwc2: add support for external vbus supply
Date: Mon, 06 Mar 2017 20:36:43 +0800 [thread overview]
Message-ID: <58BD57DB.6020707@rock-chips.com> (raw)
In-Reply-To: <CAPnjgZ19ag4XxBdxUaDNekdgNgX=+tWmNi0dwbUA=SXbdap6eQ@mail.gmail.com>
Hi Simon,
On 12/04/2016 02:27 AM, Simon Glass wrote:
> Hi Marek, Kever,
>
> On 3 December 2016 at 06:15, Marek Vasut <marex@denx.de> wrote:
>> On 12/03/2016 05:29 AM, Simon Glass wrote:
>>> From: Kever Yang <kever.yang@rock-chips.com>
>>>
>>> Some board do not use the dwc2 internal VBUS_DRV signal, but
>>> use a gpio pin to enable the 5.0V VBUS power, add interface to
>>> enable the power in dwc2 driver.
>>>
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>> ---
>>>
>>> Changes in v3:
>>> - Drop use of static variable
>>>
>>> drivers/usb/host/dwc2.c | 39 ++++++++++++++++++++++++++++++++++-----
>>> 1 file changed, 34 insertions(+), 5 deletions(-)
> Just to be clear, I will not be taking this patch. I will await
> Kever's new version based on my ideas in this patch and Marek's
> comments.
>
> This patch was just to help explain how to drop the static variable,
> since that seemed to be a point of confusion.
Thanks very much for your example, and really sorry for missing this patch,
I will send a new version later.
Thanks,
- Kever
>
> Regards,
> Simon
>
>
>
next prev parent reply other threads:[~2017-03-06 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 4:29 [U-Boot] [PATCH v3] usb: dwc2: add support for external vbus supply Simon Glass
2016-12-03 13:15 ` Marek Vasut
2016-12-03 18:27 ` Simon Glass
2016-12-03 18:48 ` Marek Vasut
2017-03-06 12:36 ` Kever Yang [this message]
2017-03-07 2:53 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58BD57DB.6020707@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.