From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes Date: Tue, 7 Mar 2017 16:53:50 +0530 Message-ID: <58BE9846.5090903@ti.com> References: <1488880372-7390-1-git-send-email-kishon@ti.com> <1488880372-7390-6-git-send-email-kishon@ti.com> <090d9947-8003-4608-5e3a-92f62f90eda6@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <090d9947-8003-4608-5e3a-92f62f90eda6@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joao Pinto , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@axis.com Cc: Thomas Petazzoni , Jesper Nilsson , Richard Zhu , Gabriele Paoloni , Jingoo Han , nsekhar@ti.com, Zhou Wang , Murali Karicheri , Niklas Cassel , Lucas Stach List-Id: linux-omap@vger.kernel.org On Tuesday 07 March 2017 04:48 PM, Joao Pinto wrote: > =C0s 9:52 AM de 3/7/2017, Kishon Vijay Abraham I escreveu: >> Previously dbi accessors can be used to access data of size 4 >> bytes. But there might be situations (like accessing >> MSI_MESSAGE_CONTROL in order to set/get the number of required >> MSI interrupts in EP mode) where dbi accessors must >> be used to access data of size 2. This is in preparation for >> adding endpoint mode support to designware driver. >> >> Cc: Jingoo Han >> Cc: Richard Zhu >> Cc: Lucas Stach >> Cc: Murali Karicheri >> Cc: Thomas Petazzoni >> Cc: Niklas Cassel >> Cc: Jesper Nilsson >> Cc: Joao Pinto >> Cc: Zhou Wang >> Cc: Gabriele Paoloni >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/Kconfig | 18 ++++---- >> drivers/pci/dwc/pci-dra7xx.c | 8 ++-- >> drivers/pci/dwc/pci-exynos.c | 16 +++---- >> drivers/pci/dwc/pci-imx6.c | 54 +++++++++++----------- >> drivers/pci/dwc/pci-keystone-dw.c | 13 +++--- >> drivers/pci/dwc/pcie-armada8k.c | 38 ++++++++-------- >> drivers/pci/dwc/pcie-artpec6.c | 6 +-- >> drivers/pci/dwc/pcie-designware-host.c | 18 ++++---- >> drivers/pci/dwc/pcie-designware.c | 77 +++++++++++++++++++------= ------- >> drivers/pci/dwc/pcie-designware.h | 14 +++--- >> drivers/pci/dwc/pcie-hisi.c | 14 +++--- >> 11 files changed, 147 insertions(+), 129 deletions(-) >> >> diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig >> index dfb8a69..cb3d5d0 100644 >> --- a/drivers/pci/dwc/Kconfig >> +++ b/drivers/pci/dwc/Kconfig >> @@ -36,7 +36,7 @@ config PCIE_DW_PLAT >> config PCI_EXYNOS >> bool "Samsung Exynos PCIe controller" >> depends on PCI >> - depends on SOC_EXYNOS5440 >> + depends on SOC_EXYNOS5440 || COMPILE_TEST > = > Kishon, I have the idea that Bjorn suggested some time ago not to use > COMPILE_TEST, because there were some problems in some drivers that needed > specific arch stuff. sigh.. this spilled through from my testing. This Kconfig changes was un-intentional. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes To: Joao Pinto , Bjorn Helgaas , , , , , , References: <1488880372-7390-1-git-send-email-kishon@ti.com> <1488880372-7390-6-git-send-email-kishon@ti.com> <090d9947-8003-4608-5e3a-92f62f90eda6@synopsys.com> From: Kishon Vijay Abraham I Message-ID: <58BE9846.5090903@ti.com> Date: Tue, 7 Mar 2017 16:53:50 +0530 MIME-Version: 1.0 In-Reply-To: <090d9947-8003-4608-5e3a-92f62f90eda6@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , Jesper Nilsson , Richard Zhu , Gabriele Paoloni , Jingoo Han , nsekhar@ti.com, Zhou Wang , Murali Karicheri , Niklas Cassel , Lucas Stach Content-Type: text/plain; charset="windows-1252" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Tuesday 07 March 2017 04:48 PM, Joao Pinto wrote: > =C0s 9:52 AM de 3/7/2017, Kishon Vijay Abraham I escreveu: >> Previously dbi accessors can be used to access data of size 4 >> bytes. But there might be situations (like accessing >> MSI_MESSAGE_CONTROL in order to set/get the number of required >> MSI interrupts in EP mode) where dbi accessors must >> be used to access data of size 2. This is in preparation for >> adding endpoint mode support to designware driver. >> >> Cc: Jingoo Han >> Cc: Richard Zhu >> Cc: Lucas Stach >> Cc: Murali Karicheri >> Cc: Thomas Petazzoni >> Cc: Niklas Cassel >> Cc: Jesper Nilsson >> Cc: Joao Pinto >> Cc: Zhou Wang >> Cc: Gabriele Paoloni >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/Kconfig | 18 ++++---- >> drivers/pci/dwc/pci-dra7xx.c | 8 ++-- >> drivers/pci/dwc/pci-exynos.c | 16 +++---- >> drivers/pci/dwc/pci-imx6.c | 54 +++++++++++----------- >> drivers/pci/dwc/pci-keystone-dw.c | 13 +++--- >> drivers/pci/dwc/pcie-armada8k.c | 38 ++++++++-------- >> drivers/pci/dwc/pcie-artpec6.c | 6 +-- >> drivers/pci/dwc/pcie-designware-host.c | 18 ++++---- >> drivers/pci/dwc/pcie-designware.c | 77 +++++++++++++++++++------= ------- >> drivers/pci/dwc/pcie-designware.h | 14 +++--- >> drivers/pci/dwc/pcie-hisi.c | 14 +++--- >> 11 files changed, 147 insertions(+), 129 deletions(-) >> >> diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig >> index dfb8a69..cb3d5d0 100644 >> --- a/drivers/pci/dwc/Kconfig >> +++ b/drivers/pci/dwc/Kconfig >> @@ -36,7 +36,7 @@ config PCIE_DW_PLAT >> config PCI_EXYNOS >> bool "Samsung Exynos PCIe controller" >> depends on PCI >> - depends on SOC_EXYNOS5440 >> + depends on SOC_EXYNOS5440 || COMPILE_TEST > = > Kishon, I have the idea that Bjorn suggested some time ago not to use > COMPILE_TEST, because there were some problems in some drivers that needed > specific arch stuff. sigh.. this spilled through from my testing. This Kconfig changes was un-intentional. Thanks Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Tue, 7 Mar 2017 16:53:50 +0530 Subject: [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes In-Reply-To: <090d9947-8003-4608-5e3a-92f62f90eda6@synopsys.com> References: <1488880372-7390-1-git-send-email-kishon@ti.com> <1488880372-7390-6-git-send-email-kishon@ti.com> <090d9947-8003-4608-5e3a-92f62f90eda6@synopsys.com> Message-ID: <58BE9846.5090903@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 07 March 2017 04:48 PM, Joao Pinto wrote: > ?s 9:52 AM de 3/7/2017, Kishon Vijay Abraham I escreveu: >> Previously dbi accessors can be used to access data of size 4 >> bytes. But there might be situations (like accessing >> MSI_MESSAGE_CONTROL in order to set/get the number of required >> MSI interrupts in EP mode) where dbi accessors must >> be used to access data of size 2. This is in preparation for >> adding endpoint mode support to designware driver. >> >> Cc: Jingoo Han >> Cc: Richard Zhu >> Cc: Lucas Stach >> Cc: Murali Karicheri >> Cc: Thomas Petazzoni >> Cc: Niklas Cassel >> Cc: Jesper Nilsson >> Cc: Joao Pinto >> Cc: Zhou Wang >> Cc: Gabriele Paoloni >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/Kconfig | 18 ++++---- >> drivers/pci/dwc/pci-dra7xx.c | 8 ++-- >> drivers/pci/dwc/pci-exynos.c | 16 +++---- >> drivers/pci/dwc/pci-imx6.c | 54 +++++++++++----------- >> drivers/pci/dwc/pci-keystone-dw.c | 13 +++--- >> drivers/pci/dwc/pcie-armada8k.c | 38 ++++++++-------- >> drivers/pci/dwc/pcie-artpec6.c | 6 +-- >> drivers/pci/dwc/pcie-designware-host.c | 18 ++++---- >> drivers/pci/dwc/pcie-designware.c | 77 +++++++++++++++++++------------- >> drivers/pci/dwc/pcie-designware.h | 14 +++--- >> drivers/pci/dwc/pcie-hisi.c | 14 +++--- >> 11 files changed, 147 insertions(+), 129 deletions(-) >> >> diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig >> index dfb8a69..cb3d5d0 100644 >> --- a/drivers/pci/dwc/Kconfig >> +++ b/drivers/pci/dwc/Kconfig >> @@ -36,7 +36,7 @@ config PCIE_DW_PLAT >> config PCI_EXYNOS >> bool "Samsung Exynos PCIe controller" >> depends on PCI >> - depends on SOC_EXYNOS5440 >> + depends on SOC_EXYNOS5440 || COMPILE_TEST > > Kishon, I have the idea that Bjorn suggested some time ago not to use > COMPILE_TEST, because there were some problems in some drivers that needed > specific arch stuff. sigh.. this spilled through from my testing. This Kconfig changes was un-intentional. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755094AbdCGL3D (ORCPT ); Tue, 7 Mar 2017 06:29:03 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:35875 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754845AbdCGL2V (ORCPT ); Tue, 7 Mar 2017 06:28:21 -0500 Subject: Re: [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes To: Joao Pinto , Bjorn Helgaas , , , , , , References: <1488880372-7390-1-git-send-email-kishon@ti.com> <1488880372-7390-6-git-send-email-kishon@ti.com> <090d9947-8003-4608-5e3a-92f62f90eda6@synopsys.com> CC: , Jingoo Han , Richard Zhu , Lucas Stach , Murali Karicheri , Thomas Petazzoni , Niklas Cassel , Jesper Nilsson , Zhou Wang , Gabriele Paoloni From: Kishon Vijay Abraham I Message-ID: <58BE9846.5090903@ti.com> Date: Tue, 7 Mar 2017 16:53:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <090d9947-8003-4608-5e3a-92f62f90eda6@synopsys.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 07 March 2017 04:48 PM, Joao Pinto wrote: > Ās 9:52 AM de 3/7/2017, Kishon Vijay Abraham I escreveu: >> Previously dbi accessors can be used to access data of size 4 >> bytes. But there might be situations (like accessing >> MSI_MESSAGE_CONTROL in order to set/get the number of required >> MSI interrupts in EP mode) where dbi accessors must >> be used to access data of size 2. This is in preparation for >> adding endpoint mode support to designware driver. >> >> Cc: Jingoo Han >> Cc: Richard Zhu >> Cc: Lucas Stach >> Cc: Murali Karicheri >> Cc: Thomas Petazzoni >> Cc: Niklas Cassel >> Cc: Jesper Nilsson >> Cc: Joao Pinto >> Cc: Zhou Wang >> Cc: Gabriele Paoloni >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/dwc/Kconfig | 18 ++++---- >> drivers/pci/dwc/pci-dra7xx.c | 8 ++-- >> drivers/pci/dwc/pci-exynos.c | 16 +++---- >> drivers/pci/dwc/pci-imx6.c | 54 +++++++++++----------- >> drivers/pci/dwc/pci-keystone-dw.c | 13 +++--- >> drivers/pci/dwc/pcie-armada8k.c | 38 ++++++++-------- >> drivers/pci/dwc/pcie-artpec6.c | 6 +-- >> drivers/pci/dwc/pcie-designware-host.c | 18 ++++---- >> drivers/pci/dwc/pcie-designware.c | 77 +++++++++++++++++++------------- >> drivers/pci/dwc/pcie-designware.h | 14 +++--- >> drivers/pci/dwc/pcie-hisi.c | 14 +++--- >> 11 files changed, 147 insertions(+), 129 deletions(-) >> >> diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig >> index dfb8a69..cb3d5d0 100644 >> --- a/drivers/pci/dwc/Kconfig >> +++ b/drivers/pci/dwc/Kconfig >> @@ -36,7 +36,7 @@ config PCIE_DW_PLAT >> config PCI_EXYNOS >> bool "Samsung Exynos PCIe controller" >> depends on PCI >> - depends on SOC_EXYNOS5440 >> + depends on SOC_EXYNOS5440 || COMPILE_TEST > > Kishon, I have the idea that Bjorn suggested some time ago not to use > COMPILE_TEST, because there were some problems in some drivers that needed > specific arch stuff. sigh.. this spilled through from my testing. This Kconfig changes was un-intentional. Thanks Kishon