From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:31768 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755817AbdCGU63 (ORCPT ); Tue, 7 Mar 2017 15:58:29 -0500 Subject: Re: [PATCH 1/1] usb: host: xhci-dbg: HCIVERSION should be a binary number To: Peter Chen References: <1488855874-18837-1-git-send-email-peter.chen@nxp.com> Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, Lu Baolu , stable From: Mathias Nyman Message-ID: <58BEC1A8.8070206@linux.intel.com> Date: Tue, 7 Mar 2017 16:20:24 +0200 MIME-Version: 1.0 In-Reply-To: <1488855874-18837-1-git-send-email-peter.chen@nxp.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 07.03.2017 05:04, Peter Chen wrote: > According to xHCI spec, HCIVERSION containing a BCD encoding > of the xHCI specification revision number, 0100h corresponds > to xHCI version 1.0. Change "100" as "0x100". > > Cc: Lu Baolu > Cc: stable > Fixes: 04abb6de2825 ("xhci: Read and parse new xhci > 1.1 capability register") > Signed-off-by: Peter Chen > --- > drivers/usb/host/xhci-dbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c > index 363d125..2b4a00f 100644 > --- a/drivers/usb/host/xhci-dbg.c > +++ b/drivers/usb/host/xhci-dbg.c > @@ -109,7 +109,7 @@ static void xhci_print_cap_regs(struct xhci_hcd *xhci) > xhci_dbg(xhci, "RTSOFF 0x%x:\n", temp & RTSOFF_MASK); > > /* xhci 1.1 controllers have the HCCPARAMS2 register */ > - if (hci_version > 100) { > + if (hci_version > 0x100) { > temp = readl(&xhci->cap_regs->hcc_params2); > xhci_dbg(xhci, "HCC PARAMS2 0x%x:\n", (unsigned int) temp); > xhci_dbg(xhci, " HC %s Force save context capability", > Thanks, queuing this -Mathias